Issue metadata
Sign in to add a comment
|
1.5%-500% regression in webrtc_perf_tests at 25662:25662 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Nov 20
Can you please have a look.
,
Nov 20
How can I rerun these metrics to see if my changes fix the issues?
,
Nov 21
To run the tests, e.g: /out/Release/webrtc_perf_tests --gtest_filter=RampUpTest.* /out/Release/webrtc_perf_tests --gtest_filter=FullStackTest.*
,
Nov 21
Yeah, these didn't repro the from windows regressions, and seem flaky (every time i run them I get different numbers). I was hoping there was a way to run them comparing them to the values in the chromeperf.appspot automatically, or that there is a way to simply run a trybot that would simply generate these sort of stats/graphs. I have sent out https://webrtc-review.googlesource.com/c/src/+/111700 that changes the bandwidth reported in the previous bug that you reported, but I don't know if this helps with these issues.
,
Dec 19
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/b27578801673769f8a1393c2bd11b8c2fd7fb850 commit b27578801673769f8a1393c2bd11b8c2fd7fb850 Author: Piotr (Peter) Slatala <psla@webrtc.org> Date: Wed Dec 19 21:19:01 2018 Register stat callbacks after rate observer is registered. Currently the stats callback is registered too early. For now we ignore media transport for these callbacks (it was ignored already), and we will introduce changes to media transport in the future. Bug: webrtc:9719 Bug: chromium:906998 Bug: chromium:906533 Change-Id: I24c0265d46ec2eb35743de6cd96a11d8c41fefbe Reviewed-on: https://webrtc-review.googlesource.com/c/114904 Reviewed-by: Sebastian Jansson <srte@webrtc.org> Commit-Queue: Peter Slatala <psla@webrtc.org> Cr-Commit-Position: refs/heads/master@{#26062} [modify] https://crrev.com/b27578801673769f8a1393c2bd11b8c2fd7fb850/call/call.cc
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dc073b965af6b98b556d7941d665cba3fd09904 commit 5dc073b965af6b98b556d7941d665cba3fd09904 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Dec 20 02:43:45 2018 Roll src/third_party/webrtc e92035179825..b27578801673 (2 commits) https://webrtc.googlesource.com/src.git/+log/e92035179825..b27578801673 git log e92035179825..b27578801673 --date=short --no-merges --format='%ad %ae %s' 2018-12-19 Peter) Slatala Register stat callbacks after rate observer is registered. 2018-12-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7ebbeeebe7..bdf260ef72 (617780:617896) Created with: gclient setdep -r src/third_party/webrtc@b27578801673 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG= chromium:906998 , chromium:906533 ,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I076149b9302b111693c4692a5295268fe19b99b7 Reviewed-on: https://chromium-review.googlesource.com/c/1385566 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618084} [modify] https://crrev.com/5dc073b965af6b98b556d7941d665cba3fd09904/DEPS
,
Dec 27
recovered as of https://webrtc-review.googlesource.com/c/src/+/114904 Examples: https://chromeperf.appspot.com/report?sid=0d267b9d81e64c3f6e516c4b46242c947bf8cf2185436ab8a52c90c78c819905&start_rev=25574&end_rev=26101
,
Jan 8
Added some alerts (that doesn't seem to have recovered though?)
,
Jan 8
srte@ not sure I understand your comment?
,
Jan 8
I added some graphs to https://chromeperf.appspot.com/group_report?bug_id=906998 that seems to be related.
,
Jan 8
ah, ok. But there is no action for me, thx! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 20