New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 906995 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 882777

Blocking:
issue 880735



Sign in to add a comment

[Sync] Stop (some) datatypes in the sync-paused (DiCE signed-out) state and reconfigure them again after sign-in

Project Member Reported by jkrcal@chromium.org, Nov 20

Issue description

When users on desktop sign-out of their content-area account, Sync enters a paused state that is triggered by an sign-in auth error. 

We should implement a proper solution and stop sync, instead. Namely:
 - After sign-out, state of ProfileSyncService should be clear about sync being stopped. The service should stop all data types. As a result, each data type can react to the situation accordingly (for instance, WALLET_DATA needs to get wiped when sync is not active).
 - After sign-in, sync should start again and reconfigure all data types. Thus, each data type perform its standard start-up procedure (for instance, WALLET_DATA can fetch all its data again).
 
Blocking: 880735
Owner: mastiz@chromium.org
Status: Started (was: Available)
Summary: [Sync] Stop (some) datatypes in the sync-paused (DiCE signed-out) state and reconfigure them again after sign-in (was: [Sync] Stop datatypes in the sync-paused (DiCE signed-out) state and reconfigure them again after sign-in)
Taking this over.

As per our latest discussion, we cannot stop all datatypes because directory datatypes would stop tracking local changes (and run into various issues like local preference changes being reverted when sync resumes).

Instead, we decided to introduce a new function in DataTypeController that allows datatypes to introduce custom logic (usually self stopping) when sync is paused.
Blockedon: 882777

Sign in to add a comment