New issue
Advanced search Search tips

Issue 906991 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 835717

Blocking:
issue 731604


Participants' hotlists:
Worker-OffTheMainThread


Sign in to add a comment

Implement browser-initiated dedicated worker script loading (PlzDedicatedWorker)

Project Member Reported by nhiroki@chromium.org, Nov 20

Issue description

This is an effort to make dedicated worker script loading aligned with other main resource loading (PlzNavigate and PlzSharedWorker), and make it easier to fix service worker scope match with dedicated workers (issue 731604)
 
Status: Started (was: Assigned)
Blockedon: 835717
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca69fde398277c0bf81225f1521d93cdf1f97e0f

commit ca69fde398277c0bf81225f1521d93cdf1f97e0f
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Mon Nov 26 09:28:27 2018

PlzWorker: Factor out loader setup code from SharedWorkerServiceImpl to WorkerScriptFetchInitiator

As a preparation of PlzDedicatedWorker, this CL makes browser-side loader
classes for PlzSharedWorker reusable for PlzDedicatedWorker. Specifically, this
CL introduces WorkerScriptFetchInitiator that is a static class to abstract
SharedWorkerScriptFetcher and SharedWorkerScriptLoader. This doesn't change
functional behavior.

WorkerScriptFetchInitiator is now used only by SharedWorkerServiceImpl, but it
will also be used by DedicatedWorkerHost in a follow-up CL.

Next plan: Rename SharedWorkerScriptFetcher and SharedWorkerScriptLoader to
WorkerScriptFetcher and WorkerScriptLoader respectively, and remove shared
worker specific code from WorkerScriptFetchInitiator. See the design doc for
details:
https://docs.google.com/document/d/1fWsD0oIa5sNDfUFWGJZ41pDo3zzsbFGyQSNdV8nOG4I/edit?usp=sharing

Change-Id: Iae37ebb8fec6f0843df4c11fac8c9d8abe5b6667
Bug: 906991
Reviewed-on: https://chromium-review.googlesource.com/c/1345704
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610790}
[modify] https://crrev.com/ca69fde398277c0bf81225f1521d93cdf1f97e0f/content/browser/BUILD.gn
[modify] https://crrev.com/ca69fde398277c0bf81225f1521d93cdf1f97e0f/content/browser/shared_worker/shared_worker_service_impl.cc
[modify] https://crrev.com/ca69fde398277c0bf81225f1521d93cdf1f97e0f/content/browser/shared_worker/shared_worker_service_impl.h
[add] https://crrev.com/ca69fde398277c0bf81225f1521d93cdf1f97e0f/content/browser/shared_worker/worker_script_fetch_initiator.cc
[add] https://crrev.com/ca69fde398277c0bf81225f1521d93cdf1f97e0f/content/browser/shared_worker/worker_script_fetch_initiator.h

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c

commit 1d7e84e1fde44c2b52a31b0d52d81a9cee47631c
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Tue Nov 27 13:15:16 2018

PlzWorker: Rename SharedWorkerScript* to WorkerScript*

To make browser-side loader classes for PlzSharedWorker reusable for
PlzDedicatedWorker, this CL renames the classes as follows:

- SharedWorkerScriptFetcher => WorkerScriptFetcher
- SharedWorkerScriptLoader => WorkerScriptLoader
- SharedWorkerScriptLoaderFactory => WorkerScriptLoaderFactory
- SharedWorkerMainScriptLoadParams => WorkerMainScriptLoadParams

This doesn't change functional behavior.

See the design doc for details:
https://docs.google.com/document/d/1fWsD0oIa5sNDfUFWGJZ41pDo3zzsbFGyQSNdV8nOG4I/edit?usp=sharing

Bug: 906991
Change-Id: If25f463655f2f53a533a6c1504f57f05937860a1
Reviewed-on: https://chromium-review.googlesource.com/c/1350018
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611084}
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/BUILD.gn
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/mock_shared_worker.cc
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/mock_shared_worker.h
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/shared_worker_host.h
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/shared_worker_host_unittest.cc
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/shared_worker_service_impl.cc
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/shared_worker_service_impl.h
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/worker_script_fetch_initiator.cc
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/worker_script_fetch_initiator.h
[rename] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/worker_script_fetcher.cc
[rename] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/worker_script_fetcher.h
[rename] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/worker_script_loader.cc
[rename] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/worker_script_loader.h
[rename] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/worker_script_loader_factory.cc
[rename] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/browser/shared_worker/worker_script_loader_factory.h
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/renderer/shared_worker/shared_worker_factory_impl.cc
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/content/renderer/shared_worker/shared_worker_factory_impl.h
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/third_party/blink/public/mojom/shared_worker/worker_main_script_load_params.mojom
[modify] https://crrev.com/1d7e84e1fde44c2b52a31b0d52d81a9cee47631c/tools/traffic_annotation/summary/annotations.xml

Cc: dgozman@chromium.org
Does this cover the issue 899416 as well? It is about a similar dedicated worker host in the browser, so perhaps we should take care of that?
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18f6587b5be711c9c1d94a404a61ed943edecbe9

commit 18f6587b5be711c9c1d94a404a61ed943edecbe9
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Wed Nov 28 01:52:03 2018

PlzWorker: Move browser-side worker classes to content/browser/worker_host/

This CL adds content/browser/worker_host/ directory, and moves files under
content/browser/dedicated_worker/ and content/browser/shared_worker/ to the
directory so that browser-side loader classes are sharable between dedicated
workers and shared workers.

See the design doc for details:
https://docs.google.com/document/d/1fWsD0oIa5sNDfUFWGJZ41pDo3zzsbFGyQSNdV8nOG4I/edit?usp=sharing

Bug: 906991
Change-Id: Ibe2a342495589abab10c08c83ab801ae4f1bceee
Reviewed-on: https://chromium-review.googlesource.com/c/1351198
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611503}
[modify] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/BUILD.gn
[delete] https://crrev.com/ca3f4f91e17a839d99fc446129a4dca62ee84141/content/browser/dedicated_worker/OWNERS
[delete] https://crrev.com/ca3f4f91e17a839d99fc446129a4dca62ee84141/content/browser/dedicated_worker/README.md
[modify] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/devtools/shared_worker_devtools_agent_host.cc
[modify] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/devtools/shared_worker_devtools_manager.cc
[modify] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/service_worker/service_worker_tls_browsertest.cc
[modify] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/storage_partition_impl.h
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/DEPS
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/OWNERS
[add] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/README.md
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/dedicated_worker_host.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/dedicated_worker_host.h
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/mock_shared_worker.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/mock_shared_worker.h
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/shared_worker_connector_impl.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/shared_worker_connector_impl.h
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/shared_worker_content_settings_proxy_impl.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/shared_worker_content_settings_proxy_impl.h
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/shared_worker_host.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/shared_worker_host.h
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/shared_worker_host_unittest.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/shared_worker_instance.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/shared_worker_instance.h
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/shared_worker_instance_unittest.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/shared_worker_service_impl.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/shared_worker_service_impl.h
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/shared_worker_service_impl_unittest.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/worker_browsertest.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/worker_script_fetch_initiator.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/worker_script_fetch_initiator.h
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/worker_script_fetcher.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/worker_script_fetcher.h
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/worker_script_loader.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/worker_script_loader.h
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/worker_script_loader_factory.cc
[rename] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/browser/worker_host/worker_script_loader_factory.h
[modify] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/test/BUILD.gn
[modify] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/content/test/layouttest_support.cc
[modify] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/third_party/blink/public/mojom/shared_worker/OWNERS
[modify] https://crrev.com/18f6587b5be711c9c1d94a404a61ed943edecbe9/tools/traffic_annotation/summary/annotations.xml

dgozman@: I think this doesn't cover the issue but may affect the design choice. In this issue, I'm going to hook up the browser-side script loaders with DedicatedWorkerHost like this CL (still very immature):
https://chromium-review.googlesource.com/c/chromium/src/+/1352084
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f3efe05f786e374282187cb3c14c7af2ebc7b5b

commit 9f3efe05f786e374282187cb3c14c7af2ebc7b5b
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Wed Nov 28 04:01:45 2018

Worker: Create WebWorkerFetchContext in DedicatedWorker::CreateGlobalScopeCreationParams()

This CL moves WebWorkerFetchContext creation from
ThreadedMessagingProxy::StartGlobalScope() to
Dedicatedworker::CreateGlobalScopeCreationParams() in order to put params
construction in one place for code cleanup.

Bug: 906991
Change-Id: I7a365bbc0706f271b61e9f56648f9b7a47506dd8
Reviewed-on: https://chromium-review.googlesource.com/c/1351199
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611553}
[modify] https://crrev.com/9f3efe05f786e374282187cb3c14c7af2ebc7b5b/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/9f3efe05f786e374282187cb3c14c7af2ebc7b5b/third_party/blink/renderer/core/workers/dedicated_worker.h
[modify] https://crrev.com/9f3efe05f786e374282187cb3c14c7af2ebc7b5b/third_party/blink/renderer/core/workers/threaded_messaging_proxy_base.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdbc7919ba70cecc6f16b3d0a362799d5167d958

commit cdbc7919ba70cecc6f16b3d0a362799d5167d958
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Nov 30 11:30:05 2018

OnionSoup: Move ControllerServiceWorker from content/ to blink/

This CL moves
  //content/common/service_worker/controller_service_worker.mojom
to
  //third_party/blink/public/mojom/service_worker/controller_service_worker.mojom

Change-Id: I14e2c8619f7bb84ae839f1c8a2eb7c9e1aa9f6b4
Bug:  789846 , 906991
Reviewed-on: https://chromium-review.googlesource.com/c/1355317
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612616}
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/cookie_store/cookie_store_manager_unittest.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/service_worker/embedded_worker_instance.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/service_worker/service_worker_object_host_unittest.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/worker_host/mock_shared_worker.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/worker_host/mock_shared_worker.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/browser/worker_host/shared_worker_host.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/common/BUILD.gn
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/common/frame.mojom
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/common/navigation_client.mojom
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/common/navigation_subresource_loader_params.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/navigation_client.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/navigation_client.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/render_frame_impl.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/controller_service_worker_connector.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/controller_service_worker_connector.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/controller_service_worker_impl.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/controller_service_worker_impl.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/service_worker_network_provider.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/service_worker_provider_state_for_client.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/shared_worker/shared_worker_factory_impl.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/renderer/shared_worker/shared_worker_factory_impl.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/test/mock_navigation_client_impl.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/test/mock_navigation_client_impl.h
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/content/test/test_render_frame.cc
[modify] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/cdbc7919ba70cecc6f16b3d0a362799d5167d958/third_party/blink/public/mojom/service_worker/controller_service_worker.mojom

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32376a5f238509741027ddac5b86bc73dd5bd4ab

commit 32376a5f238509741027ddac5b86bc73dd5bd4ab
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Mon Dec 03 10:49:23 2018

PlzWorker: Rename shared_worker/ to worker/ in third_party/blink/public/mojom/

This makes worker_main_script_load_params.mojom in the directory reusable for
PlzDedicatedWorker.

Bug: 906991
Change-Id: I5a5768bab54f7fa76c758afbfcc1f3bd22928385
Reviewed-on: https://chromium-review.googlesource.com/c/1358197
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613038}
[modify] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/content/browser/worker_host/shared_worker_host.h
[modify] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/content/browser/worker_host/shared_worker_instance.h
[modify] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/content/browser/worker_host/shared_worker_service_impl.h
[modify] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/content/browser/worker_host/worker_script_fetch_initiator.h
[modify] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/content/browser/worker_host/worker_script_fetcher.h
[modify] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/content/common/shared_worker/shared_worker_client.mojom
[modify] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/content/common/shared_worker/shared_worker_connector.mojom
[modify] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/third_party/blink/public/mojom/worker/OWNERS
[rename] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/third_party/blink/public/mojom/worker/shared_worker_creation_context_type.mojom
[rename] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/third_party/blink/public/mojom/worker/worker_main_script_load_params.mojom
[modify] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/third_party/blink/public/web/web_shared_worker_connect_listener.h
[modify] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/third_party/blink/public/web/web_shared_worker_repository_client.h

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c30b9f0f69e114462915ac35c04ee5c3db282727

commit c30b9f0f69e114462915ac35c04ee5c3db282727
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Mon Dec 03 11:26:01 2018

PlzWorker: Move dedicated_worker_factory.mojom from public/platform to public/mojom/worker

Public mojom files for dedicated workers and shared workers should be placed in
public/mojom/worker.

Bug: 906991
Change-Id: I570f91823247349609afb3ce0ba62880ba14cf27
Reviewed-on: https://chromium-review.googlesource.com/c/1358291
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613046}
[modify] https://crrev.com/c30b9f0f69e114462915ac35c04ee5c3db282727/content/browser/DEPS
[modify] https://crrev.com/c30b9f0f69e114462915ac35c04ee5c3db282727/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/c30b9f0f69e114462915ac35c04ee5c3db282727/content/browser/worker_host/dedicated_worker_host.h
[modify] https://crrev.com/c30b9f0f69e114462915ac35c04ee5c3db282727/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/c30b9f0f69e114462915ac35c04ee5c3db282727/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/c30b9f0f69e114462915ac35c04ee5c3db282727/third_party/blink/public/mojom/worker/dedicated_worker_factory.mojom
[modify] https://crrev.com/c30b9f0f69e114462915ac35c04ee5c3db282727/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/c30b9f0f69e114462915ac35c04ee5c3db282727/third_party/blink/renderer/core/workers/experimental/thread_pool.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75375834089ef48460531f428c97a100ebeeb331

commit 75375834089ef48460531f428c97a100ebeeb331
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Dec 27 04:13:49 2018

OnionSoup: Move URLLoaderFactoryBundle from content/ to blink/

As a part of the Onion Soup project, this CL moves files for
URLLoaderFactoryBundle as follows:

1) from content/common/ to blink/public/common/loader/

  - url_loader_factory_bundle.h
  - url_loader_factory_bundle.typemap
  - url_loader_factory_bundle_struct_traits.h
    (renamed to url_loader_factory_bundle_mojom_traits.h)

2) from content/common/ to blink/common/loader/

  - url_loader_factory_bundle.cc
  - url_loader_factory_bundle_struct_traits.cc
    (renamed to url_loader_factory_bundle_mojom_traits.cc)

3) from content/common/ to blink/public/mojom/loader/

  - url_loader_factory_bundle.mojom

Change-Id: I18aff72e7201ec78890414b30903e9aaa9b32455
Bug: 906991
Reviewed-on: https://chromium-review.googlesource.com/c/1354741
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619003}
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/browser/loader/prefetch_url_loader_service.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/browser/worker_host/mock_shared_worker.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/browser/worker_host/mock_shared_worker.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/browser/worker_host/shared_worker_host.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/browser/worker_host/shared_worker_host.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/browser/worker_host/shared_worker_host_unittest.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/browser/worker_host/shared_worker_service_impl.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/browser/worker_host/shared_worker_service_impl.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/browser/worker_host/worker_script_fetch_initiator.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/browser/worker_host/worker_script_fetch_initiator.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/common/BUILD.gn
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/common/frame.mojom
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/common/navigation_client.mojom
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/common/typemaps.gni
[delete] https://crrev.com/4457234be9f907f918f6bac9073bcec9ba8851f2/content/common/url_loader_factory_bundle.typemap
[delete] https://crrev.com/4457234be9f907f918f6bac9073bcec9ba8851f2/content/common/url_loader_factory_bundle_struct_traits.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/renderer/loader/child_url_loader_factory_bundle.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/renderer/loader/tracked_child_url_loader_factory_bundle.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/renderer/loader/tracked_child_url_loader_factory_bundle.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/renderer/navigation_client.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/renderer/navigation_client.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/renderer/render_frame_impl.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/renderer/shared_worker/shared_worker_factory_impl.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/renderer/shared_worker/shared_worker_factory_impl.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/test/mock_navigation_client_impl.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/test/mock_navigation_client_impl.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/content/test/test_render_frame.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/third_party/blink/common/BUILD.gn
[add] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/third_party/blink/common/loader/OWNERS
[rename] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/third_party/blink/common/loader/url_loader_factory_bundle.cc
[rename] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/third_party/blink/common/loader/url_loader_factory_bundle_mojom_traits.cc
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/third_party/blink/public/common/BUILD.gn
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/third_party/blink/public/common/DEPS
[add] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/third_party/blink/public/common/loader/OWNERS
[rename] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/third_party/blink/public/common/loader/url_loader_factory_bundle.h
[add] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/third_party/blink/public/common/loader/url_loader_factory_bundle.typemap
[add] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/third_party/blink/public/common/loader/url_loader_factory_bundle_mojom_traits.h
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/third_party/blink/public/mojom/loader/url_loader_factory_bundle.mojom
[modify] https://crrev.com/75375834089ef48460531f428c97a100ebeeb331/third_party/blink/public/public_typemaps.gni

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b48e1f44e84ddf5055ba10b8855dc39db0d0a15

commit 4b48e1f44e84ddf5055ba10b8855dc39db0d0a15
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Tue Jan 08 06:01:50 2019

Worker: Move WebServiceWorkerNetworkProviderForSharedWorker to its own file

Before this CL, WebServiceWorkerNetworkProviderForSharedWorker is defined in
embedded_shared_worker_stub.cc.

This CL moves WebServiceWorkerNetworkProviderForSharedWorker into its own file,
and renames it to WebServiceWorkerNetworkProviderImplForWorker so that it's
reusable for dedicated workers(*).

(*) Currently, dedicated workers use parent document's
WebServiceWorkerNetworkProviderForFrame(**). After PlzDedicatedWorker is
implemented, dedicated workers have their own network provider, that is,
WebServiceWorkerNetworkProviderImplForWorker.

(**) WebServiceWorkerNetworkProviderForFrame will be renamed to
WebServiceWorkerNetworkProvider*Impl*ForFrame in a follow-up CL to clarify it's
the implementation of WebServiceWorkerNetworkProvider for Frame.

Bug: 906991
Change-Id: I8c7ebd60aff2e20f4082a44eef43338ce23584ba
Reviewed-on: https://chromium-review.googlesource.com/c/1391659
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620637}
[modify] https://crrev.com/4b48e1f44e84ddf5055ba10b8855dc39db0d0a15/content/renderer/BUILD.gn
[modify] https://crrev.com/4b48e1f44e84ddf5055ba10b8855dc39db0d0a15/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[add] https://crrev.com/4b48e1f44e84ddf5055ba10b8855dc39db0d0a15/content/renderer/shared_worker/web_service_worker_network_provider_impl_for_worker.cc
[add] https://crrev.com/4b48e1f44e84ddf5055ba10b8855dc39db0d0a15/content/renderer/shared_worker/web_service_worker_network_provider_impl_for_worker.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51a6a7e7d3d73519b6e2c262efa2ebcb948ff361

commit 51a6a7e7d3d73519b6e2c262efa2ebcb948ff361
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Tue Jan 15 10:32:34 2019

Worker: Deduplicate WebWorkerFetchContext creation code

There are duplicate code between RenderFrameImpl::CreateWorkerFetchContext() and
EmbeddedSharedWorkerStub::CreateWorkerFetchContext(). This CL factors them out
into WebWorkerFetchContext::Create() for cleanup.

Bug: 906991
Change-Id: Ic912e6b7b62777c2334ec51e21036b129296eb1a
Reviewed-on: https://chromium-review.googlesource.com/c/1405123
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622802}
[modify] https://crrev.com/51a6a7e7d3d73519b6e2c262efa2ebcb948ff361/content/renderer/loader/web_worker_fetch_context_impl.cc
[modify] https://crrev.com/51a6a7e7d3d73519b6e2c262efa2ebcb948ff361/content/renderer/loader/web_worker_fetch_context_impl.h
[modify] https://crrev.com/51a6a7e7d3d73519b6e2c262efa2ebcb948ff361/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/51a6a7e7d3d73519b6e2c262efa2ebcb948ff361/content/renderer/shared_worker/embedded_shared_worker_stub.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77b455b992f1de3dd069d4c9009650fcf632dfcd

commit 77b455b992f1de3dd069d4c9009650fcf632dfcd
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Wed Jan 16 07:15:49 2019

Worker: Consolidate setup routines of WebWorkerFetchContextImpl

This just cleans up setup routines of WebWorkerFetchContextImpl, and doesn't
change functional behavior.

Bug: 906991
Change-Id: I01cb433b31399c36964adbda9cb5a1c799ec3677
Reviewed-on: https://chromium-review.googlesource.com/c/1412096
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623145}
[modify] https://crrev.com/77b455b992f1de3dd069d4c9009650fcf632dfcd/content/renderer/loader/web_worker_fetch_context_impl.cc
[modify] https://crrev.com/77b455b992f1de3dd069d4c9009650fcf632dfcd/content/renderer/loader/web_worker_fetch_context_impl.h
[modify] https://crrev.com/77b455b992f1de3dd069d4c9009650fcf632dfcd/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/77b455b992f1de3dd069d4c9009650fcf632dfcd/content/renderer/shared_worker/embedded_shared_worker_stub.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a09c7c9b43bcdb9d0cb1c84439e3061cab1bbbc

commit 7a09c7c9b43bcdb9d0cb1c84439e3061cab1bbbc
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Jan 18 10:24:34 2019

ServiceWorker: Make FromWebServiceWorkerNetworkProvider() available for workers

FromWebServiceWorkerNetworkProvider takes WebServiceWorkerNetworkProvider as an
argument.

Before this CL, contrary to the function name, the function implicitly assumes
the given network provider is WebServiceWorkerNetworkProviderImplForFrame. This
seems confusing. Actually, in the previous CL[1], I used it with
WebServiceWorkerNetworkProviderImplForWorker in EmbeddedSharedWorkerStub, and it
resulted in type conversion failures from ImplForWorker to ImplForFrame on
static_cast.

To fix it, this CL introduces WebServiceWorkerNetworkProviderBaseImpl as the
base class of both ProviderImplForFrame and ProviderImplForWorker, and makes
FromWebServiceWorkerNetworkProvider() take the base class as the argument. Also,
this CL moves some common functions from the derived classes to the base class.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1405123

Bug: 906991, 922077
Change-Id: I7f95d41457dc5f68e15b5676fe79f2755d27176a
Reviewed-on: https://chromium-review.googlesource.com/c/1420157
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624056}
[modify] https://crrev.com/7a09c7c9b43bcdb9d0cb1c84439e3061cab1bbbc/content/renderer/BUILD.gn
[modify] https://crrev.com/7a09c7c9b43bcdb9d0cb1c84439e3061cab1bbbc/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/7a09c7c9b43bcdb9d0cb1c84439e3061cab1bbbc/content/renderer/service_worker/service_worker_network_provider.h
[add] https://crrev.com/7a09c7c9b43bcdb9d0cb1c84439e3061cab1bbbc/content/renderer/service_worker/web_service_worker_network_provider_base_impl.cc
[add] https://crrev.com/7a09c7c9b43bcdb9d0cb1c84439e3061cab1bbbc/content/renderer/service_worker/web_service_worker_network_provider_base_impl.h
[modify] https://crrev.com/7a09c7c9b43bcdb9d0cb1c84439e3061cab1bbbc/content/renderer/shared_worker/web_service_worker_network_provider_impl_for_worker.cc
[modify] https://crrev.com/7a09c7c9b43bcdb9d0cb1c84439e3061cab1bbbc/content/renderer/shared_worker/web_service_worker_network_provider_impl_for_worker.h

Project Member

Comment 17 by bugdroid1@chromium.org, Yesterday (35 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61ee004d1d509463724f2889b1706a8d51922a29

commit 61ee004d1d509463724f2889b1706a8d51922a29
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Tue Jan 22 06:30:26 2019

PlzWorker: Add a runtime flag for PlzDedicatedWorker

This flag is not used in this change yet.

Bug: 906991
Change-Id: I9da9f5ad25a5bdc9f16bb30905188bbee5c615d7
Reviewed-on: https://chromium-review.googlesource.com/c/1424759
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624736}
[modify] https://crrev.com/61ee004d1d509463724f2889b1706a8d51922a29/third_party/blink/common/features.cc
[modify] https://crrev.com/61ee004d1d509463724f2889b1706a8d51922a29/third_party/blink/public/common/features.h

Sign in to add a comment