New issue
Advanced search Search tips

Issue 906983 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove files app support for querying the board

Project Member Reported by sa...@chromium.org, Nov 20

Issue description

Files app supports querying the board prefix. It's used just for link to show a different Drive quota. Since link is end of life now, remove this obsolete functionality.
 
Cc: weifangsun@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54762d76a24aa8e5bfd637b76f9678646aa73ae3

commit 54762d76a24aa8e5bfd637b76f9678646aa73ae3
Author: Sam McNally <sammc@chromium.org>
Date: Tue Nov 20 09:04:14 2018

Remove util.boardIs and its one user.

Querying the board from the files app is only used for deciding which
Drive promo to display: specifically, whether the board is link, which
is now AUE. This is now unnecessary so remove it.

Bug:  906983 
Change-Id: Ia98c9e96b81609fdacd46a4d464da18a6cbd1fdc
Reviewed-on: https://chromium-review.googlesource.com/c/1343591
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609634}
[modify] https://crrev.com/54762d76a24aa8e5bfd637b76f9678646aa73ae3/chrome/app/file_manager_strings.grdp
[modify] https://crrev.com/54762d76a24aa8e5bfd637b76f9678646aa73ae3/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/54762d76a24aa8e5bfd637b76f9678646aa73ae3/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/54762d76a24aa8e5bfd637b76f9678646aa73ae3/ui/file_manager/file_manager/foreground/js/ui/banners.js
[modify] https://crrev.com/54762d76a24aa8e5bfd637b76f9678646aa73ae3/ui/file_manager/file_manager/test/js/strings.js

Status: Fixed (was: Assigned)

Sign in to add a comment