New issue
Advanced search Search tips

Issue 906981 link

Starred by 1 user
Status: Fixed
Owner:
aee@chromium.org
Closed: Dec 20
Cc:
ajha@chromium.org
dpa...@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Chrome://settings/help/details page opening is not smooth while redirecting from chrome://settings/help page

Project Member Reported by rkalavakuntla@chromium.org, Nov 20 
Chrome Version:72.0.3612.0/11278.0.0 dev-channel Celes,Daisy,Kip
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign into user >> go to chrome://settings/help page
(2)Click on Detailed build information and observe while page loads(Please refer video)

Actual: chrome://settings/help/details page loading is not smooth
Expected: chrome://settings/help/details page should open smoothly

This is a Regression issue as same works fine in 72.0.3593.0/11216.0.0 dev
Actual.mp4
10.5 MB View Download
Expected.mp4
8.1 MB View Download

Comment 1 by dpa...@chromium.org, Nov 20

Cc: dpa...@chromium.org
FYI, I am removing page/subpage animations as part of issue 902959. This is likely to affect this behavior anyway, although it might land after the M72 branch  cut.

Comment 2 by dpa...@chromium.org, Dec 10 

The "not smooth" part of this bug has been fixed by issue 902959 (no more animations), but there is still la bug here. While in the subpage, there should be no "About ChromeOS" title visible (attaching screenshots).
title_shown.png
42.6 KB View Download
title_hidden.png
56.2 KB View Download

Comment 3 by dpa...@chromium.org, Dec 11

Labels: -Pri-1 Pri-2
Owner: aee@chromium.org
Status: Assigned (was: Untriaged)
@aee: It seems that the change at [1] caused a regression where the "About Chrome OS" title is visible even when the user is within the chrome://settings/help/details subpage. See screenshot in previous comments for current and expected.


[1] https://chromium-review.googlesource.com/c/chromium/src/+/1311803

Comment 4 by aee@chromium.org, Dec 19

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd431ba26f7ab34bd0f283e48dca52334affd9f3

commit fd431ba26f7ab34bd0f283e48dca52334affd9f3
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Dec 20 00:20:37 2018

Settings WebUI: about page, make product title h1

This CL address the request to make the product title h1 in
 https://crbug.com/870460 . Also it undoes the change
 https://crbug.com/870460#c11  which mistakenly changed the "About Chrome"
section title to h1.

Bug:  906981 
Change-Id: I21b54e5ca8c0dd104f44bb74bef9ac529761e133
Reviewed-on: https://chromium-review.googlesource.com/c/1384943
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618025}
[modify] https://crrev.com/fd431ba26f7ab34bd0f283e48dca52334affd9f3/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/fd431ba26f7ab34bd0f283e48dca52334affd9f3/chrome/browser/resources/settings/settings_page/settings_section.html

Comment 6 by aee@chromium.org, Dec 20

Status: Fixed (was: Started)
►

Sign in to add a comment