New issue
Advanced search Search tips

Issue 906968 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 890545



Sign in to add a comment

Sending email notifications to issue owner by default

Project Member Reported by tikuta@chromium.org, Nov 20

Issue description

When I created CL in https://chromium-review.googlesource.com/c/infra/infra/+/1341647 ,
Tricium commented to my CL. But the comment was not sent as mail.

Why not make them sending mail to CL owner?
 
Blockedon: 890545
Labels: -Type-Bug -Pri-2 Pri-3 Type-Feature
Status: Available (was: Untriaged)
Summary: Consider setting "notify" to OWNER or OWNER_REVIEWERS for Tricium comments (was: comment from tricium should be sent to as mail)
Good question.

Not sending emails was actually an explicit decision before: We decided to not send emails ever in order to create less noise for reviewers (relevant place in the code: https://cs.chromium.org/chromium/infra/go/src/infra/tricium/appengine/gerrit/gerrit.go?l=146)

The other options were to send to only owner (OWNER) or owner and reviewers (OWNER_REVIEWERS), or everyone (ALL).

Right now, I still feel like Tricium is often too noisy to notify on all comments, although I think we could reconsider after bug 890545 is resolved? What do you think?
For now, I didn't see useless Tricium comment.

So if you don't have many 'Not useful' report, I think it is better to notify to owner.
Sending Tricium comment to reviewer may still be noisy.

If this is not notified, I easily overlook Tricium comments.

Summary: Consider sending email notifications to issue owner by default. (was: Consider setting "notify" to OWNER or OWNER_REVIEWERS for Tricium comments)
+1 to this feature request. It would be useful for the issue owner to get email notifications because it is currently easy to overlook Tricium comments.

Better yet would be to make this configurable. Maybe a send email checkbox in the tricium plugin?
Thanks for feedback - I think I'm a little afraid of always sending emails by default, since this might be noisy for some people; also, it's possible to change email settings in Gerrit to get emails for comments on your CL. Although it's a good point that comments currently may be overlooked.
> it's possible to change email settings in Gerrit to get emails for comments on your CL

Which setting sends emails from tricium?
I have email notifications set to "Only comments left for others" and did not see emails. I also tried "Every comment" and did not see tricium emails.
Oh, in that case it doesn't work how I assumed it would, so this should definitely be revisited. One option would be to set it to send email to owners and reviewers, and then reconsider if people complain -- although I'm still feeling hesitant about this, since it could be very annoying in the case of false positives, especially on a CL with many patchsets.
> Oh, in that case it doesn't work how I assumed it would, so this should definitely be revisited. One option would be to set it to send email to owners and reviewers, and then reconsider if people complain -- although I'm still feeling hesitant about this, since it could be very annoying in the case of false positives, especially on a CL with many patchsets.


Sure. I see this being much more useful after the other minimize noise feature requests:
* Ability to mute specific comments on subsequent patchsets.
* Ability to turn off tricium as a whole at any time (checkbox in plugin is the most user friendly way, keyword in description works but is not obvious and involves more effort)

Summary: Sending email notifications to issue owner by default (was: Consider sending email notifications to issue owner by default.)
Agreed. Note, there was related discussion in bug 890545 and bug 891090.

Sign in to add a comment