New issue
Advanced search Search tips

Issue 906954 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Better isolate flags that are copied to ash process

Project Member Reported by sky@chromium.org, Nov 20

Issue description

Currently we copy *all* flags to ash when it's started. Instead we should better define the set of flags it needs and white list those.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a4b161705cb3fb4cb55e521bb650dd109db4b01

commit 3a4b161705cb3fb4cb55e521bb650dd109db4b01
Author: Scott Violet <sky@chromium.org>
Date: Wed Nov 21 19:35:08 2018

chromeos: copy command line switches to ash services

Ash related services, such as shortcut-viewer, create various objects that
read command line flags (such as ui::Compositor). This makes such services
copy the command line flags from chrome. Long term we shold move to a whitelist,
but shorterm not copying all flags is causing display problems for some devices.

BUG=906954, 905569 
TEST=none

Change-Id: I408798f0c0a6145b84a926f464a6d76b3a116bb9
Reviewed-on: https://chromium-review.googlesource.com/c/1346690
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610164}
[modify] https://crrev.com/3a4b161705cb3fb4cb55e521bb650dd109db4b01/chrome/browser/chrome_content_browser_client.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cae4359a1f63ce5b401fc2ef42835ce642bd4b16

commit cae4359a1f63ce5b401fc2ef42835ce642bd4b16
Author: Scott Violet <sky@chromium.org>
Date: Tue Nov 27 16:47:30 2018

chromeos: don't always copy switches for service processes

BUG=906954
TEST=none

Change-Id: I2c6435f440b1e88b9a92ccbe03140063af0f70ce
Reviewed-on: https://chromium-review.googlesource.com/c/1351573
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611145}
[modify] https://crrev.com/cae4359a1f63ce5b401fc2ef42835ce642bd4b16/chrome/browser/chrome_content_browser_client.cc

Sign in to add a comment