New issue
Advanced search Search tips

Issue 906919 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task

Blocking:
issue 860355



Sign in to add a comment

Closure compile metadata_cache_item_unittest

Project Member Reported by slangley@chromium.org, Nov 20

Issue description

Remove html
Closure compile the unit test & fix errors.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab20193ee40d492d9fc4e9974a099830dcf6fe28

commit ab20193ee40d492d9fc4e9974a099830dcf6fe28
Author: Stuart Langley <slangley@google.com>
Date: Tue Nov 20 05:22:55 2018

Closure compile metadata_cache_item_unittest.

Convert metadata_cache_item_unittest.js to be closure compiled.

- Remove html file that is not auto generated.
- Fix closure errors in the unittest file.

As MetadataCacheItem requires a MetadataItem to be a parameter most of the unit
test code needed to be re-written to use this type.

No change in behaviour.

Bug:  906919 
Change-Id: Id903f8bec90abfa5256acb45d5eb3c3640d31acb
Reviewed-on: https://chromium-review.googlesource.com/c/1343413
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609603}
[modify] https://crrev.com/ab20193ee40d492d9fc4e9974a099830dcf6fe28/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/ab20193ee40d492d9fc4e9974a099830dcf6fe28/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn
[delete] https://crrev.com/3681121fd387b017483102bfc3b17b8547bdd6fc/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.html
[modify] https://crrev.com/ab20193ee40d492d9fc4e9974a099830dcf6fe28/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment