New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 906912 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: Evaluate in Console

Project Member Reported by l...@chromium.org, Nov 20

Issue description

- Text could be clearer: "Evaluate selection in Console"
- We should not show the context menu option if there is no text selected
 
Status: Assigned (was: Untriaged)
Since there's "Add selected text to watches", we could match it with "Evaluate selected text in console"

Screenshot:
https://imgur.com/a/dcUdpx2
Cc: julialiang@chromium.org einbinder@chromium.org
einbinder@, julia@, does this look good to you?

Patch
https://chromium-review.googlesource.com/c/chromium/src/+/1344583
This seems good to me
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b626f27d4fe003ae545503b0796b8bad814f35c

commit 0b626f27d4fe003ae545503b0796b8bad814f35c
Author: Erik Luo <luoe@chromium.org>
Date: Sat Dec 08 04:12:41 2018

DevTools: update text for evaluating selection in Console

Context menu option was "Evaluate in Console"
now "Evaluate selected text in Console"

Screenshot: https://imgur.com/a/dcUdpx2

Bug:  906912 
Change-Id: I8f4133028a50a065604acdd341116a3e83d637ce
Reviewed-on: https://chromium-review.googlesource.com/c/1344583
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614942}
[modify] https://crrev.com/0b626f27d4fe003ae545503b0796b8bad814f35c/third_party/blink/renderer/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/0b626f27d4fe003ae545503b0796b8bad814f35c/third_party/blink/renderer/devtools/front_end/sources/module.json

Status: Fixed (was: Assigned)

Sign in to add a comment