DevTools: Evaluate in Console |
|||
Issue description- Text could be clearer: "Evaluate selection in Console" - We should not show the context menu option if there is no text selected
,
Nov 20
einbinder@, julia@, does this look good to you? Patch https://chromium-review.googlesource.com/c/chromium/src/+/1344583
,
Dec 7
This seems good to me
,
Dec 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b626f27d4fe003ae545503b0796b8bad814f35c commit 0b626f27d4fe003ae545503b0796b8bad814f35c Author: Erik Luo <luoe@chromium.org> Date: Sat Dec 08 04:12:41 2018 DevTools: update text for evaluating selection in Console Context menu option was "Evaluate in Console" now "Evaluate selected text in Console" Screenshot: https://imgur.com/a/dcUdpx2 Bug: 906912 Change-Id: I8f4133028a50a065604acdd341116a3e83d637ce Reviewed-on: https://chromium-review.googlesource.com/c/1344583 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#614942} [modify] https://crrev.com/0b626f27d4fe003ae545503b0796b8bad814f35c/third_party/blink/renderer/devtools/front_end/sources/SourcesPanel.js [modify] https://crrev.com/0b626f27d4fe003ae545503b0796b8bad814f35c/third_party/blink/renderer/devtools/front_end/sources/module.json
,
Dec 10
|
|||
►
Sign in to add a comment |
|||
Comment 1 by l...@chromium.org
, Nov 20