New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 906903: Create a single source of time for offline_pages native code

Reported by carlosk@chromium.org, Nov 20 Project Member

Issue description

Let's simplify the offline pages codebase by having a single, shared way of accessing the current time and allow overriding it from tests using these static methods from offline_clock.h [1]:

 base::Clock* OfflineClock();
 void SetOfflineClockForTesting(base::Clock* clock);

Notes: There's an incoming change that will make the proper setting and un-setting of the test clock easier and safer.

These imperfect CS queries may help finding all offline pages related files that might need updating because they either already access a base::Clock instance or call Time::Now():
* https://cs.chromium.org/search/?q=%5Cb(Time::Now%7Cclock%5B_%5D?(%5C.%7C-%3E)Now)%5Cb+case:yes+file:%5Esrc/chrome/browser/offline_pages/&type=cs
* https://cs.chromium.org/search/?q=%5Cb(Time::Now%7Cclock%5B_%5D?(%5C.%7C-%3E)Now)%5Cb+case:yes+file:%5Esrc/components/offline_pages/&type=cs


[1] https://cs.chromium.org/chromium/src/components/offline_pages/core/offline_clock.h
 

Comment 1 by carlosk@chromium.org, Nov 20

Cc: dim...@chromium.org harringtond@chromium.org dewittj@chromium.org
There's currently 12 out of 47 (~25%) subclasses of offline_pages::Task that do use the current time in their code. As these are all short lived tasks I feel like adding a clock pointer to task instances is not too much of a problem?

Comment 2 by petewil@google.com, Nov 26

Status: Assigned (was: Untriaged)
Is this already fixed?

Comment 3 by carlosk@chromium.org, Nov 26

Status: Started (was: Assigned)
No, being worked on.

Comment 4 by carlosk@chromium.org, Nov 26

I'm about to land a CL that creates the abstraction (outside of the base Task class) and changes all Prefetching tasks to use it.

PrefetchDownloaderQuota should also be updated to not require a Clock instance anymore on creation and use the new abstraction instead.

Comment 5 by bugdroid1@chromium.org, Nov 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/488774790189bb90a6ec38f4d285a6b3a575f6ad

commit 488774790189bb90a6ec38f4d285a6b3a575f6ad
Author: Carlos Knippschild <carlosk@chromium.org>
Date: Tue Nov 27 03:18:00 2018

Consolidate Prefetching tasks time sources to using base::Clock

This change adds a base::Clock pointer to the base TaskQueue tasks and
updates all time related calls in tasks and tests in:

components/offline_pages/core/prefetch/tasks/

Bug:  906903 
Change-Id: Ia701af7d49dcd5376c903598e61f490721149df2
Reviewed-on: https://chromium-review.googlesource.com/c/1344829
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Dan H <harringtond@google.com>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611010}
[modify] https://crrev.com/488774790189bb90a6ec38f4d285a6b3a575f6ad/components/offline_pages/core/BUILD.gn
[add] https://crrev.com/488774790189bb90a6ec38f4d285a6b3a575f6ad/components/offline_pages/core/offline_clock.cc
[add] https://crrev.com/488774790189bb90a6ec38f4d285a6b3a575f6ad/components/offline_pages/core/offline_clock.h
[modify] https://crrev.com/488774790189bb90a6ec38f4d285a6b3a575f6ad/components/offline_pages/core/prefetch/tasks/add_unique_urls_task.cc
[modify] https://crrev.com/488774790189bb90a6ec38f4d285a6b3a575f6ad/components/offline_pages/core/prefetch/tasks/download_archives_task.cc
[modify] https://crrev.com/488774790189bb90a6ec38f4d285a6b3a575f6ad/components/offline_pages/core/prefetch/tasks/generate_page_bundle_task.cc
[modify] https://crrev.com/488774790189bb90a6ec38f4d285a6b3a575f6ad/components/offline_pages/core/prefetch/tasks/generate_page_bundle_task.h
[modify] https://crrev.com/488774790189bb90a6ec38f4d285a6b3a575f6ad/components/offline_pages/core/prefetch/tasks/generate_page_bundle_task_unittest.cc
[modify] https://crrev.com/488774790189bb90a6ec38f4d285a6b3a575f6ad/components/offline_pages/core/prefetch/tasks/mark_operation_done_task.cc
[modify] https://crrev.com/488774790189bb90a6ec38f4d285a6b3a575f6ad/components/offline_pages/core/prefetch/tasks/metrics_finalization_task.cc
[modify] https://crrev.com/488774790189bb90a6ec38f4d285a6b3a575f6ad/components/offline_pages/core/prefetch/tasks/stale_entry_finalizer_task.cc
[modify] https://crrev.com/488774790189bb90a6ec38f4d285a6b3a575f6ad/components/offline_pages/core/prefetch/tasks/stale_entry_finalizer_task.h
[modify] https://crrev.com/488774790189bb90a6ec38f4d285a6b3a575f6ad/components/offline_pages/core/prefetch/tasks/stale_entry_finalizer_task_unittest.cc

Comment 6 by carlosk@chromium.org, Nov 27

I sadly landed the CL in #5 with an outdated commit description. It should have been:

> Consolidate Prefetching tasks time sources to using base::Clock
> 
> This change adds a shared base::Clock pointer accessible via a static 
> function, making it widely accessible (instead of limiting it to 
> offline_pages::Task instances). The pointer can be overridden by tests.
> 
> It also updates all time related calls in Task subclasses and their
> tests in:
>
> components/offline_pages/core/prefetch/tasks/

Comment 7 by carlosk@chromium.org, Nov 27

Cc: carlosk@chromium.org
Owner: mtlieuu@chromium.org
mtlieuu@ will be taking over this work.

Comment 8 by carl...@google.com, Nov 28

Summary: Create a single source of time for offline_pages native code (was: Create a single source of time for TaskQueue tasks)

Comment 9 by carl...@google.com, Nov 28

Description: Show this description

Comment 10 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5eeb88b907196d6bdf1c6b8baa2c8498f57bc0d7

commit 5eeb88b907196d6bdf1c6b8baa2c8498f57bc0d7
Author: Dan Harrington <harringtond@chromium.org>
Date: Thu Nov 29 00:52:57 2018

Add TestScopedOfflineClock

Setting the offline clock pointer is error-prone, as a test must ensure it
resets the pointer back to null, or a later test will fail. TestScopedOfflineClock
overrides the clock in a more safe way.

Bug:  906903 
Change-Id: Idd88c35da90bddcb3b7006c7b33547c5b36b02d2
Reviewed-on: https://chromium-review.googlesource.com/c/1351748
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611970}
[modify] https://crrev.com/5eeb88b907196d6bdf1c6b8baa2c8498f57bc0d7/components/offline_pages/core/BUILD.gn
[modify] https://crrev.com/5eeb88b907196d6bdf1c6b8baa2c8498f57bc0d7/components/offline_pages/core/offline_clock.cc
[modify] https://crrev.com/5eeb88b907196d6bdf1c6b8baa2c8498f57bc0d7/components/offline_pages/core/offline_clock.h
[modify] https://crrev.com/5eeb88b907196d6bdf1c6b8baa2c8498f57bc0d7/components/offline_pages/core/prefetch/tasks/generate_page_bundle_task_unittest.cc
[modify] https://crrev.com/5eeb88b907196d6bdf1c6b8baa2c8498f57bc0d7/components/offline_pages/core/prefetch/tasks/stale_entry_finalizer_task_unittest.cc
[add] https://crrev.com/5eeb88b907196d6bdf1c6b8baa2c8498f57bc0d7/components/offline_pages/core/test_scoped_offline_clock.cc
[add] https://crrev.com/5eeb88b907196d6bdf1c6b8baa2c8498f57bc0d7/components/offline_pages/core/test_scoped_offline_clock.h

Comment 11 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c01bcd346d165088628da2a25c8b50063b2aa90

commit 0c01bcd346d165088628da2a25c8b50063b2aa90
Author: Mark <mtlieuu@chromium.org>
Date: Thu Nov 29 18:54:50 2018

Consolidate clock sources to OfflineClock()

This change further changes direct calls to Time::Now or the default
base::Clock instance to an OfflineClock module for ease of testing
within production files and their related tests in:

components/offline_pages/core/background/

Bug:  906903 
Change-Id: Iee19708b9297e3e3b3944c457b163d5555914948
Reviewed-on: https://chromium-review.googlesource.com/c/1352045
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Mark Lieu <mtlieuu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612293}
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/add_request_task_unittest.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/change_requests_state_task_unittest.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/cleanup_task_unittest.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/get_requests_task_unittest.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/mark_attempt_aborted_task_unittest.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/mark_attempt_completed_task_unittest.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/mark_attempt_deferred_task.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/mark_attempt_started_task.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/mark_attempt_started_task_unittest.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/offliner_policy_utils.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/pick_request_task.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/pick_request_task_unittest.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/reconcile_task_unittest.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/remove_requests_task_unittest.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/request_coordinator_unittest.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/request_queue_store_unittest.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/request_queue_unittest.cc
[modify] https://crrev.com/0c01bcd346d165088628da2a25c8b50063b2aa90/components/offline_pages/core/background/save_page_request_unittest.cc

Comment 12 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5a7fc775da7b0a10395e1595dafc5ffd03d850e

commit f5a7fc775da7b0a10395e1595dafc5ffd03d850e
Author: Mark Lieu <mtlieuu@chromium.org>
Date: Thu Dec 06 20:21:32 2018

Consolidate calls to clock sources to OfflineClock #2

This change further changes direct calls to Time::Now or the default
base::Clock instance to an OfflineClock module within classes which
need a Clock pointer to be passed into the class. This eliminates the
need for testing-only functions and further allows ease of testing.

chrome/browser/offline_pages

Bug:  906903 
Change-Id: I99d5c7e518465035ff8317f17be68ed776603f8d
Reviewed-on: https://chromium-review.googlesource.com/c/1357551
Commit-Queue: Mark Lieu <mtlieuu@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614473}
[modify] https://crrev.com/f5a7fc775da7b0a10395e1595dafc5ffd03d850e/chrome/browser/offline_pages/offline_page_request_handler.cc
[modify] https://crrev.com/f5a7fc775da7b0a10395e1595dafc5ffd03d850e/chrome/browser/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/f5a7fc775da7b0a10395e1595dafc5ffd03d850e/chrome/browser/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/f5a7fc775da7b0a10395e1595dafc5ffd03d850e/chrome/browser/offline_pages/prefetch/offline_metrics_collector_impl.cc
[modify] https://crrev.com/f5a7fc775da7b0a10395e1595dafc5ffd03d850e/chrome/browser/offline_pages/prefetch/offline_metrics_collector_impl.h
[modify] https://crrev.com/f5a7fc775da7b0a10395e1595dafc5ffd03d850e/chrome/browser/offline_pages/prefetch/offline_metrics_collector_impl_unittest.cc
[modify] https://crrev.com/f5a7fc775da7b0a10395e1595dafc5ffd03d850e/chrome/browser/offline_pages/prefetch/prefetch_background_task_handler_impl.cc
[modify] https://crrev.com/f5a7fc775da7b0a10395e1595dafc5ffd03d850e/chrome/browser/offline_pages/prefetch/prefetch_background_task_handler_impl.h
[modify] https://crrev.com/f5a7fc775da7b0a10395e1595dafc5ffd03d850e/chrome/browser/offline_pages/prefetch/prefetch_background_task_handler_impl_unittest.cc

Comment 13 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/297ccb8018a6c2da5df6cd4e860e6cfc4b395e40

commit 297ccb8018a6c2da5df6cd4e860e6cfc4b395e40
Author: Mark <mtlieuu@chromium.org>
Date: Fri Dec 07 01:21:54 2018

Consolidate calls to clock sources to OfflineClock #3

This change further changes direct calls to Time::Now or the default
base::Clock instance to an OfflineClock module within classes which
need a Clock pointer to be passed into the class. This eliminates the
need for testing-only functions and further allows ease of testing.
This change is specific to production files and their related tests in:

components/offline_pages/core/

Bug:  906903 
Change-Id: I579d9b8e9c785e0c004ecc3d25e05f7aa031fe4c
Reviewed-on: https://chromium-review.googlesource.com/c/1359487
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Mark Lieu <mtlieuu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614549}
[modify] https://crrev.com/297ccb8018a6c2da5df6cd4e860e6cfc4b395e40/components/offline_pages/core/offline_event_logger.cc
[modify] https://crrev.com/297ccb8018a6c2da5df6cd4e860e6cfc4b395e40/components/offline_pages/core/offline_page_metadata_store.cc
[modify] https://crrev.com/297ccb8018a6c2da5df6cd4e860e6cfc4b395e40/components/offline_pages/core/offline_page_metadata_store_unittest.cc
[modify] https://crrev.com/297ccb8018a6c2da5df6cd4e860e6cfc4b395e40/components/offline_pages/core/prefetch/prefetch_downloader_impl.cc
[modify] https://crrev.com/297ccb8018a6c2da5df6cd4e860e6cfc4b395e40/components/offline_pages/core/prefetch/prefetch_downloader_impl.h
[modify] https://crrev.com/297ccb8018a6c2da5df6cd4e860e6cfc4b395e40/components/offline_pages/core/prefetch/prefetch_downloader_impl_unittest.cc

Comment 14 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/516c91431f0db6d01244d7ea0c3062682ecd3af8

commit 516c91431f0db6d01244d7ea0c3062682ecd3af8
Author: Mark Lieu <mtlieuu@chromium.org>
Date: Fri Dec 07 20:06:28 2018

Consolidate calls to clock sources to OfflineClock #1

This change further changes direct calls to Time::Now or the default
base::Clock instance to an OfflineClock module within classes which
need a Clock pointer to be passed into the class. This eliminates the
need for testing-only functions and further allows ease of testing.
This change is specific to production files and their related tests in:

chrome/browser/android/explore_sites/
components/offline_pages/core/model/

Bug:  906903 
Change-Id: I02b84f65b77dc395310995c34ded41d92721aaeb
Reviewed-on: https://chromium-review.googlesource.com/c/1352813
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Dan H <harringtond@google.com>
Commit-Queue: Mark Lieu <mtlieuu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614797}
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/chrome/browser/android/explore_sites/blacklist_site_task.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/chrome/browser/android/explore_sites/explore_sites_store.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/chrome/browser/android/explore_sites/history_statistics_reporter_unittest.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/chrome/browser/offline_pages/android/offline_page_model_factory.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/chrome/browser/offline_pages/offline_page_request_handler_unittest.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/chrome/browser/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/chrome/browser/offline_pages/test_offline_page_model_builder.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/components/offline_pages/core/model/clear_storage_task_unittest.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/components/offline_pages/core/model/delete_page_task.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/components/offline_pages/core/model/delete_page_task_unittest.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/components/offline_pages/core/model/get_pages_task_unittest.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/components/offline_pages/core/model/mark_page_accessed_task_unittest.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/components/offline_pages/core/model/offline_page_model_taskified.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/components/offline_pages/core/model/offline_page_model_taskified.h
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/components/offline_pages/core/model/offline_page_model_taskified_unittest.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/components/offline_pages/core/offline_clock.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/components/offline_pages/core/offline_clock.h
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/components/offline_pages/core/test_scoped_offline_clock.cc
[modify] https://crrev.com/516c91431f0db6d01244d7ea0c3062682ecd3af8/components/offline_pages/core/test_scoped_offline_clock.h

Comment 15 by mtlieuu@chromium.org, Dec 7

Status: Available (was: Started)
Uses of testing-only parameters have been replaced with instances of |OfflineClock|. 

There are currently multiple calls to OfflineClock()->Now() within the offline_pages domain, however there is a new function, OfflineTimeNow(), which is a shortcut for OfflineClock()->Now() and will also allow us to remove the clock.h include from the files which OfflineClock is used in. Future work is needed to replace these calls with the new function.

Will be moving onto new work, so I will leave this issue incomplete and available.

Comment 16 by harringtond@google.com, Dec 11

Owner: harringtond@google.com
Status: Assigned (was: Available)

Comment 18 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/557c67518fd61a68197af390a93599eee6d914e1

commit 557c67518fd61a68197af390a93599eee6d914e1
Author: Dan Harrington <harringtond@chromium.org>
Date: Thu Dec 13 18:56:48 2018

Replace OfflineClock()->Now() with OfflineTimeNow()

This change is for consistency, and simplicity: most code doesn't need to access
OfflineClock() for more than the current time.

Bug:  906903 
Change-Id: I34597e40c8e3a0d450867beb19ce602b8afd7d72
Reviewed-on: https://chromium-review.googlesource.com/c/1372270
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#616377}
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/chrome/browser/android/explore_sites/blacklist_site_task.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/chrome/browser/android/explore_sites/explore_sites_store.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/chrome/browser/android/explore_sites/history_statistics_reporter_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/chrome/browser/offline_pages/offline_page_mhtml_archiver.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/chrome/browser/offline_pages/offline_page_mhtml_archiver_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/chrome/browser/offline_pages/offline_page_request_handler.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/chrome/browser/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/chrome/browser/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/chrome/browser/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/chrome/browser/offline_pages/prefetch/offline_metrics_collector_impl.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/chrome/browser/offline_pages/prefetch/offline_metrics_collector_impl_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/chrome/browser/offline_pages/prefetch/prefetch_background_task_handler_impl.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/chrome/browser/offline_pages/prefetch/prefetch_background_task_handler_impl_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/add_request_task_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/change_requests_state_task_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/cleanup_task_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/get_requests_task_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/mark_attempt_aborted_task_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/mark_attempt_completed_task_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/mark_attempt_deferred_task.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/mark_attempt_started_task.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/mark_attempt_started_task_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/offliner_policy_utils.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/pick_request_task.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/pick_request_task_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/reconcile_task_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/remove_requests_task_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/request_coordinator_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/request_queue_store_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/request_queue_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/background/save_page_request_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/model/clear_storage_task_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/model/delete_page_task.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/model/delete_page_task_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/model/mark_page_accessed_task_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/model/offline_page_model_taskified.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/model/offline_page_model_taskified.h
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/offline_event_logger.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/offline_page_metadata_store_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/prefetch/prefetch_downloader_impl.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/prefetch/prefetch_downloader_impl.h
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/prefetch/prefetch_downloader_impl_unittest.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/prefetch/tasks/add_unique_urls_task.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/prefetch/tasks/download_archives_task.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/prefetch/tasks/generate_page_bundle_task.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/prefetch/tasks/mark_operation_done_task.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/prefetch/tasks/metrics_finalization_task.cc
[modify] https://crrev.com/557c67518fd61a68197af390a93599eee6d914e1/components/offline_pages/core/prefetch/tasks/stale_entry_finalizer_task.cc

Comment 19 by harringtond@google.com, Feb 8

Status: Fixed (was: Assigned)

Sign in to add a comment