New issue
Advanced search Search tips

Issue 906902 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 27
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Cannot open hosted documents through the open dialog in ChromeOS with DriveFS enabled.

Project Member Reported by rmcelrath@chromium.org, Nov 20

Issue description

Chrome Version: 72.0.3611.0
OS: ChromeOS

What steps will reproduce the problem?
(1) Open a new tab
(2) Press ctrl+O
(3) Select "My Drive" on the left
(4) Select a .gdoc, .gsheet, or .gslides document

What is the expected result?
The file should open in a docs.google.com tab.

What happens instead?
Chrome tries to load the file as file:///media/fuse/drivefs-.... and gets a 404.
 
Labels: -Pri-3 CrOSFilesFeature-DriveSync Target-72 Treadstone OS-Chrome Pri-2
Owner: sa...@chromium.org
Status: Assigned (was: Untriaged)
Labels: Files-Fixit-2018
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de54dcb37e43fc511cf498f19e097efa07382616

commit de54dcb37e43fc511cf498f19e097efa07382616
Author: Sam McNally <sammc@chromium.org>
Date: Tue Nov 27 11:49:45 2018

Add special-casing for hosted docs in DriveFS for browser open dialogs.

Hosted docs need to be redirected to their URLs to open successfully.
Hosted docs opened from the files app apply this transformation, but
files selected via the open dialog do not. Add this special-casing for
open dialog opens as well.

Bug:  906902 
No-try: true
Change-Id: Ie64a6d25c97a3954cfa6d7e2694f29e191777257
Reviewed-on: https://chromium-review.googlesource.com/c/1343473
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611070}
[modify] https://crrev.com/de54dcb37e43fc511cf498f19e097efa07382616/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/de54dcb37e43fc511cf498f19e097efa07382616/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/de54dcb37e43fc511cf498f19e097efa07382616/chrome/browser/chromeos/fileapi/external_file_url_util.cc
[modify] https://crrev.com/de54dcb37e43fc511cf498f19e097efa07382616/chrome/browser/chromeos/fileapi/external_file_url_util.h
[modify] https://crrev.com/de54dcb37e43fc511cf498f19e097efa07382616/chrome/browser/ui/browser.cc
[modify] https://crrev.com/de54dcb37e43fc511cf498f19e097efa07382616/ui/file_manager/integration_tests/file_manager/background.js
[modify] https://crrev.com/de54dcb37e43fc511cf498f19e097efa07382616/ui/file_manager/integration_tests/file_manager/file_dialog.js

Status: Fixed (was: Assigned)

Sign in to add a comment