New issue
Advanced search Search tips

Issue 906896 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile thumbnail_model_unittest

Project Member Reported by slangley@chromium.org, Nov 20

Issue description

Remove html
Fix closure errors.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c864ba332de649f59c74ad7af3b4f8e148c4282

commit 4c864ba332de649f59c74ad7af3b4f8e148c4282
Author: Stuart Langley <slangley@google.com>
Date: Tue Nov 20 02:31:12 2018

Closure compile thumbnail_model_unittest.js

- Remove the .html file
- Add BUILD target for thumbnail_model_unittest.js
- Fix closure errors in the unittest.js files.

No change in behaviour.

Bug:  906896 
Change-Id: I12d83ee0f3192565d6248d8f862c9c9e1a199f00
Reviewed-on: https://chromium-review.googlesource.com/c/1343578
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609569}
[modify] https://crrev.com/4c864ba332de649f59c74ad7af3b4f8e148c4282/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/4c864ba332de649f59c74ad7af3b4f8e148c4282/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn
[delete] https://crrev.com/9d11eb1d67bb9c44e7a2c4785ca3c00c70927f07/ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model_unittest.html
[modify] https://crrev.com/4c864ba332de649f59c74ad7af3b4f8e148c4282/ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment