New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 906890 link

Starred by 5 users
Status: Verified
Owner:
xiy...@chromium.org
Closed: Nov 27
Cc:
ginko@chromium.org
█ roc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 902558



Sign in to add a comment

User cannot search for the query of their choice, it must appear in list of pre-prescribed queries

Project Member Reported by ginko@chromium.org, Nov 20 
Chrome Version: 72.0.3612.0
OS: CrOS

What steps will reproduce the problem?
(1) Type a query into the search box that is not suggested
(2) Attempt to hit enter

What is the expected result?
Query is executed as typed

What happens instead?
Query is either auto-corrected to a suggestion, or it does not search at all


REGRESSION, video includes feature working in M70!

Feature works in M71, too.

Comment 2 by ginko@chromium.org, Nov 20 

This seems like it is definitely a P0, if someone feels differently please let me know the difference between this and a P0 for future reference!

Comment 3 by ginko@chromium.org, Nov 20

Blocking: 902558

Comment 4 by ginko@chromium.org, Nov 20

Cc: xiy...@chromium.org
adding Xiyuan, though he is OOO

Comment 5 by newcomer@chromium.org, Nov 20

Labels: -M72 M-72
Lets find out where this regressed. Ginko are you looking into this?

Comment 7 by josa...@google.com, Nov 20

Labels: -Pri-0 ReleaseBlock-Dev Pri-1
marking as RBD to make sure it gets fixed before next release

Comment 8 by ginko@chromium.org, Nov 20

Owner: rockot@google.com
Looks like this was caused by https://chromium-review.googlesource.com/c/chromium/src/+/1269622

Assigning  to the original lander of this CL in case an easy fix is available

Comment 9 by xiy...@chromium.org, Nov 26

Cc: -xiy...@chromium.org roc...@chromium.org
Owner: xiy...@chromium.org
Status: Assigned (was: Untriaged)
It is because answer card uses the same comparable id of the default search omnibox result. It is intentional from CL https://chromium-review.googlesource.com/c/chromium/src/+/571954/ so that answer card result replaces the omnibox result when it is avaible.

However, with the content service CL, we always create an answer card result before we actually load it. As a result, the omnibox search result gets eclipsed. And when there is no answer card, we show an empty search result list.
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fe59ca46faedccbe092b6a699160c556e64bbdc

commit 6fe59ca46faedccbe092b6a699160c556e64bbdc
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Tue Nov 27 22:49:56 2018

app_list: Fix the missing default search result

- Add a equivalent_result_id field to search result;
- OmniboxResult uses stripped search url as its id;
- AnswerCardResult sets equivalent_result_id to a stripped search
  url that is used by search-what-user-typed omnibox result;
- SearchAnswerCardView use the equivalent_result_id to delete
  relevant result when the card is loaded;
- Remove the unused comparable_id from ChromeSearchResult;

Bug:  906890 
Test: SearchResultAnswerCardViewTest.RemoveEquivalent
Change-Id: I16529724c8a86790ed1b5366095e2701118f9231
Reviewed-on: https://chromium-review.googlesource.com/c/1351714
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611390}
[modify] https://crrev.com/6fe59ca46faedccbe092b6a699160c556e64bbdc/ash/app_list/model/search/search_model.cc
[modify] https://crrev.com/6fe59ca46faedccbe092b6a699160c556e64bbdc/ash/app_list/model/search/search_model.h
[modify] https://crrev.com/6fe59ca46faedccbe092b6a699160c556e64bbdc/ash/app_list/model/search/search_result.h
[modify] https://crrev.com/6fe59ca46faedccbe092b6a699160c556e64bbdc/ash/app_list/views/search_result_answer_card_view.cc
[modify] https://crrev.com/6fe59ca46faedccbe092b6a699160c556e64bbdc/ash/app_list/views/search_result_answer_card_view_unittest.cc
[modify] https://crrev.com/6fe59ca46faedccbe092b6a699160c556e64bbdc/ash/public/interfaces/app_list.mojom
[modify] https://crrev.com/6fe59ca46faedccbe092b6a699160c556e64bbdc/chrome/browser/ui/app_list/search/answer_card/answer_card_result.cc
[modify] https://crrev.com/6fe59ca46faedccbe092b6a699160c556e64bbdc/chrome/browser/ui/app_list/search/answer_card/answer_card_result.h
[modify] https://crrev.com/6fe59ca46faedccbe092b6a699160c556e64bbdc/chrome/browser/ui/app_list/search/answer_card/answer_card_result_unittest.cc
[modify] https://crrev.com/6fe59ca46faedccbe092b6a699160c556e64bbdc/chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider_unittest.cc
[modify] https://crrev.com/6fe59ca46faedccbe092b6a699160c556e64bbdc/chrome/browser/ui/app_list/search/chrome_search_result.cc
[modify] https://crrev.com/6fe59ca46faedccbe092b6a699160c556e64bbdc/chrome/browser/ui/app_list/search/chrome_search_result.h
[modify] https://crrev.com/6fe59ca46faedccbe092b6a699160c556e64bbdc/chrome/browser/ui/app_list/search/mixer.cc
[modify] https://crrev.com/6fe59ca46faedccbe092b6a699160c556e64bbdc/chrome/browser/ui/app_list/search/omnibox_result.cc

Comment 12 by xiy...@chromium.org, Nov 27

Status: Fixed (was: Started)
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 28

Labels: merge-merged-3623
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f245560432d80b17f130e5d8a73732b080926bf2

commit f245560432d80b17f130e5d8a73732b080926bf2
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Wed Nov 28 02:49:51 2018

app_list: Fix the missing default search result

- Add a equivalent_result_id field to search result;
- OmniboxResult uses stripped search url as its id;
- AnswerCardResult sets equivalent_result_id to a stripped search
  url that is used by search-what-user-typed omnibox result;
- SearchAnswerCardView use the equivalent_result_id to delete
  relevant result when the card is loaded;
- Remove the unused comparable_id from ChromeSearchResult;

Bug:  906890 
Test: SearchResultAnswerCardViewTest.RemoveEquivalent
Change-Id: I16529724c8a86790ed1b5366095e2701118f9231
Reviewed-on: https://chromium-review.googlesource.com/c/1351714
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#611390}(cherry picked from commit 6fe59ca46faedccbe092b6a699160c556e64bbdc)
Reviewed-on: https://chromium-review.googlesource.com/c/1352857
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3623@{#6}
Cr-Branched-From: 2cf14c734153d203ada718fe486cc85e575dc6a9-refs/heads/master@{#611016}
[modify] https://crrev.com/f245560432d80b17f130e5d8a73732b080926bf2/ash/app_list/model/search/search_model.cc
[modify] https://crrev.com/f245560432d80b17f130e5d8a73732b080926bf2/ash/app_list/model/search/search_model.h
[modify] https://crrev.com/f245560432d80b17f130e5d8a73732b080926bf2/ash/app_list/model/search/search_result.h
[modify] https://crrev.com/f245560432d80b17f130e5d8a73732b080926bf2/ash/app_list/views/search_result_answer_card_view.cc
[modify] https://crrev.com/f245560432d80b17f130e5d8a73732b080926bf2/ash/app_list/views/search_result_answer_card_view_unittest.cc
[modify] https://crrev.com/f245560432d80b17f130e5d8a73732b080926bf2/ash/public/interfaces/app_list.mojom
[modify] https://crrev.com/f245560432d80b17f130e5d8a73732b080926bf2/chrome/browser/ui/app_list/search/answer_card/answer_card_result.cc
[modify] https://crrev.com/f245560432d80b17f130e5d8a73732b080926bf2/chrome/browser/ui/app_list/search/answer_card/answer_card_result.h
[modify] https://crrev.com/f245560432d80b17f130e5d8a73732b080926bf2/chrome/browser/ui/app_list/search/answer_card/answer_card_result_unittest.cc
[modify] https://crrev.com/f245560432d80b17f130e5d8a73732b080926bf2/chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider_unittest.cc
[modify] https://crrev.com/f245560432d80b17f130e5d8a73732b080926bf2/chrome/browser/ui/app_list/search/chrome_search_result.cc
[modify] https://crrev.com/f245560432d80b17f130e5d8a73732b080926bf2/chrome/browser/ui/app_list/search/chrome_search_result.h
[modify] https://crrev.com/f245560432d80b17f130e5d8a73732b080926bf2/chrome/browser/ui/app_list/search/mixer.cc
[modify] https://crrev.com/f245560432d80b17f130e5d8a73732b080926bf2/chrome/browser/ui/app_list/search/omnibox_result.cc

Comment 14 by newcomer@chromium.org, Nov 28 

Issue 909847 has been merged into this issue.

Comment 15 by spathangi@chromium.org, Jan 7

Status: Verified (was: Fixed)
Verified on ChromeOS 11316.66.0, 72.0.3626.49 dev-channel
►

Sign in to add a comment