New issue
Advanced search Search tips

Issue 906864 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add PrivacyMode value to NetLog

Project Member Reported by mmenke@chromium.org, Nov 19

Issue description

It affects request behavior, and cannot always be deduced from LoadFlags.
 
Components: Internals>Network
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ad78edcc2971e9b655c859588f49213004d2ca2

commit 7ad78edcc2971e9b655c859588f49213004d2ca2
Author: Matt Menke <mmenke@chromium.org>
Date: Wed Nov 21 19:22:57 2018

Add privacy_mode value to NetLog start request job event.

Also move all PrivacyMode logic up to URLRequestJob layer and rename
CanEnablePrivacyMode to ForcePrivacyMode, to mode accurately reflect
what it does.

TBR=droger@chromium.org

Bug:  906864 
Change-Id: I6527cc34579e474292491886a2fb54ba2003561e
Reviewed-on: https://chromium-review.googlesource.com/c/1343051
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610142}
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/ios/chrome/browser/net/ios_chrome_network_delegate.cc
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/ios/chrome/browser/net/ios_chrome_network_delegate.h
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/base/layered_network_delegate.cc
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/base/layered_network_delegate.h
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/base/layered_network_delegate_unittest.cc
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/base/network_delegate.cc
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/base/network_delegate.h
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/base/network_delegate_impl.cc
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/base/network_delegate_impl.h
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/log/net_log_event_type_list.h
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/url_request/url_request.cc
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/url_request/url_request.h
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/url_request/url_request_http_job.cc
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/url_request/url_request_job.cc
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/url_request/url_request_job.h
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/url_request/url_request_netlog_params.cc
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/net/url_request/url_request_netlog_params.h
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/services/network/network_context.cc
[modify] https://crrev.com/7ad78edcc2971e9b655c859588f49213004d2ca2/services/network/network_context_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment