New issue
Advanced search Search tips

Issue 906850 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 880027
issue 920050
issue 924041
issue 924043


Participants' hotlists:
Worker-OffTheMainThread


Sign in to add a comment

Refactor fetch-related worker WPT tests

Project Member Reported by hirosh...@chromium.org, Nov 19

Issue description

There are fetch- and security-feature-related WPT tests, for example:
- external/wpt/fetch/
- external/wpt/content-security-policy/
- external/wpt/mixed-content/
- external/wpt/referrer-policy/

And there are also fetch- and security-feature-related WPT tests regarding worker/worklets under
- external/wpt/workers/
- external/wpt/worklets/
- some other locations?
e.g.
- external/wpt/workers/modules/dedicated-worker-import-csp.html
- external/wpt/workers/modules/dedicated-worker-import-referrer.html
- external/wpt/worklets/*-worklet-csp.https.html
- external/wpt/worklets/*-worklet-referrer.https.html
- external/wpt/worklets/*-worklet-import.https.html
- external/wpt/xhr/open-url-redirected-worker-origin.htm
- external/wpt/xhr/open-url-redirected-sharedworker-origin.htm

We might be able to e.g.
- Remove duplicated tests,
- Merge and generate systematically/mechanically similar tests, and
- Increase test coverage.

Design doc: https://docs.google.com/document/d/17VwvO8qGPjRpaki51L06I5dnefDhztMecaJ8k8qyRwU/edit?usp=sharing
https://docs.google.com/spreadsheets/d/1DnsXL8cmQ6eM0_Uz9w1UNU8vhixFHTY-jzxosRtgMCk/edit#gid=0

 
Blocking: 880027
Might be helpful for Issue 880027 and implementing/shipping off-the-main-thread fetch in general.
Components: Blink>SecurityFeature
The tests under the following directories are already auto-generated and thus I think it's good to merge CORS/mixed-content/referrer-policy-related worker tests into the following directories:
- external/wpt/fetch/
- external/wpt/mixed-content/
- external/wpt/referrer-policy/

CSP tests (external/wpt/content-security-policy/ and external/wpt/worklets/*-worklet-csp.https.html) are manually written?
We might be able to generate the CSP tests mechanically, but it might take some time.
> CSP tests (external/wpt/content-security-policy/ and external/wpt/worklets/*-worklet-csp.https.html) are manually written?

Regarding external/wpt/worklets/*-worklet-csp.https.html, yes, they were manually written.
I'll refactor referrer-policy tests shortly,
- Fix a bug in generator and to allow RP tests to run on HTTPS page.
- Rename tests to shorten path length; Currently adding tests quite easily results in path length limit exceeded.

Blocking: 920050
Cc: -hirosh...@chromium.org
Owner: hirosh...@chromium.org
Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdd159ca09d82ff0a3005f8318469dc210047c89

commit cdd159ca09d82ff0a3005f8318469dc210047c89
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Jan 09 02:43:41 2019

[wpt/upgrade-insecure-requests] Fix generateRedirect()

|url| in generateRedirect() was string (not URL) and therefore
generateRedirect() returned the same URL (|url| as-is)
regardless of |host| or |protocol| parameters.

Bug: 906850, 878274
Change-Id: I7134726e916854a829eaf7d348776a2b7b547c70
Reviewed-on: https://chromium-review.googlesource.com/c/1389029
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621013}
[modify] https://crrev.com/cdd159ca09d82ff0a3005f8318469dc210047c89/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/support/testharness-helper.sub.js

Plan:
- Land some CLs currently under review to unblock module workers.
- Later do general cleanup, including:
  - Create wpt/common/something/ directory and move common generator script and helper JavaScript there.
  - Unify test naming conventions.

Description: Show this description
Added a design doc.
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d08d22dbdc06b9f4f96ad2a52875004d6fba548

commit 4d08d22dbdc06b9f4f96ad2a52875004d6fba548
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Jan 09 19:22:32 2019

[wpt/referrer-policy] Fix same-origin-downgrade in spec.src.json

Manual changes: spec.src.json. All others are generated.

This caused two test files with the same contents with names
- same-origin-downgrade.http.html
- same-origin-upgrade.http.html
in directories under origin-when-cross-origin/.
This CL thus removes same-origin-downgrade.http.html without
affecting test coverage.

(same-origin-downgrade is currently supressed by
source-https-unsupported-by-web-platform-tests-runners and thus
this CL doesn't add new files)

Bug: 906850
Change-Id: I1fcc150c4b2b643b3186cbef9432d343f8b4a1dd
Reviewed-on: https://chromium-review.googlesource.com/c/1389925
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621262}
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/attr-referrer/same-origin/http-https/a-tag/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/attr-referrer/same-origin/http-https/iframe-tag/keep-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/attr-referrer/same-origin/http-https/iframe-tag/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/attr-referrer/same-origin/http-https/iframe-tag/swap-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/attr-referrer/same-origin/http-https/img-tag/keep-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/attr-referrer/same-origin/http-https/img-tag/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/attr-referrer/same-origin/http-https/img-tag/swap-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/attr-referrer/same-origin/http-https/script-tag/keep-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/attr-referrer/same-origin/http-https/script-tag/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/attr-referrer/same-origin/http-https/script-tag/swap-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/a-tag/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/a-tag/no-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/fetch-request/keep-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/fetch-request/keep-origin-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/fetch-request/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/fetch-request/no-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/fetch-request/swap-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/fetch-request/swap-origin-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/iframe-tag/keep-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/iframe-tag/keep-origin-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/iframe-tag/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/iframe-tag/no-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/iframe-tag/swap-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/iframe-tag/swap-origin-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/img-tag/keep-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/img-tag/keep-origin-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/img-tag/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/img-tag/no-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/img-tag/swap-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/img-tag/swap-origin-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/script-tag/keep-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/script-tag/keep-origin-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/script-tag/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/script-tag/no-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/script-tag/swap-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/script-tag/swap-origin-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/xhr-request/keep-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/xhr-request/keep-origin-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/xhr-request/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/xhr-request/no-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/xhr-request/swap-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/xhr-request/swap-origin-redirect/same-origin-downgrade.http.html.headers
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/a-tag/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/fetch-request/keep-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/fetch-request/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/fetch-request/swap-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/iframe-tag/keep-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/iframe-tag/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/iframe-tag/swap-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/img-tag/keep-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/img-tag/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/img-tag/swap-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/script-tag/keep-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/script-tag/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/script-tag/swap-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/xhr-request/keep-origin-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/xhr-request/no-redirect/same-origin-downgrade.http.html
[delete] https://crrev.com/4cd2f0f7ef8ffceace2cf7b6206741895e67e907/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/xhr-request/swap-origin-redirect/same-origin-downgrade.http.html
[modify] https://crrev.com/4d08d22dbdc06b9f4f96ad2a52875004d6fba548/third_party/blink/web_tests/external/wpt/referrer-policy/spec.src.json
[modify] https://crrev.com/4d08d22dbdc06b9f4f96ad2a52875004d6fba548/third_party/blink/web_tests/external/wpt/referrer-policy/spec_json.js

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f347091b94fb55bd5218d3e426f119bbc8ba2d23

commit f347091b94fb55bd5218d3e426f119bbc8ba2d23
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Jan 09 19:28:08 2019

[wpt/upgrade-insecure-requests] Add worker/worklet tests

This CL adds upgrade-insecure-requests test coverage for:
- (classic and module) dedicated worker top-level scripts,
- fetch API from dedicated workers, and
- animation/audio/layout/paint worklet top-level scripts.
possibly including redirects and/or static imports,
reusing /mixed-content/generic/common.js.

For this purpose, this CL creates a generator script
that generates the newly added tests
as well as some of the existing tests
(where this CL preserves the test behavior):
- iframe-upgrade.https.html
- iframe-redirect-upgrade.https.html
- image-upgrade.https.html
- image-redirect-upgrade.https.html

This CL also removes upgrade-insecure-requests tests under
/wpt/worklets/ as they are covered by the newly added tests.

Bug: 906850, 878274, 917532, 917554
Change-Id: I1e4f60b72d2b40c795c03b9f79c542c1a250c913
Reviewed-on: https://chromium-review.googlesource.com/c/1389635
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621265}
[modify] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/TestExpectations
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/animation-worklet-import-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/animation-worklet-redirect-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/animation-worklet-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/audio-worklet-import-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/audio-worklet-redirect-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/audio-worklet-upgrade.https.html
[modify] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/iframe-redirect-upgrade.https.html
[modify] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/iframe-upgrade.https.html
[modify] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/image-redirect-upgrade.https.html
[modify] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/image-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/layout-worklet-import-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/layout-worklet-redirect-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/layout-worklet-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/module-worker-import-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/module-worker-redirect-upgrade.https-expected.txt
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/module-worker-redirect-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/module-worker-upgrade.https-expected.txt
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/module-worker-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/paint-worklet-import-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/paint-worklet-redirect-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/paint-worklet-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/support/generate.py
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/support/pass.png.headers
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/support/redirect-cors.py
[modify] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/support/testharness-helper.sub.js
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/support/worker.js
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/support/worker.js.headers
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/worker-redirect-upgrade.https-expected.txt
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/worker-redirect-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/worker-subresource-fetch-redirect-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/worker-subresource-fetch-upgrade.https.html
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/worker-upgrade.https-expected.txt
[add] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/upgrade-insecure-requests/worker-upgrade.https.html
[modify] https://crrev.com/f347091b94fb55bd5218d3e426f119bbc8ba2d23/third_party/blink/web_tests/external/wpt/worklets/resources/csp-tests.js

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cb62f42f41f82e6e577c1590182a042affc21f5

commit 3cb62f42f41f82e6e577c1590182a042affc21f5
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Jan 09 19:32:55 2019

[wpt/referrer-policy] Fix generator to support expansion=override

Manual changes: generic/tools/generate.py. All others are generated.

Previously, when there are two entries under "test_expansion"
in spec.src.json with the same selection path,
preceding one with expansion=default and
folllowing one with expansion=override,
two test files for each entry are generated.

This caused duplicated test files (with different names and
the same contents) in ToT, and
would cause conflicting test files if we enable referrer-policy
tests on HTTPS.

This CL suppresses generating test files for
the overridden entries, e.g. only generates one test file
for the folllowing entry with expansion=override
in the example case above.

Bug: 906850
Change-Id: Ic294adc3d240f937e37d4df6c1acc60e9ead7d80
Reviewed-on: https://chromium-review.googlesource.com/c/1389926
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621270}
[modify] https://crrev.com/3cb62f42f41f82e6e577c1590182a042affc21f5/third_party/blink/web_tests/external/wpt/referrer-policy/generic/tools/generate.py
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/attr-referrer/same-origin/http-https/iframe-tag/swap-origin-redirect/same-origin-upgrade.http.html
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/attr-referrer/same-origin/http-https/img-tag/swap-origin-redirect/same-origin-upgrade.http.html
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/attr-referrer/same-origin/http-https/script-tag/swap-origin-redirect/same-origin-upgrade.http.html
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/fetch-request/swap-origin-redirect/same-origin-upgrade.http.html
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/fetch-request/swap-origin-redirect/same-origin-upgrade.http.html.headers
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/iframe-tag/swap-origin-redirect/same-origin-upgrade.http.html
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/iframe-tag/swap-origin-redirect/same-origin-upgrade.http.html.headers
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/img-tag/swap-origin-redirect/same-origin-upgrade.http.html
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/img-tag/swap-origin-redirect/same-origin-upgrade.http.html.headers
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/script-tag/swap-origin-redirect/same-origin-upgrade.http.html
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/script-tag/swap-origin-redirect/same-origin-upgrade.http.html.headers
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/xhr-request/swap-origin-redirect/same-origin-upgrade.http.html
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/http-rp/same-origin/http-https/xhr-request/swap-origin-redirect/same-origin-upgrade.http.html.headers
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/fetch-request/swap-origin-redirect/same-origin-upgrade.http.html
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/iframe-tag/swap-origin-redirect/same-origin-upgrade.http.html
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/img-tag/swap-origin-redirect/same-origin-upgrade.http.html
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/script-tag/swap-origin-redirect/same-origin-upgrade.http.html
[delete] https://crrev.com/5d6da1bbe1e0f380537387516e52c0d833c35afc/third_party/blink/web_tests/external/wpt/referrer-policy/origin-when-cross-origin/meta-referrer/same-origin/http-https/xhr-request/swap-origin-redirect/same-origin-upgrade.http.html

Description: Show this description
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3892ea620b65976caaa76e18a0240014b14d1d1

commit f3892ea620b65976caaa76e18a0240014b14d1d1
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Sat Jan 19 01:52:04 2019

[WPT] Unify mixed-content and referrer-policy generator scripts

To prepare unifying generator mechanisms of mixed-content and
referrer-policy WPT tests, this CL unifies minor diffs
between their generator scripts.

A part of this CL applies
https://chromium-review.googlesource.com/c/chromium/src/+/1389926
to mixed-content test generators, which is no-op because
mixed-content tests don't use 'expansion=override' feature.

This CL doesn't affect the generated results and thus
this CL doesn't contain any changes to generated files.

Bug: 906850
Change-Id: I1976422799fd1344fbd471a606b174dc69d40eba
Reviewed-on: https://chromium-review.googlesource.com/c/1410085
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624410}
[modify] https://crrev.com/f3892ea620b65976caaa76e18a0240014b14d1d1/third_party/blink/web_tests/external/wpt/mixed-content/generic/tools/generate.py
[modify] https://crrev.com/f3892ea620b65976caaa76e18a0240014b14d1d1/third_party/blink/web_tests/external/wpt/mixed-content/generic/tools/spec_validator.py
[modify] https://crrev.com/f3892ea620b65976caaa76e18a0240014b14d1d1/third_party/blink/web_tests/external/wpt/referrer-policy/generic/tools/common_paths.py
[modify] https://crrev.com/f3892ea620b65976caaa76e18a0240014b14d1d1/third_party/blink/web_tests/external/wpt/referrer-policy/generic/tools/generate.py
[modify] https://crrev.com/f3892ea620b65976caaa76e18a0240014b14d1d1/third_party/blink/web_tests/external/wpt/referrer-policy/generic/tools/spec_validator.py

Comment 17 by hirosh...@chromium.org, Today (10 hours ago)

Blocking: 924041

Comment 18 by hirosh...@chromium.org, Today (10 hours ago)

Blocking: 924043

Sign in to add a comment