New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 906844 link

Starred by 2 users
Status: Fixed
Owner:
█ chowes@google.com
Last visit > 30 days ago
Closed: Nov 29
Cc:
norvez@chromium.org
ahass...@chromium.org
xiaochu@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Installing a new DLC fails due to lack of permissions.

Project Member Reported by chowes@google.com, Nov 19 
Installing a new DLC on a samus test device will result in a crash since the dlcservice user does not have permission to write to /home/chronos/.

Add checks to make sure file operation failures fail cleanly.

Give the dlcservice user permission to write to the DLC install directory.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f3ab4b66cbcad758c0a1ba5af35a3b1c5c261b9a

commit f3ab4b66cbcad758c0a1ba5af35a3b1c5c261b9a
Author: Colin Howes <chowes@google.com>
Date: Thu Nov 29 20:10:59 2018

dlcservice: Check that file operations succeed.

Add checks to make sure that creating DLC directory and image files is
successful.

BUG= chromium:906844 
TEST=Tested manually on samus. Installing a DLC will cause dlcservice to
fail and print an error message rather than crashing.

Change-Id: I3dfcd586badb8ff500e21a531d3fdd830f7151fd
Reviewed-on: https://chromium-review.googlesource.com/1343161
Commit-Ready: Colin Howes <chowes@google.com>
Tested-by: Colin Howes <chowes@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/f3ab4b66cbcad758c0a1ba5af35a3b1c5c261b9a/dlcservice/dlc_service_dbus_adaptor.cc

Comment 2 by chowes@google.com, Nov 29

Status: Fixed (was: Assigned)
Fixed for now, but still need to decide where DLC modules will live.
►

Sign in to add a comment