Enforce WebXR frame lifetimes |
|
Issue descriptionRecently the WebXR spec has been updated to make time lifetime of XRFrames and behavior outside that lifetime explicit. Chrome should be updated to follow the described behavior.
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b9341b17d13ca564811aeef4f7587059ffac204 commit 0b9341b17d13ca564811aeef4f7587059ffac204 Author: Guido Urdaneta <guidou@chromium.org> Date: Mon Dec 03 10:53:42 2018 Revert "Enforce active lifetime of XRFrame objects" This reverts commit ff451c7bfc7010d9bea16d7b7036be389afa1db5. Reason for revert: Suspect of causing consistent failure of xr_browser_tests on Win10 Debug (NVIDIA) bot. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Debug%20%28NVIDIA%29 First failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Debug%20%28NVIDIA%29/10962 Original change's description: > Enforce active lifetime of XRFrame objects > > Deactivates XRFrame objects once the relevant callback returns, which > causes future calls to the object methods to throw an exception. > > Bug: 906842 > Change-Id: I192453f9f23b1b4d9a404daca352ab80a5393753 > Reviewed-on: https://chromium-review.googlesource.com/c/1343065 > Commit-Queue: Brandon Jones <bajones@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612887} TBR=bajones@chromium.org,klausw@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 906842 Change-Id: I26eb3477ea875362a5f1e6fd0b67bbe4a3c2c4a5 Reviewed-on: https://chromium-review.googlesource.com/c/1356945 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#613039} [modify] https://crrev.com/0b9341b17d13ca564811aeef4f7587059ffac204/third_party/blink/renderer/modules/xr/xr_frame.cc [modify] https://crrev.com/0b9341b17d13ca564811aeef4f7587059ffac204/third_party/blink/renderer/modules/xr/xr_frame.h [modify] https://crrev.com/0b9341b17d13ca564811aeef4f7587059ffac204/third_party/blink/renderer/modules/xr/xr_frame.idl [modify] https://crrev.com/0b9341b17d13ca564811aeef4f7587059ffac204/third_party/blink/renderer/modules/xr/xr_session.cc [delete] https://crrev.com/32376a5f238509741027ddac5b86bc73dd5bd4ab/third_party/blink/web_tests/external/wpt/webxr/xrFrame_lifetime.https.html |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Dec 1