Issue metadata
Sign in to add a comment
|
chrome://proximity-auth no longer displays software feature names |
||||||||||||||||||||||
Issue description
Numerical values are displayed instead of readable values; example:
Supported/Enabled Features {1: [enabled], 3: [enabled], 5: [enabled], 7: [enabled]}
,
Nov 19
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29ced3fcef80063c8d3feef7932ddd6ab08fbd5e commit 29ced3fcef80063c8d3feef7932ddd6ab08fbd5e Author: Kyle Horimoto <khorimoto@chromium.org> Date: Tue Nov 20 00:05:06 2018 [CrOS MultiDevice] Fix broken chrome://proximity-auth page. This CL fixes a regression which replaced feature names on this page with numbers representing the features. The regression was caused by erroneous removal of the #include containing the operator<<() function which prints the enum names. Bug: 906836 Change-Id: Idb35e491ff379cc0ea97e63b57b4078a85efd0af Reviewed-on: https://chromium-review.googlesource.com/c/1343350 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#609516} [modify] https://crrev.com/29ced3fcef80063c8d3feef7932ddd6ab08fbd5e/chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
,
Nov 26
,
Nov 26
Actually, I'll leave this open for now. I'll look at adding a test which ensures that this does not regress.
,
Dec 21
Fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1362214, which defines chromeos::multidevice::SoftwareFeature with an operator<<(). |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by khorimoto@google.com
, Nov 19