DCHECK fails in blink |
|||
Issue descriptionDCHECK(!GetDocument().NeedsLayoutTreeUpdateForNode(*this)); fails in element.cc : https://codesearch.chromium.org/chromium/src/third_party/blink/renderer/core/dom/element.cc?q=element.cc&sq=package:chromium&dr&l=3775 Go to etsy.com, try to buy something, checkout as a guest, when you are entering your shipping address, the dcheck would fail.
,
Nov 20
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b71814c8bf500d2610c6003f0310950e85b6467d commit b71814c8bf500d2610c6003f0310950e85b6467d Author: Rune Lillesveen <futhark@chromium.org> Date: Wed Nov 21 09:02:17 2018 Ignore NeedsAdjacentStyleRecalc() for sanity DCHECK. NeedsLayoutTreeUpdateForNode() is true if an ancestor returns true for NeedsAdjacentStyleRecalc(). For getComputedStyle we may start out with a tree where we don't need a full style/layout-tree update, but matching selectors as part of EnsureComputedStyle() up the ancestor chain may cause those flags to be set if we match adjacent selectors which were not previously matched. We need to ignore those flags for the sanity check in EnsureComputedStyle. This may be the situation in which the DCHECK triggers for 900138 as well. Bug: 906830 , 900138 Change-Id: I51927fdb9f4bc44e3612628cf9b9710d26e2d8ea Reviewed-on: https://chromium-review.googlesource.com/c/1344130 Reviewed-by: Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#609956} [modify] https://crrev.com/b71814c8bf500d2610c6003f0310950e85b6467d/third_party/blink/renderer/core/css/css_computed_style_declaration_test.cc [modify] https://crrev.com/b71814c8bf500d2610c6003f0310950e85b6467d/third_party/blink/renderer/core/dom/document.cc [modify] https://crrev.com/b71814c8bf500d2610c6003f0310950e85b6467d/third_party/blink/renderer/core/dom/document.h [modify] https://crrev.com/b71814c8bf500d2610c6003f0310950e85b6467d/third_party/blink/renderer/core/dom/element.cc
,
Nov 21
|
|||
►
Sign in to add a comment |
|||
Comment 1 by futhark@chromium.org
, Nov 20