New issue
Advanced search Search tips

Issue 906791 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 802294



Sign in to add a comment

3 fullscreen tests failing with UAv2

Project Member Reported by mustaq@chromium.org, Nov 19

Issue description

Forking off from Issue 860713: these 6 tests fail with UAv2 but doesn't rely on testdriver.js:callWithTrustedClick.

external/wpt/fullscreen/api/element-ready-check-allowed-cross-origin-manual.sub.html
external/wpt/fullscreen/api/element-ready-check-containing-iframe-manual.html
external/wpt/fullscreen/api/element-request-fullscreen-two-iframes-manual.html

 
Description: Show this description
Summary: 3 fullscreen tests failing with UAv2 (was: 6 fullscreen tests failing with UAv2)
Looks like each of these three tests have non-trivial problems:

[element-ready-check-allowed-cross-origin-manual.sub.html]
We can't pass in an iframe's document (elem.contentDocument) as a container for simulated click because the contentDocument in the cross-origin subframe is inaccessible from top frame.
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-ready-check-allowed-cross-origin-manual.sub.html?rcl=15e3f4d323ca3f04e7f3c63c453906c0166a33ea&l=29


[element-ready-check-containing-iframe-manual.html]
We could use the fix we suggested for the above test, but the problem is in Chrome's automation script: auto-click.js sends mouse clicks to all buttons it finds in the page, but this test adds the second button /after/ first click is handled.  As a result, auto-click.js never finds a second button.  This passes w/o UAv2 because the first click activation is used in both cases (and will start failing if we consume activation, Issue 852645).

I guess this is a problem with all other fullscreen tests that have addButton1-handleClick1-addButton2-handleClick2 like sequencing, but I didn't investigate.


[external/wpt/fullscreen/api/element-request-fullscreen-two-iframes-manual.html]
This test is incompatible with UAv2: a single user activation can't be utilized from two sibling frames.

Found a fix for second+third tests above.
Status: Fixed (was: Assigned)

Sign in to add a comment