New issue
Advanced search Search tips

Issue 906767 link

Starred by 2 users
Status: Fixed
Owner:
rogerta@chromium.org
Closed: Nov 21
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Credential provider UI renders blank white when there's no internet connection

Project Member Reported by rogerta@google.com, Nov 19 
When there is no valid internet connection the credential provider should show a valid error message instead of a blank page.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99b45fa403711c49f43758548617e52652361b80

commit 99b45fa403711c49f43758548617e52652361b80
Author: Roger Tawa <rogerta@chromium.org>
Date: Wed Nov 21 19:13:08 2018

The credential provider should not attempt network connection
with no internet.

Bug:  906767 
Change-Id: Ib98660b4a27f6d0f5f1d5b5706813307b06bc80b
Reviewed-on: https://chromium-review.googlesource.com/c/1343286
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610124}
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/chrome/credential_provider/gaiacp/gaia_credential_base.cc
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/chrome/credential_provider/gaiacp/gaia_credential_base_unittests.cc
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/chrome/credential_provider/gaiacp/gaia_credential_provider.cc
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/chrome/credential_provider/gaiacp/gaia_credential_provider.h
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/chrome/credential_provider/gaiacp/gaia_credential_provider_idl.templ
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/chrome/credential_provider/gaiacp/gaia_credential_provider_unittests.cc
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/chrome/credential_provider/gaiacp/gaia_resources.grd
[add] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_NO_NETWORK.png.sha1
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/chrome/credential_provider/test/com_fakes.cc
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/chrome/credential_provider/test/com_fakes.h
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider.tlb
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider_i.c
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider_i.h
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider_p.c
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider.tlb
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider_i.c
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider_i.h
[modify] https://crrev.com/99b45fa403711c49f43758548617e52652361b80/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider_p.c

Comment 2 by rogerta@chromium.org, Nov 21

Status: Fixed (was: Assigned)
►

Sign in to add a comment