New issue
Advanced search Search tips

Issue 906757 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Need benchmarks to measure raster time with GPU Raster and OOP-Raster

Project Member Reported by vmi...@chromium.org, Nov 19

Issue description

The current Rasterize & Record benchmarks are good at measuring the "Record" side accurately, however the "Rasterize" side doesn't fully measure our CC raster path.  In particular, GPU Rasterization and OOP-Rasterization modes are not measured.

Add a set of benchmarks based on the GPU Benchmarking "repaint" mode, which continuously invalidates content in the visible viewport and exercise the full raster paths.
 
Cc: eyaich@chromium.org crouleau@chromium.org
Cc: -nednguyen@chromium.org nedngu...@google.com
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/16e72e67e40000

All of the runs failed. The most common error (10/20 runs) was:
HTTPException: HTTP status code 400: {"error": {"message": "CIPD package path is required. Use \".\" to install to run dir."}}
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/13c784b7e40000
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd5bccafb152e96b4a7c26f86e7aac3a0e398845

commit dd5bccafb152e96b4a7c26f86e7aac3a0e398845
Author: Victor Miura <vmiura@chromium.org>
Date: Wed Nov 21 06:46:01 2018

Repaint stories for top desktop sites.

Adds repaint stories for 10 top desktop sites.  Stories use snapshots
made with 'snap-it', to reduce potential noise from page script.

Local run-time on Linux: 4m9s

BUG= 906757 

Change-Id: Ic08be0509f7cf66008ede33e2e26525856c58c9d
Reviewed-on: https://chromium-review.googlesource.com/c/1343079
Commit-Queue: Victor Miura <vmiura@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609927}
[modify] https://crrev.com/dd5bccafb152e96b4a7c26f86e7aac3a0e398845/tools/perf/benchmark.csv
[modify] https://crrev.com/dd5bccafb152e96b4a7c26f86e7aac3a0e398845/tools/perf/page_sets/data/rendering_desktop.json
[add] https://crrev.com/dd5bccafb152e96b4a7c26f86e7aac3a0e398845/tools/perf/page_sets/data/rendering_desktop_fdde4c2d8b.wprgo.sha1
[add] https://crrev.com/dd5bccafb152e96b4a7c26f86e7aac3a0e398845/tools/perf/page_sets/rendering/repaint_desktop.py
[modify] https://crrev.com/dd5bccafb152e96b4a7c26f86e7aac3a0e398845/tools/perf/page_sets/rendering/story_tags.py

Victor, do we still need rasterize_and_record benchmarks now?

Comment 9 by vmi...@chromium.org, Jan 18 (4 days ago)

Cc: chrishtr@chromium.org
Status: Fixed (was: Started)
Re 8: I think paint-dev team still depends on rasterize_and_record benchmarks.  Adding chrishtr@ to confirm.


Sign in to add a comment