New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 906722 link

Starred by 1 user
Status: Fixed
Owner:
magchen@chromium.org
Closed: Dec 12
Cc:
█ jwd@chromium.org
zmo@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Add a Finch experiment on enabling DC overlay for all videos in Windows

Project Member Reported by magchen@chromium.org, Nov 19 
Chrome Version: (M71)
OS: (Win10)

Currently, only some of the videos will go through the Direct Composition overlay swap chain path. Many of them are still composited by the GL compositor due to better power consumption. This finch experiment will enable Direct Composition overlay for all videos.

We plan to support software protected video on all GPUs (Intel, AMD and nVidia) and all overlay types (underlay, nonroot, complex and multiple overlays). Enabling DC overlay is the only way to add this support in Windows.

We also plan to enable Direct Composition overlay for the underlay type on Intel GPU after power is improved.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ecb074a3da69e903456e413260c903ddff57098

commit 1ecb074a3da69e903456e413260c903ddff57098
Author: Maggie Chen <magchen@chromium.org>
Date: Wed Nov 28 07:27:37 2018

Add finch feature for using overlays with software protected video

This finch experiment will enable Direct Composition overlay for software
protected video on all GPUs including AMD and nVidia in Windows. Currently,
Direct Composition overlay is only enabled for Intel GPUs.

Bug:906722

Change-Id: If454f8b80f0c9cefe564b5aaa1da2232973c192a
Reviewed-on: https://chromium-review.googlesource.com/c/1342399
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611584}
[modify] https://crrev.com/1ecb074a3da69e903456e413260c903ddff57098/components/viz/service/display/DEPS
[modify] https://crrev.com/1ecb074a3da69e903456e413260c903ddff57098/components/viz/service/display/dc_layer_overlay.cc
[modify] https://crrev.com/1ecb074a3da69e903456e413260c903ddff57098/components/viz/service/display/dc_layer_overlay.h
[modify] https://crrev.com/1ecb074a3da69e903456e413260c903ddff57098/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/1ecb074a3da69e903456e413260c903ddff57098/components/viz/service/display/overlay_processor.cc
[modify] https://crrev.com/1ecb074a3da69e903456e413260c903ddff57098/components/viz/service/display/overlay_processor.h
[modify] https://crrev.com/1ecb074a3da69e903456e413260c903ddff57098/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/1ecb074a3da69e903456e413260c903ddff57098/components/viz/service/display_embedder/gpu_display_provider.cc
[modify] https://crrev.com/1ecb074a3da69e903456e413260c903ddff57098/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/1ecb074a3da69e903456e413260c903ddff57098/gpu/config/gpu_finch_features.cc
[modify] https://crrev.com/1ecb074a3da69e903456e413260c903ddff57098/gpu/config/gpu_finch_features.h
[modify] https://crrev.com/1ecb074a3da69e903456e413260c903ddff57098/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/1ecb074a3da69e903456e413260c903ddff57098/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/1ecb074a3da69e903456e413260c903ddff57098/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d291f20e6137dad758a4cd82202fd41f50e7b446

commit d291f20e6137dad758a4cd82202fd41f50e7b446
Author: Maggie Chen <magchen@chromium.org>
Date: Fri Nov 30 03:28:27 2018

Add a UMA histogram for protected video swap chain creation

UMA GPU.DirectComposition.SwapChainCreationResult3 with different protected
video types are created to record the pass/fail status for protected video
swap chain creation.

Bug:  906722 
Change-Id: I558ec85ba75db030f86bd1a11c19410ff391d35c
Reviewed-on: https://chromium-review.googlesource.com/c/1352053
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612542}
[modify] https://crrev.com/d291f20e6137dad758a4cd82202fd41f50e7b446/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/d291f20e6137dad758a4cd82202fd41f50e7b446/tools/metrics/histograms/histograms.xml

Comment 3 by magchen@chromium.org, Dec 4

Cc: jwd@chromium.org

Comment 4 by magchen@chromium.org, Dec 12

Status: Fixed (was: Assigned)
►

Sign in to add a comment