New issue
Advanced search Search tips

Issue 906713 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task



Sign in to add a comment

Refactor AccountTrackerService account seeding on Android

Project Member Reported by bsazonov@chromium.org, Nov 19

Issue description

The current approach to account seeding is over-complicated, error-prone and requires a lot of boilerplate.
Since we have a cache in AccountManagerFacade, it makes sense to put account ids there and make AccountTrackerService return these ids instead of keeping a local cache that has to be updated.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52ebb71a0c67694859a7fc4181dffe5718e4b09b

commit 52ebb71a0c67694859a7fc4181dffe5718e4b09b
Author: Boris Sazonov <bsazonov@chromium.org>
Date: Thu Nov 22 11:12:55 2018

[Signin][Android] Add histogram for duration of getting account ids

This CL adds Signin.AndroidGetAccountIdsTime histogram that tracks how
much time it takes to get account ids for all accounts on the device.

Bug: 906713
Change-Id: Ie59e815fcb469ced15fe308378e7c3fbc07d776a
Reviewed-on: https://chromium-review.googlesource.com/c/1342997
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610376}
[modify] https://crrev.com/52ebb71a0c67694859a7fc4181dffe5718e4b09b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountTrackerService.java
[modify] https://crrev.com/52ebb71a0c67694859a7fc4181dffe5718e4b09b/tools/metrics/histograms/histograms.xml

Summary: Refactor AccountTrackerService account seeding on Android (was: Refactor AccountTrackerService account seeding)

Sign in to add a comment