New issue
Advanced search Search tips

Issue 906707 link

Starred by 1 user
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Nov 19
Cc:
x...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK hit when long press overview button tray.

Project Member Reported by sammiequon@chromium.org, Nov 19 
[1] will get hit. I think this is because Toggle Overview is called, which starts animating the windows. Then SnapWindow is called, which changes the transforms, and thus ends their animations, calling OnStartingAnimationComplete, which activates the hidden text box in overview. This is all done before SnapWindow has finished, so IsSplitViewModeActive still returns false.

[1] https://cs.chromium.org/chromium/src/ash/wm/splitview/split_view_controller.cc?rcl=0c489f4f41545adab3d4682f0f3c99713a3cb062&l=700
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48ac7e2a00aaa3c8950438ebf9072d91f8eadcc5

commit 48ac7e2a00aaa3c8950438ebf9072d91f8eadcc5
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Nov 19 20:12:50 2018

splitview: Fix failing DCHECK in OnWindowActivated.

This failed previously because when SnapWindow is called after ToggleOverview,
it ends the overview start animations, which then activates the hidden
overview textfield. This causes OnWindowActivated to be called before
SnapWindow has finished, so IsSplitViewModeActive() still returns false.

Test: tested with DCHECKS enabled
Bug:  906707 
Change-Id: Ic7b99eb8642f8bf1cd1badaa6fa6c981127987a7
Reviewed-on: https://chromium-review.googlesource.com/c/1342807
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609408}
[modify] https://crrev.com/48ac7e2a00aaa3c8950438ebf9072d91f8eadcc5/ash/wm/overview/window_selector.h
[modify] https://crrev.com/48ac7e2a00aaa3c8950438ebf9072d91f8eadcc5/ash/wm/splitview/split_view_controller.cc

Comment 2 by sammiequon@chromium.org, Nov 19

Status: Fixed (was: Started)
►

Sign in to add a comment