New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 7
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----


Participants' hotlists:
Launcher-Tech-Debt


Sign in to add a comment
link

Issue 906684: TACM dead code cleanup

Reported by newcomer@chromium.org, Nov 19 Project Member

Issue description

All in the title
 

Comment 1 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ca0664f1915966cdebea25f9b5e4c0dc49f11b8

commit 3ca0664f1915966cdebea25f9b5e4c0dc49f11b8
Author: Alex Newcomer <newcomer@chromium.org>
Date: Mon Nov 19 19:46:16 2018

cros: Remove dead touchable app context menu code

For ash/app_list.

Bug:  906684 
Change-Id: I8b3b79ba1e4220d0c2a3e3df8e822300ac6f63a7
Reviewed-on: https://chromium-review.googlesource.com/c/1342621
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609401}
[modify] https://crrev.com/3ca0664f1915966cdebea25f9b5e4c0dc49f11b8/ash/app_list/views/app_list_item_view.cc
[modify] https://crrev.com/3ca0664f1915966cdebea25f9b5e4c0dc49f11b8/ash/app_list/views/search_result_tile_item_view.cc

Comment 2 by bugdroid1@chromium.org, Nov 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6dfd5097264d08ed3a37e9bc7a4984c048b14d7

commit e6dfd5097264d08ed3a37e9bc7a4984c048b14d7
Author: Alex Newcomer <newcomer@chromium.org>
Date: Tue Nov 20 00:25:27 2018

cros: Touchable app context menu dead code cleanup

More cleanups, this is just within ash, not within app_list or shelf.

Bug:  906684 
Change-Id: I42b6a0b6765481685a1ec5e612b4d849f8f3f0ff
Reviewed-on: https://chromium-review.googlesource.com/c/1342766
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609525}
[modify] https://crrev.com/e6dfd5097264d08ed3a37e9bc7a4984c048b14d7/ash/root_window_controller.cc

Comment 3 by bugdroid1@chromium.org, Nov 27

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 7

Project Member

Comment 5 by newcomer@chromium.org, Dec 7

Status: Fixed (was: Started)

Sign in to add a comment