<GoogleServicesSettingsTestCase.testActivityAndInteractionsDisabledWithHistoryDisabled>Disabled |
|||||
Issue descriptionThis test is failing continually on iPhone/iPad. This is a full disable.
,
Nov 23
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f9bb40d43c4077810c766cee908a1a03ec115c1 commit 9f9bb40d43c4077810c766cee908a1a03ec115c1 Author: Jérôme Lebel <jlebel@chromium.org> Date: Thu Nov 29 10:32:40 2018 [iOS] Removing "Activity and Interactions" settings Removing "Activity and Interactions" settings. This option is not available anymore after changes on Unity project. Bug: 906727, 906680 Change-Id: I4401bbf80d8fac257db0e6ee18cc7a6670e71f44 Reviewed-on: https://chromium-review.googlesource.com/c/1343078 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#612131} [modify] https://crrev.com/9f9bb40d43c4077810c766cee908a1a03ec115c1/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/9f9bb40d43c4077810c766cee908a1a03ec115c1/ios/chrome/browser/sync/BUILD.gn [modify] https://crrev.com/9f9bb40d43c4077810c766cee908a1a03ec115c1/ios/chrome/browser/sync/profile_sync_service_factory.cc [modify] https://crrev.com/9f9bb40d43c4077810c766cee908a1a03ec115c1/ios/chrome/browser/sync/sync_setup_service.cc [modify] https://crrev.com/9f9bb40d43c4077810c766cee908a1a03ec115c1/ios/chrome/browser/sync/sync_setup_service.h [modify] https://crrev.com/9f9bb40d43c4077810c766cee908a1a03ec115c1/ios/chrome/browser/ui/settings/google_services_settings_egtest.mm [modify] https://crrev.com/9f9bb40d43c4077810c766cee908a1a03ec115c1/ios/chrome/browser/ui/settings/google_services_settings_mediator.mm [modify] https://crrev.com/9f9bb40d43c4077810c766cee908a1a03ec115c1/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm [modify] https://crrev.com/9f9bb40d43c4077810c766cee908a1a03ec115c1/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm
,
Nov 29
,
Nov 29
[Auto-generated comment by a script] We noticed that this issue is targeted for M-72; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-72 label, otherwise remove Merge-TBD label. Thanks.
,
Nov 29
The test has been remove since it is not relevant anymore.
,
Jan 7
jlebel: does this CL need to be merged to M72?
,
Jan 8
No, this part of UI is not visible for the user. It is under a flag.
,
Jan 11
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mrsuyi@chromium.org
, Nov 20