New issue
Advanced search Search tips

Issue 906676 link

Starred by 1 user
Status: Fixed
Owner:
qnnguyen@chromium.org
Closed: Nov 19
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename LoginTestBase::data_dispatcher() to DataDispatcher()

Project Member Reported by qnnguyen@chromium.org, Nov 19 
Since login test base will soon have LockScreen-show functionality, the data_dispatcher() method now has more logic than just returning a member variable. Therefore it no longer fits the style guide for naming getters and we should rename it to DataDispatcher.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3774d66c644b075d2e086120d7e1e3c47367ed18

commit 3774d66c644b075d2e086120d7e1e3c47367ed18
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Mon Nov 19 23:15:17 2018

cros: Rename LoginTestBase::data_dispatcher to DataDispatcher

This puts the method name more in line with Google C++ style, since snake_case
should only be used with simple getters.

Bug:  906676 
Change-Id: I045aa7c8ac641b37854b38cf0934890ebbd88ca0
Reviewed-on: https://chromium-review.googlesource.com/c/1343250
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609491}
[modify] https://crrev.com/3774d66c644b075d2e086120d7e1e3c47367ed18/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/3774d66c644b075d2e086120d7e1e3c47367ed18/ash/login/ui/lock_screen_sanity_unittest.cc
[modify] https://crrev.com/3774d66c644b075d2e086120d7e1e3c47367ed18/ash/login/ui/login_test_base.cc
[modify] https://crrev.com/3774d66c644b075d2e086120d7e1e3c47367ed18/ash/login/ui/login_test_base.h
[modify] https://crrev.com/3774d66c644b075d2e086120d7e1e3c47367ed18/ash/metrics/login_metrics_recorder_unittest.cc

Comment 2 by qnnguyen@chromium.org, Nov 19

Status: Fixed (was: Untriaged)
►

Sign in to add a comment