New issue
Advanced search Search tips

Issue 906673 link

Starred by 2 users
Status: Started
Owner:
peconn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Disable App Install Banners for Trusted Web Activities

Project Member Reported by peconn@chromium.org, Nov 19 
App Banners show when Chrome detects that the webpage being viewed is installable.

Trusted Web Activities are likely to be used to view websites using PWA technologies (so they are likely to be installable), but are being viewed through a specialised TWA client app.

Therefore we shouldn't show app banners for TWAs.

It would also be interesting to re-enable App Banners when the user leaves the verified origin.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41be107808bd2d94c6e19cb48f684da670f51585

commit 41be107808bd2d94c6e19cb48f684da670f51585
Author: Peter E Conn <peconn@chromium.org>
Date: Tue Nov 20 10:44:35 2018

🤝 Disable app banners on Trusted Web Activities.

Chances are the user of a TWA already has an app installed for the site
they are viewing. In this case we should not show the app install
banner.

Bug: 906673
Change-Id: Ic09242e902cb4a76cc3deb879a1dd62b71614bf7
Reviewed-on: https://chromium-review.googlesource.com/c/1342618
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609660}
[modify] https://crrev.com/41be107808bd2d94c6e19cb48f684da670f51585/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/41be107808bd2d94c6e19cb48f684da670f51585/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java
[modify] https://crrev.com/41be107808bd2d94c6e19cb48f684da670f51585/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
►

Sign in to add a comment