New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 906669 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit 18 days ago
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Direct-leak in spvDiagnosticCreate

Project Member Reported by ClusterFuzz, Nov 19

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6460465046355968

Fuzzer: libFuzzer_spvtools_opt_legalization_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  spvDiagnosticCreate
  spvtools::UseDiagnosticAsMessageConsumer
  spvtools::DiagnosticStream::~DiagnosticStream
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=581974:581978

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6460465046355968

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 19

Components: Internals>GPU>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 19

Cc: d...@everburning.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Cleanup includes. (#1795) by dj2@everburning.com - https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+/eda2cfbe128e5b71e9a0131f816ade5186ad6420

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Cc: -d...@everburning.com dsinclair@chromium.org
Owner: stevenperron@google.com
Status: Assigned (was: Untriaged)
The problem is that the message consumer used by the validator it keeps just a single message.  If there is a second message, then pointer to the first message is overwritten, and lost.

The code that needs to change is in https://github.com/KhronosGroup/SPIRV-Tools/blob/master/source/diagnostic.cpp#L116.  
Owner: alanbaker@google.com
Status: Started (was: Assigned)
https://github.com/KhronosGroup/SPIRV-Tools/pull/2110
Project Member

Comment 7 by ClusterFuzz, Nov 28

ClusterFuzz has detected this issue as fixed in range 611369:611409.

Detailed report: https://clusterfuzz.com/testcase?key=6460465046355968

Fuzzer: libFuzzer_spvtools_opt_legalization_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  spvDiagnosticCreate
  spvtools::UseDiagnosticAsMessageConsumer
  spvtools::DiagnosticStream::~DiagnosticStream
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=581974:581978
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=611369:611409

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6460465046355968

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Nov 28

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6460465046355968 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment