New issue
Advanced search Search tips

Issue 906637 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 27
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

SetProxyOverride method should receive a list of proxies

Project Member Reported by laisminchillo@chromium.org, Nov 19

Issue description

SetProxyOverride method should receive a list of proxies instead of just a host and port.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc08f72666434525612301f7b3638f4084ad10c6

commit bc08f72666434525612301f7b3638f4084ad10c6
Author: Laís Minchillo <laisminchillo@chromium.org>
Date: Wed Dec 19 19:24:07 2018

[aw] Update proxy API to receive proxy rules

Update setProxyOverride method to receive an array of proxy rules
(schemeFilter, proxyUrl) and an array of bypass rules.

Move proxy override methods from AwContentsStatics to AwProxyController
as they are no longer static.

Bug:  906637 
Change-Id: I3551001a2574204988aad9663ff5ff248494cc89
Reviewed-on: https://chromium-review.googlesource.com/c/1313049
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617905}
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/BUILD.gn
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/browser/aw_contents_statics.cc
[add] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/browser/aw_proxy_controller.cc
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/browser/net/aw_url_request_context_getter.h
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/glue/java/src/com/android/webview/chromium/SharedStatics.java
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumAwInit.java
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java
[add] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/java/src/org/chromium/android_webview/AwProxyController.java
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/support_library/BUILD.gn
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/support_library/boundary_interfaces/BUILD.gn
[add] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/ProxyControllerBoundaryInterface.java
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/StaticsBoundaryInterface.java
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebViewProviderFactoryBoundaryInterface.java
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
[add] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibProxyControllerAdapter.java
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/net/proxy_resolution/proxy_config_service_android.cc
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/net/proxy_resolution/proxy_config_service_android.h
[modify] https://crrev.com/bc08f72666434525612301f7b3638f4084ad10c6/net/proxy_resolution/proxy_config_service_android_unittest.cc

Status: Fixed (was: Started)
Please add manual verification steps so we can verify the changes.Thanks

Comment 4 by laisminchillo@chromium.org, Jan 16 (6 days ago)

To verify this just run tests in AwProxyControllerTest

Sign in to add a comment