New issue
Advanced search Search tips

Issue 906618 link

Starred by 2 users
Status: Fixed
Owner:
toniki...@chromium.org
Closed: Nov 26
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 890775
issue 906615



Sign in to add a comment

Extend IdentityTestEnvironmentProfileAdaptor with APIs needed by identity_apitest.cc

Project Member Reported by blundell@chromium.org, Nov 19 
- It needs to set testing factories explicitly on a Profile that is passed to it. The easiest way will be to add a SetIdentityTestEnvironmentFactoriesOnBrowserContext(content::BrowserContext* context) method.

- It needs to build a FakeGaiaCookieManagerService without a fake URL fetcher. To enable that, we should add an optional use_fake_url_fetcher = true parameter to the methods that set the factories. We can bikeshid on the exact param name on the CL.

Comment 1 by toniki...@chromium.org, Nov 19

Owner: toniki...@chromium.org
Status: Started (was: Available)

Comment 3 by svil...@igalia.com, Nov 20

Blocking: 890775
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e80adb638682da52a85340be938a9d9dbbb3d33

commit 7e80adb638682da52a85340be938a9d9dbbb3d33
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Nov 26 13:29:16 2018

[s13n] Extend IdentityTestEnvironmentProfileAdaptor with APIs needed by identity_apitest.cc

This CL extends IdentityTestEnvironment{Profile,ChromeBrowserState}Adaptor
classes with a handful set of APIs needed for identity_apitest.cc, and possibly
some other conversions.

In summary:
- It adds a method that allows setting the testing factories that
 identity::IdentityTestEnvironment requires explicitly on a Profile
 that is passed to it.
- It extends all methods that (in)directly call
  GetIdentityTestEnvironmentFactories with the possibility to use
  or not the "fake URL fetcher" for Gaia's Cookie Manager factory.

BUG= 906618 

Change-Id: I54985c0743ed0ae2528140fac655fcf1baeb9531
Reviewed-on: https://chromium-review.googlesource.com/c/1346609
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610836}
[modify] https://crrev.com/7e80adb638682da52a85340be938a9d9dbbb3d33/chrome/browser/extensions/api/identity/identity_apitest.cc
[modify] https://crrev.com/7e80adb638682da52a85340be938a9d9dbbb3d33/chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
[modify] https://crrev.com/7e80adb638682da52a85340be938a9d9dbbb3d33/chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h
[modify] https://crrev.com/7e80adb638682da52a85340be938a9d9dbbb3d33/chrome/browser/signin/identity_test_environment_profile_adaptor.cc
[modify] https://crrev.com/7e80adb638682da52a85340be938a9d9dbbb3d33/chrome/browser/signin/identity_test_environment_profile_adaptor.h
[modify] https://crrev.com/7e80adb638682da52a85340be938a9d9dbbb3d33/chrome/browser/signin/signin_ui_util_unittest.cc
[modify] https://crrev.com/7e80adb638682da52a85340be938a9d9dbbb3d33/ios/chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
[modify] https://crrev.com/7e80adb638682da52a85340be938a9d9dbbb3d33/ios/chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h
[modify] https://crrev.com/7e80adb638682da52a85340be938a9d9dbbb3d33/ios/chrome/browser/signin/identity_test_environment_chrome_browser_state_adaptor.cc
[modify] https://crrev.com/7e80adb638682da52a85340be938a9d9dbbb3d33/ios/chrome/browser/signin/identity_test_environment_chrome_browser_state_adaptor.h

Comment 5 by toniki...@chromium.org, Nov 26

Status: Fixed (was: Started)
►

Sign in to add a comment