Issue metadata
Sign in to add a comment
|
Convert identity_apitest.cc to use IdentityTestEnvironment |
||||||||||||||||||||||
Issue descriptionIt currently uses FakePO2TS, FakeSigninManager, and FakeGaiaCookieManagerService.
,
Nov 19
,
Nov 19
Note: the blocking bug should be implemented first (or implemented together and then sent out as its own precursor CL).
,
Nov 19
,
Nov 19
CL https://chromium-review.googlesource.com/c/chromium/src/+/1343019 (including a big for 906618).
,
Nov 20
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa626b9fede1d7f3e04ef072615d9b40b81e9442 commit fa626b9fede1d7f3e04ef072615d9b40b81e9442 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Mon Nov 26 14:29:45 2018 [s13n] Convert identity_apitest.cc to use IdentityTestEnvironment This bug is a follow up of [1] and [2], where production code (//c/b/extensions/api/identity/identity_api.cc) is migrated away from using PO2TS in favor of IdentityManager, and the API is extended to accommodate the needs of this migration, respectively. [1] https://crrev.com/b/1340890 [2] https://crrev.com/b/1346609 BUG= 906615 Change-Id: Ib41f99f08b7d181bbcff28be97c8b55993aa8c04 Reviewed-on: https://chromium-review.googlesource.com/c/1343019 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#610844} [modify] https://crrev.com/fa626b9fede1d7f3e04ef072615d9b40b81e9442/chrome/browser/extensions/api/identity/identity_apitest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by blundell@google.com
, Nov 19