New issue
Advanced search Search tips

Issue 906615 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 890775
Owner:
Closed: Nov 20
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 906618

Blocking:
issue 883318
issue 883330



Sign in to add a comment

Convert identity_apitest.cc to use IdentityTestEnvironment

Project Member Reported by blundell@google.com, Nov 19

Issue description

It currently uses FakePO2TS, FakeSigninManager, and FakeGaiaCookieManagerService.
 
Blocking: 883330 883318
Blockedon: 906618
Note: the blocking bug should be implemented first (or implemented together and then sent out as its own precursor CL). 
Owner: toniki...@chromium.org
Status: Started (was: Available)
Mergedinto: 890775
Status: Duplicate (was: Started)
This is a dup
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa626b9fede1d7f3e04ef072615d9b40b81e9442

commit fa626b9fede1d7f3e04ef072615d9b40b81e9442
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Nov 26 14:29:45 2018

[s13n] Convert identity_apitest.cc to use IdentityTestEnvironment

This bug is a follow up of [1] and [2], where production code
(//c/b/extensions/api/identity/identity_api.cc) is migrated away from
using PO2TS in favor of IdentityManager, and the API is extended to
accommodate the needs of this migration, respectively.

[1] https://crrev.com/b/1340890
[2] https://crrev.com/b/1346609

BUG= 906615 

Change-Id: Ib41f99f08b7d181bbcff28be97c8b55993aa8c04
Reviewed-on: https://chromium-review.googlesource.com/c/1343019
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610844}
[modify] https://crrev.com/fa626b9fede1d7f3e04ef072615d9b40b81e9442/chrome/browser/extensions/api/identity/identity_apitest.cc

Sign in to add a comment