New issue
Advanced search Search tips

Issue 906612 link

Starred by 1 user
Status: Fixed
Owner:
f...@opera.com
Closed: Nov 22
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Expose constants for "new" blend-modes on SVGFEBlendElement

Project Member Reported by f...@opera.com, Nov 19 
It looks[1] like every other browser expose these constants[2], so we probably should too.

[1] https://wpt.fyi/results/css/filter-effects/interfaces.any.html
[2] ..._OVERLAY through to ..._LUMINOSITY; https://drafts.fxtf.org/filter-effects/#InterfaceSVGFEBlendElement
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8fe553b28ac4fa54639c96d26ce7b106d671f8d

commit c8fe553b28ac4fa54639c96d26ce7b106d671f8d
Author: Fredrik Söderquist <fs@opera.com>
Date: Thu Nov 22 11:25:59 2018

Expose all constants on SVGFEBlendElement

Per:

  https://drafts.fxtf.org/filter-effects/#InterfaceSVGFEBlendElement

All other browsers expose these already.

Bug:  906612 
Change-Id: I4be6185d4832d980a5d7c6518dcb0b2ccca2ce82
Reviewed-on: https://chromium-review.googlesource.com/c/1341846
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610379}
[modify] https://crrev.com/c8fe553b28ac4fa54639c96d26ce7b106d671f8d/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/interfaces.any-expected.txt
[add] https://crrev.com/c8fe553b28ac4fa54639c96d26ce7b106d671f8d/third_party/WebKit/LayoutTests/external/wpt/css/filter-effects/svgfeblendelement-mode-001.html
[delete] https://crrev.com/409dab09625428865570094a44a214c3c52df5a2/third_party/WebKit/LayoutTests/external/wpt/svg/types/scripted/SVGAnimatedEnumeration-SVGFEBlendElement.html
[modify] https://crrev.com/c8fe553b28ac4fa54639c96d26ce7b106d671f8d/third_party/WebKit/LayoutTests/svg/filters/feBlend-invalid-mode-expected.txt
[modify] https://crrev.com/c8fe553b28ac4fa54639c96d26ce7b106d671f8d/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/c8fe553b28ac4fa54639c96d26ce7b106d671f8d/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c8fe553b28ac4fa54639c96d26ce7b106d671f8d/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/c8fe553b28ac4fa54639c96d26ce7b106d671f8d/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c8fe553b28ac4fa54639c96d26ce7b106d671f8d/third_party/blink/renderer/core/svg/svg_fe_blend_element.cc
[modify] https://crrev.com/c8fe553b28ac4fa54639c96d26ce7b106d671f8d/third_party/blink/renderer/core/svg/svg_fe_blend_element.h
[modify] https://crrev.com/c8fe553b28ac4fa54639c96d26ce7b106d671f8d/third_party/blink/renderer/core/svg/svg_fe_blend_element.idl

Comment 2 by f...@opera.com, Nov 22

Owner: f...@opera.com
Status: Fixed (was: Available)
►

Sign in to add a comment