New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 906611 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Introduce separate enum for syncer::UserSelectableTypes()

Project Member Reported by treib@chromium.org, Nov 19

Issue description

syncer::UserSelectableTypes returns the subset of Sync ModelTypes that directly map to a checkbox in settings. This is problematic for a number of reasons:
- Some Sync APIs take all model types, some take only user-selectable types, and this is not clear from the signature.
- The mapping isn't really obvious, e.g. why does TYPED_URLS equal the "History" checkbox?
- Redundant state in prefs: We currently store the full set of "preferred" data types, i.e. the actually selected ones plus any that are implied by them.
- There is a model type PROXY_TABS which is not an actual type, but just exists to back a checkbox in settings.

All of these could be solved by having a separate enum for user-selectable types.
 
The iOS SyncSetupService already defines its own SyncableDatatype enum. It's restricted to the types supported on iOS, but otherwise exactly what we're looking for here.

Comment 2 by mastiz@chromium.org, Jan 17 (5 days ago)

Cc: mastiz@chromium.org
Labels: -Type-Bug Sync-Triaged Hotlist-GoodFirstBug Type-Task
Owner: mmoskvitin@google.com
Status: Assigned (was: Available)
Tentatively assigning to mmoskvitin@ in case he runs out of work or wants to touch a different codebase.

Sign in to add a comment