Issue metadata
Sign in to add a comment
|
Regression: Unnecessary thumbnails are created for chrome internal pages on NTP
Reported by
khushal....@etouch.net,
Nov 19
|
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3615.0 (Official Build) Revision b3d2a4297369aea42f2c1c68177b94cdaf8c6e43-refs/branch-heads/3615@{#1} (32/64-bit) OS: Windows (7, 8, 8.1, 10), Mac (10.13.1, 10.13.6, 10.14.2) and Linux (14.04 LTS) Pre-condition: Enable the flag 'Enable using the Google local NTP' and 'New Tab Page Custom Links' from chrome://flags/ What steps will reproduce the problem? (1) Launch chrome, open NTP and click on 'Add shortcut' thumbnail. (2) Enter 'chrome://history' or any chrome internal page in URL field and click on 'Done' button. (3) Observe thumbnails. Actual Result: Unnecessary thumbnails are created for chrome internal pages on NTP. Expected Result: Thumbnails should not be created for chrome internal pages on NTP and if created then it should be clickable. This is a Regression issue seen from 'M-70' and providing the bisect info below: Good Build: 70.0.3507.0 (Revision: 578962) Bad Build: 70.0.3508.0 (Revision: 579241) You are probably looking for a change made after 578988 (known good), but no later than 578989 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/6f093af4d47dfa53b5bc046602c2c420d5ce3f19..0e19d3a4cfebed8a43abe543b4d6a9092f7e2b8f Suspect: https://chromium.googlesource.com/chromium/src/+/0e19d3a4cfebed8a43abe543b4d6a9092f7e2b8f @kristipark: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: Issue is also seen on M-70 Stable (build #70.0.3538.102), M-71 Beta (build #71.0.3578.53) and M-72 Dev (build #72.0.3610.2). Kindly refer the attached screen-cast. Thank You..!!
,
Nov 20
,
Nov 20
,
Nov 27
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bb60b09a6eb56b4c413365319b9ed49c47d8103 commit 0bb60b09a6eb56b4c413365319b9ed49c47d8103 Author: Kristi Park <kristipark@chromium.org> Date: Tue Nov 27 22:48:43 2018 [NTP] Check for allowed schemes before adding custom link Show error message for URLs with invalid schemes, and remove leftover function that was removed. Bug: 906607 Change-Id: I6cd5a7267de3d439c1e54c01f846f03fd9247f62 Reviewed-on: https://chromium-review.googlesource.com/c/1343365 Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#611388} [modify] https://crrev.com/0bb60b09a6eb56b4c413365319b9ed49c47d8103/chrome/browser/resources/local_ntp/custom_links_edit.js [modify] https://crrev.com/0bb60b09a6eb56b4c413365319b9ed49c47d8103/chrome/browser/resources/local_ntp/most_visited_single.js [modify] https://crrev.com/0bb60b09a6eb56b4c413365319b9ed49c47d8103/chrome/browser/resources/local_ntp/utils.js
,
Nov 27
,
Nov 28
Update: Rechecked the above issue on Windows (7, 8, 8.1, 10), Mac (10.13.1, 10.13.6, 10.14.2) and Linux (14.04 LTS) using latest Canary version #72.0.3624.0 and the issue is Fixed. Hence, adding TE-Verified labels. Please refer the attached screen-cast. Thank You..!!
,
Nov 28
The NextAction date has arrived: 2018-11-28 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ramyan@chromium.org
, Nov 19