New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 906605 link

Starred by 1 user
Status: Fixed
Owner:
pbos@chromium.org
Closed: Nov 19
Cc:
sdy@chromium.org
edwardjung@chromium.org
█ helenepark@chromium.org
markchang@chromium.org
bettes@chromium.org
sky@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[Tab loading animation] Evaluate displaying throbber below favicon while loading page.

Project Member Reported by pbos@chromium.org, Nov 19 
Rendering the throbber on top of favicons not only obscures them but also makes the progress indicator extremely hard to read on top of blue favicons in the default theme (say Facebook, which is fairly popular).

Attaching (buggy, issue 905452) screen cap. We should also consider having a rect instead of a roundrect with this thickness.
1dp-offset.mov
316 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2fbae6a7f780fd484c44a73adf99d6eabae3522

commit e2fbae6a7f780fd484c44a73adf99d6eabae3522
Author: Peter Boström <pbos@chromium.org>
Date: Mon Nov 19 14:50:32 2018

Display tab throbber under favicon

Decoupling the two helps when displaying a blue favicon (such as
Facebook) under the loading-progress indicator. Similar concerns apply
in incognito over grey favicons. There are possibly similar concerns
when using themes.

This change also decouples favicon placeholder roundrect radius from
throbber since they are no longer overlapping eachother.

Bug:  chromium:906605 
Change-Id: Ie1959d0d447851f3cac3430e3d31b3b989bed263
Reviewed-on: https://chromium-review.googlesource.com/c/1341527
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609289}
[modify] https://crrev.com/e2fbae6a7f780fd484c44a73adf99d6eabae3522/chrome/browser/ui/views/tabs/tab_icon.cc

Comment 2 by pbos@chromium.org, Nov 19

Status: Fixed (was: Started)
edwardjung@: Please reopen if you want us to revert here.

Comment 3 by ajha@chromium.org, Nov 21

Labels: TE-Verified-M72 TE-Verified-72.0.3616.0
Verified the fix on the latest canary 72.0.3616.0 on Windows-10, Mac OS 10.13.6 and Linux debian Rodete and this is WAI. Progress indicator below the facebook favicon rendered fine. Attaching the screen-cast of the latest behavior and comparison with the behavior on the build without the fix.
906605.mp4
663 KB View Download
►

Sign in to add a comment