We should have the same metrics as desktop.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b885226cf8d11442f30c82ed5c5764713bf8eeb commit 2b885226cf8d11442f30c82ed5c5764713bf8eeb Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Nov 22 10:14:11 2018 [iOS] Add wrapper around WebLoadParams This CL adds a wrapper around the WebLoadParams to be able to add params that make sense only at the Chrome level. Bug: 906598 Change-Id: I5bd710da4d38c9b9601a297e3f69aa7013ff91d2 Reviewed-on: https://chromium-review.googlesource.com/c/1346403 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#610360} [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/bookmarks/bookmark_interaction_controller.mm [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/browser_view_controller.mm [add] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/chrome_load_params.h [add] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/chrome_load_params.mm [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/commands/application_commands.h [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator.mm [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator_unittest.mm [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/history/history_table_view_controller.mm [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/ntp/incognito_view.mm [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/omnibox/popup/shortcuts/shortcuts_mediator.mm [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/static_content/static_html_native_content.h [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/static_content/static_html_native_content.mm [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/static_content/static_html_view_controller.mm [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/tab_grid/tab_grid_url_loader.mm [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/browser/ui/url_loader.h [modify] https://crrev.com/2b885226cf8d11442f30c82ed5c5764713bf8eeb/ios/chrome/test/fakes/fake_url_loader.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/cb1b506b6bb5957ff800074fc58cd46852a54dca commit cb1b506b6bb5957ff800074fc58cd46852a54dca Author: Gauthier Ambard <gambard@google.com> Date: Thu Nov 22 11:07:31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c818e00b2964c740400fbac46663e836ced6cf8 commit 9c818e00b2964c740400fbac46663e836ced6cf8 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Nov 27 13:04:16 2018 [iOS] Use Omnibox callbacks to switch tabs This CL uses the callbacks used when the user tab an omnibox result to switch to an open tab. It allows to record the same metrics as desktop. Bug: 906598 Change-Id: I12d848915b1a8a266d887d1eec11f71d2daef1a8 Reviewed-on: https://chromium-review.googlesource.com/c/1341538 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#611082} [modify] https://crrev.com/9c818e00b2964c740400fbac46663e836ced6cf8/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/9c818e00b2964c740400fbac46663e836ced6cf8/ios/chrome/browser/ui/browser_view_controller_unittest.mm [modify] https://crrev.com/9c818e00b2964c740400fbac46663e836ced6cf8/ios/chrome/browser/ui/commands/browser_commands.h [modify] https://crrev.com/9c818e00b2964c740400fbac46663e836ced6cf8/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm [modify] https://crrev.com/9c818e00b2964c740400fbac46663e836ced6cf8/ios/chrome/browser/ui/location_bar/location_bar_coordinator_unittest.mm [modify] https://crrev.com/9c818e00b2964c740400fbac46663e836ced6cf8/ios/chrome/browser/ui/location_bar/location_bar_url_loader.h [modify] https://crrev.com/9c818e00b2964c740400fbac46663e836ced6cf8/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_mediator.h [modify] https://crrev.com/9c818e00b2964c740400fbac46663e836ced6cf8/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_mediator.mm [modify] https://crrev.com/9c818e00b2964c740400fbac46663e836ced6cf8/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_ios.h [modify] https://crrev.com/9c818e00b2964c740400fbac46663e836ced6cf8/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_ios.mm [modify] https://crrev.com/9c818e00b2964c740400fbac46663e836ced6cf8/ios/chrome/browser/ui/omnibox/web_omnibox_edit_controller_impl.mm [modify] https://crrev.com/9c818e00b2964c740400fbac46663e836ced6cf8/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm [modify] https://crrev.com/9c818e00b2964c740400fbac46663e836ced6cf8/ios/chrome/test/fakes/fake_url_loader.h [modify] https://crrev.com/9c818e00b2964c740400fbac46663e836ced6cf8/ios/chrome/test/fakes/fake_url_loader.mm
Comment 1 by bugdroid1@chromium.org
, Nov 22