New issue
Advanced search Search tips

Issue 906591 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

'single-line-must-not-be-split-into-two-pages" test fails

Project Member Reported by kolos@chromium.org, Nov 19

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62b33e41771dfef63416b97c25be29d7e2a091ef

commit 62b33e41771dfef63416b97c25be29d7e2a091ef
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Mon Nov 19 12:47:24 2018

Disabling single-line-must-not-be-split-into-two-pages.html tests

Tests fail.

TBR=yosin@chromium.org

Bug:  906591 
Change-Id: Idf84e8776005d0d00409f06816e930f6903f52a4
Reviewed-on: https://chromium-review.googlesource.com/c/1341521
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609253}
[modify] https://crrev.com/62b33e41771dfef63416b97c25be29d7e2a091ef/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76b18224e8d31a66f43f639eba1456dd9017e33a

commit 76b18224e8d31a66f43f639eba1456dd9017e33a
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Mon Nov 19 18:56:06 2018

Disable single-line-must-not-be-split-into-two-pages.html tests

Disable tests on all platforms as it causes flaky test failures.

TBR=yosin@chromium.org

Bug:  906591 
Change-Id: I505ed183094dbd662005f4ea903dbd2d6e03d9ee
Reviewed-on: https://chromium-review.googlesource.com/c/1342798
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609371}
[modify] https://crrev.com/76b18224e8d31a66f43f639eba1456dd9017e33a/third_party/WebKit/LayoutTests/TestExpectations

Should be irrelevant to my patch crrev.com/c/1340815

It's reverted as r609224, but builds after the revert still fail:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Win10/43312
Components: Tests>Flaky Blink>Layout
Owner: ----
Status: Untriaged (was: Assigned)
Relanding my patch in crrev.com/c/1347032

As the failure is due to flaky layout tree dump, adding Blink>Layout for re-triage...
Very unfortunate that the bot didn't do anything in 3 days (so it will be hard to track down the culprit), between build 43249 (fb485c335ced9fb2eaacd41d9c14aad982e5b4ea) and 43250 (eaf5778e5ca3aea9b5724e6d08d43780e2731482).

I suspect all we want here is a rebaseline. Looks like stuff has moved around by a pixel here and there. I see that things have happened to fonts during that period; e.g. 322b6dec12aa3822bba793c8fe69446b05ebd367 ("use new font api -- aa and subpixel no longer deprecated").
Cc: wangxianzhu@chromium.org
This looks like the one:
https://chromium-review.googlesource.com/c/chromium/src/+/1335007

Rebaseline tool messed things up?
I'll try to rebaseline again.
(and I guess the reason why the rebaseline tool messed things up was that the Win10 builder was offline?)
Owner: mstensho@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/270859edd7d8f0657d92ee4cae3d22550c6810ac

commit 270859edd7d8f0657d92ee4cae3d22550c6810ac
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Fri Nov 23 12:21:36 2018

Rebaseline printing/single-line-must-not-be-split-into-two-pages.html

Looks like something got wrong in
https://chromium-review.googlesource.com/c/chromium/src/+/1335007

TBR=wangxianzhu@chromium.org

Bug:  906591 
Change-Id: I9d0f19d74dc209994aa6ba335b92effee7abf685
Reviewed-on: https://chromium-review.googlesource.com/c/1349254
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610579}
[modify] https://crrev.com/270859edd7d8f0657d92ee4cae3d22550c6810ac/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/c83eae3cbf24f101ed085c753d45f291e7c27fef/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/single-line-must-not-be-split-into-two-pages-expected.txt
[rename] https://crrev.com/270859edd7d8f0657d92ee4cae3d22550c6810ac/third_party/WebKit/LayoutTests/platform/mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt
[rename] https://crrev.com/270859edd7d8f0657d92ee4cae3d22550c6810ac/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/printing/single-line-must-not-be-split-into-two-pages-expected.txt
[rename] https://crrev.com/270859edd7d8f0657d92ee4cae3d22550c6810ac/third_party/WebKit/LayoutTests/platform/win/printing/single-line-must-not-be-split-into-two-pages-expected.txt
[rename] https://crrev.com/270859edd7d8f0657d92ee4cae3d22550c6810ac/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/printing/single-line-must-not-be-split-into-two-pages-expected.txt
[delete] https://crrev.com/c83eae3cbf24f101ed085c753d45f291e7c27fef/third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/single-line-must-not-be-split-into-two-pages-expected.txt

Status: Fixed (was: Assigned)

Sign in to add a comment