New issue
Advanced search Search tips

Issue 906585 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Set flag owner and remove unused flags related to browsing_data

Project Member Reported by dullweber@chromium.org, Nov 19

Issue description

Some flags need owners, remove-navigation-history can be removed
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6aeff50d934da6eeaa022c42c6fb910154918127

commit 6aeff50d934da6eeaa022c42c6fb910154918127
Author: Christian Dullweber <dullweber@chromium.org>
Date: Mon Nov 19 14:44:24 2018

Add owners for browsing_data flags

Set owner for rewrite-leveldb-on-deletion and clear-old-browsing-data.
Remove remove-navigation-history flag.

Bug:  906585 
Change-Id: I36f931902d48eff7fd8ec3008970246d6318d3bd
Reviewed-on: https://chromium-review.googlesource.com/c/1341518
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609286}
[modify] https://crrev.com/6aeff50d934da6eeaa022c42c6fb910154918127/chrome/browser/about_flags.cc
[modify] https://crrev.com/6aeff50d934da6eeaa022c42c6fb910154918127/chrome/browser/flag-metadata.json
[modify] https://crrev.com/6aeff50d934da6eeaa022c42c6fb910154918127/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/6aeff50d934da6eeaa022c42c6fb910154918127/chrome/browser/flag_descriptions.h

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56608ee5157393aba1951ba4217bc0a842205702

commit 56608ee5157393aba1951ba4217bc0a842205702
Author: Christian Dullweber <dullweber@chromium.org>
Date: Mon Nov 19 16:36:55 2018

Remove browsing_data::features::kRemoveNavigationHistory

Navigation history removal was launched, so we don't need the
base::Feature any more.

Bug:  906585 
Change-Id: I772539f1ad49d41a3dd949907fb251d15d8a39cc
Reviewed-on: https://chromium-review.googlesource.com/c/1341991
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609327}
[modify] https://crrev.com/56608ee5157393aba1951ba4217bc0a842205702/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
[modify] https://crrev.com/56608ee5157393aba1951ba4217bc0a842205702/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/56608ee5157393aba1951ba4217bc0a842205702/chrome/browser/browsing_data/navigation_entry_remover.cc
[modify] https://crrev.com/56608ee5157393aba1951ba4217bc0a842205702/chrome/browser/browsing_data/navigation_entry_remover_browsertest.cc
[modify] https://crrev.com/56608ee5157393aba1951ba4217bc0a842205702/components/browsing_data/core/BUILD.gn
[delete] https://crrev.com/18260fbf9a9e00c25c38f3d6f870affbf36790c7/components/browsing_data/core/features.cc
[delete] https://crrev.com/18260fbf9a9e00c25c38f3d6f870affbf36790c7/components/browsing_data/core/features.h

Status: Fixed (was: Assigned)

Sign in to add a comment