New issue
Advanced search Search tips

Issue 906577 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ShareAndManageDialog/FilesAppBrowserTest.Test* failures

Project Member Reported by kolos@chromium.org, Nov 19

Issue description

Builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests

The first failure: 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9696

Failed tests:
ShareAndManageDialog/FilesAppBrowserTest.Test/shareDirectoryTeamDrive
ShareAndManageDialog/FilesAppBrowserTest.Test/manageDirectoryTeamDrive
ShareAndManageDialog/FilesAppBrowserTest.Test/manageHostedFileTeamDrive
ShareAndManageDialog/FilesAppBrowserTest.Test/manageFileTeamDrive
ShareAndManageDialog/FilesAppBrowserTest.Test/shareFileTeamDrive
ShareAndManageDialog/FilesAppBrowserTest.Test/shareHostedFileTeamDrive


 
Cc: noel@chromium.org
Components: Platform>Apps>FileManager
Labels: Files-Fixit-2018
Commone error cause: selectFile is failing.

----

"[unhandled-error]: Failed to select file "teamDriveAHostedDoc.gdoc"
Error: original stack
    at console.error.args [as error] (chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_scripts.js:54:19)
    at test.util.sync.selectFile (chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_scripts.js:8988:11)
    at Object.test.util.executeTestMessage (chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/runtime_loaded_test_util.js:648:47)
    at chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js:4592:24", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_scripts.js (57)
[3609:3609:1119/002518.449737:INFO:CONSOLE(0)] "[FAIL] [manageHostedFileTeamDrive]: selectFile failed

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ShareAndManageDialog%2FFilesAppBrowserTest.Test*

^^^ the new tests were also failing non ASAN, so a repro-ing locally should be easy peasy. 
Labels: OS-Chrome
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56de02ff65a1cd92adae922819e6c58ebbf42472

commit 56de02ff65a1cd92adae922819e6c58ebbf42472
Author: Sam McNally <sammc@chromium.org>
Date: Tue Nov 20 01:34:22 2018

Reland "Add tests for sharing and managing items in team drives."

This is a reland of 8fcafe0edcfa93257435a18072b5fa6d01858489

Wait for the file list to update before attempting to select its
contents.

Original change's description:
> Add tests for sharing and managing items in team drives.
>
> Bug:  903637 
> Change-Id: Ic9f49f7de59210e400a578060eb611fafebe193f
> Reviewed-on: https://chromium-review.googlesource.com/c/1341287
> Commit-Queue: Sam McNally <sammc@chromium.org>
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609191}

Bug:  903637 ,  906577 
Change-Id: Id6e2a1ab4eb4b0afb48c53c5cb6ea0e3b28bfa11
Reviewed-on: https://chromium-review.googlesource.com/c/1343399
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609549}
[modify] https://crrev.com/56de02ff65a1cd92adae922819e6c58ebbf42472/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/56de02ff65a1cd92adae922819e6c58ebbf42472/ui/file_manager/file_manager/background/js/test_util.js
[modify] https://crrev.com/56de02ff65a1cd92adae922819e6c58ebbf42472/ui/file_manager/integration_tests/file_manager/background.js
[modify] https://crrev.com/56de02ff65a1cd92adae922819e6c58ebbf42472/ui/file_manager/integration_tests/file_manager/share_and_manage_dialog.js
[modify] https://crrev.com/56de02ff65a1cd92adae922819e6c58ebbf42472/ui/file_manager/integration_tests/test_util.js

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment