Only used by BoringSSL [1, 2], but adds substantial complexity in CQ code. Removing it will make it easier to migrate to branch support. [1] https://boringssl.googlesource.com/All-Projects/+/b88d355093f891c842817c04f69a8eedb02d0a34/project.config [2] https://boringssl.googlesource.com/boringssl/+/master/infra/config/cq.cfg#7
BoringSSL config changes: * https://boringssl-review.googlesource.com/c/All-Projects/+/33269 * https://boringssl-review.googlesource.com/c/boringssl/+/33270
Removal from CQ: https://chrome-internal-review.googlesource.com/c/infra/infra_internal/+/718755
The following revision refers to this bug: https://boringssl.googlesource.com/boringssl/+/09f5a040d406f372fbed7d6a24728da80bbb84b3 commit 09f5a040d406f372fbed7d6a24728da80bbb84b3 Author: Andrii Shyshkalov <tandrii@google.com> Date: Mon Nov 19 16:59:05 2018 No longer set CQ-Verified label on CQ success/failure. R=davidben@google.com Bug: chromium:906576 Change-Id: I56b16a76fabe37822a1a7eb3f075a476f83818ea Reviewed-on: https://boringssl-review.googlesource.com/c/33270 Reviewed-by: David Benjamin <davidben@google.com> [modify] https://crrev.com/09f5a040d406f372fbed7d6a24728da80bbb84b3/infra/config/cq.cfg
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/797e3b393ad19d586aa43566efa4e3ffd825652a commit 797e3b393ad19d586aa43566efa4e3ffd825652a Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Nov 20 04:37:28 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/415c983fb24a2fd9e7c9138515e31f6d92be79f6 commit 415c983fb24a2fd9e7c9138515e31f6d92be79f6 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed Nov 21 00:45:29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b39cccfb917ee1fbab09d970bd41c4835e56c485 commit b39cccfb917ee1fbab09d970bd41c4835e56c485 Author: David Benjamin <davidben@chromium.org> Date: Tue Nov 27 19:40:53 2018 Roll src/third_party/boringssl/src f241a59dc..6965d2560 https://boringssl.googlesource.com/boringssl/+log/f241a59dcca617c5b9d9880a8a9fd92996a654be..6965d25602754bc419c5f757d008ba1f4da49ae4 The following commits have Chromium bugs associated: 4f746a907 Move ARM cpuinfo functions to the header. 09f5a040d No longer set CQ-Verified label on CQ success/failure. This additionally includes some manual follow-up tweaks to BUILD.gn for 4f746a907. Bug: 906576 , 907115 Change-Id: If066a9fdd873edbad773cc8db7a8aadd679f269b Reviewed-on: https://chromium-review.googlesource.com/c/1347096 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#611256} [modify] https://crrev.com/b39cccfb917ee1fbab09d970bd41c4835e56c485/DEPS [modify] https://crrev.com/b39cccfb917ee1fbab09d970bd41c4835e56c485/third_party/boringssl/BUILD.gn [modify] https://crrev.com/b39cccfb917ee1fbab09d970bd41c4835e56c485/third_party/boringssl/ios-aarch64/crypto/chacha/chacha-armv8.S [modify] https://crrev.com/b39cccfb917ee1fbab09d970bd41c4835e56c485/third_party/boringssl/ios-aarch64/crypto/fipsmodule/aesv8-armx64.S [modify] https://crrev.com/b39cccfb917ee1fbab09d970bd41c4835e56c485/third_party/boringssl/ios-aarch64/crypto/fipsmodule/sha1-armv8.S [modify] https://crrev.com/b39cccfb917ee1fbab09d970bd41c4835e56c485/third_party/boringssl/ios-aarch64/crypto/fipsmodule/sha256-armv8.S [modify] https://crrev.com/b39cccfb917ee1fbab09d970bd41c4835e56c485/third_party/boringssl/ios-aarch64/crypto/fipsmodule/sha512-armv8.S [modify] https://crrev.com/b39cccfb917ee1fbab09d970bd41c4835e56c485/third_party/boringssl/ios-arm/crypto/fipsmodule/aesv8-armx32.S [modify] https://crrev.com/b39cccfb917ee1fbab09d970bd41c4835e56c485/third_party/boringssl/linux-aarch64/crypto/chacha/chacha-armv8.S [modify] https://crrev.com/b39cccfb917ee1fbab09d970bd41c4835e56c485/third_party/boringssl/linux-aarch64/crypto/fipsmodule/aesv8-armx64.S [modify] https://crrev.com/b39cccfb917ee1fbab09d970bd41c4835e56c485/third_party/boringssl/linux-aarch64/crypto/fipsmodule/sha1-armv8.S [modify] https://crrev.com/b39cccfb917ee1fbab09d970bd41c4835e56c485/third_party/boringssl/linux-aarch64/crypto/fipsmodule/sha256-armv8.S [modify] https://crrev.com/b39cccfb917ee1fbab09d970bd41c4835e56c485/third_party/boringssl/linux-aarch64/crypto/fipsmodule/sha512-armv8.S [modify] https://crrev.com/b39cccfb917ee1fbab09d970bd41c4835e56c485/third_party/boringssl/linux-arm/crypto/fipsmodule/aesv8-armx32.S
Comment 1 by tandrii@chromium.org
, Nov 19