New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 906570 link

Starred by 1 user
Status: Fixed
Owner:
penghuang@chromium.org
Closed: Nov 23
Cc:
backer@chromium.org
█ manoranj...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : FPS meter is not seen in dev tools.

Reported by avsha...@etouch.net, Nov 19 
Chrome Version : 72.0.3615.0 (Official Build) b3d2a4297369aea42f2c1c68177b94cdaf8c6e43-refs/branch-heads/3615@{#1} 32/64 bit
OS : Mac(10.13.6, 10.13.1, 10.14.2), Windows 10 (Touch device)

What steps will reproduce the problem?
1. Launch chrome, navigate to any webpage (ex. https://www.youtube.com) and open dev tools.
2. In dev tools, press 'Esc' key to open 'drawer' and navigate to 'Rendering' tab.
3. Check 'FPS meter' checkbox and observe.

Actual Result : FPS meter is not seen in dev tools.

Expected Result : FPS meter should appear in dev tools after selecting 'FPS meter' checkbox in 'Rendering' tab.

This is a regression issue broken in M-72 and below is the bisect information:
Good Build : 72.0.3612.0 (Revision : 608631)
Bad Build : 72.0.3613.0 (Revision : 609067)

CHANGE-LOG URL:
https://chromium.googlesource.com/chromium/src/+log/c7bee6dc398fc221b66336a3bfd1b5aaaf440cbe..25718190ae3ed7f0648d5f7df3b04e096f9924d9

Suspect: https://chromium.googlesource.com/chromium/src/+/25718190ae3ed7f0648d5f7df3b04e096f9924d9

@ penghuang: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:

1. Unable to reproduce issue in Linux(14.04 LTS) and Windows (7,8,8.1,10) desktop machines.
2. Unable to repro issue in Dev build #72.0.3610.2

Thank you..!
Expected_Result.mov
9.7 MB View Download
Actual_Result.mov
12.0 MB View Download

Comment 1 by nyerramilli@chromium.org, Nov 19

Cc: manoranj...@chromium.org
Labels: ReleaseBlock-Stable
marking as RBS, please change if required

Comment 2 by penghuang@chromium.org, Nov 19

Status: Started (was: Assigned)

Comment 3 by penghuang@chromium.org, Nov 19 

Hey avshaikh@ Could you please open chrome://gpu page and copy the page content here? thanks.

Comment 4 by backer@chromium.org, Nov 19 

Note: you can enable this with --show-fps-counter flag.

I can't repro on OSX at 6fed33f99a5d2d35067c4cec0759209bfffcdb93 (fresh pull this morning). I even tried to --disable-gpu-rasterization

This is on a Mac Pro (Late 2013) running High Sierra (10.13.6)

Attached is chrome://gpu
chrome_gpu.txt
8.0 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7218ea22c535f59f4164fb0cfd0fa42cf2f66152

commit 7218ea22c535f59f4164fb0cfd0fa42cf2f66152
Author: Peng Huang <penghuang@chromium.org>
Date: Mon Nov 19 16:56:53 2018

Revert "Using PaintCanvas for HUD"

This reverts commit 25718190ae3ed7f0648d5f7df3b04e096f9924d9.

Reason for revert: It breaks FPS counter on Mac
https://bugs.chromium.org/p/chromium/issues/detail?id=906570

Original change's description:
> Using PaintCanvas for HUD
>
> To support OOPR, we need switch from SkCanvas to PaintCanvas which is for
> OOPR.
>
> Bug:  895568 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I94b5430c7ee8ed2f5140d352214ec43f2ff0f8ad
> Reviewed-on: https://chromium-review.googlesource.com/c/1286950
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Reviewed-by: enne <enne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609033}

TBR=penghuang@chromium.org,enne@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  895568 ,  906570 
Change-Id: I935de60977c0374139ae1eb22670d234f85e0df6
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1342049
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609333}
[modify] https://crrev.com/7218ea22c535f59f4164fb0cfd0fa42cf2f66152/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/7218ea22c535f59f4164fb0cfd0fa42cf2f66152/cc/layers/heads_up_display_layer_impl.h

Comment 6 by backer@chromium.org, Nov 19

Cc: backer@chromium.org

Comment 7 by avsha...@etouch.net, Nov 20 

Hi @penghuang,

Attaching a screenshots of chrome://gpu page from MacOS Mojave 10.14.2 Beta(18C48a). Thank you.
chrome::gpu_1.png
376 KB View Download
chrome::gpu_2.png
782 KB View Download
chrome::gpu_3.png
505 KB View Download
chrome::gpu_4.png
657 KB View Download

Comment 8 by avsha...@etouch.net, Nov 20

Labels: TE-Verified-M72 TE-Verified-72.0.3616.0
---------
Update :
---------
Verified above issue in latest Canary build #72.0.3616.0 on Mac(10.13.1, 10.13.6, 10.14.2) and Windows 10 (Touch) device and the issue is fixed. 
Now user is able to see FPS meter after enabling 'FPS meter' option in 'Rendering' tab, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference.

Thank you..!
Canary_behaviour.mov
11.7 MB View Download

Comment 9 by penghuang@chromium.org, Nov 22 

I am going to re-land the HUD CL(https://crrev.com/c/1348864) with a fix. Please let me know if the problem happens again. Thanks.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d087e98821e7bf15d27c5b0de0ff8d6743e7469

commit 3d087e98821e7bf15d27c5b0de0ff8d6743e7469
Author: Peng Huang <penghuang@chromium.org>
Date: Thu Nov 22 23:27:39 2018

Reland "Using PaintCanvas for HUD"


Original change's description:
> Revert "Using PaintCanvas for HUD"
> 
> This reverts commit 25718190ae3ed7f0648d5f7df3b04e096f9924d9.
> 
> Reason for revert: It breaks FPS counter on Mac
> https://bugs.chromium.org/p/chromium/issues/detail?id=906570
> 
> Original change's description:
> > Using PaintCanvas for HUD
> >
> > To support OOPR, we need switch from SkCanvas to PaintCanvas which is for
> > OOPR.
> >
> > Bug:  895568 
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: I94b5430c7ee8ed2f5140d352214ec43f2ff0f8ad
> > Reviewed-on: https://chromium-review.googlesource.com/c/1286950
> > Commit-Queue: Peng Huang <penghuang@chromium.org>
> > Reviewed-by: enne <enne@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#609033}
> 
> TBR=penghuang@chromium.org,enne@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug:  895568 ,  906570 
> Change-Id: I935de60977c0374139ae1eb22670d234f85e0df6
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/c/1342049
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Reviewed-by: Peng Huang <penghuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609333}

TBR=penghuang@chromium.org,enne@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  895568 ,  906570 
Change-Id: I65448fa5e72d1aa9bf79aa8513944f2ce953b91f
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1348864
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610501}
[modify] https://crrev.com/3d087e98821e7bf15d27c5b0de0ff8d6743e7469/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/3d087e98821e7bf15d27c5b0de0ff8d6743e7469/cc/layers/heads_up_display_layer_impl.h

Comment 11 by penghuang@chromium.org, Nov 23

Status: Fixed (was: Started)

Comment 12 by vineetha...@etouch.net, Nov 23

Labels: TE-Verified-72.0.3619.0
Update :

Rechecked the above issue on Mac(10.13.6, 10.13.1, 10.14.2), Windows 10(Touch device)OS with latest Canary version #72.0.3619.0 and the issue is fixed.

Kindly refer the attached screen cast.
Fixed_Behaviour.mov
3.9 MB View Download
►

Sign in to add a comment