[wasm] out of bounds trap handler for machOS x64 |
|
Issue descriptionA version of v8:5277 that's specific to macOS x64. We should support trap based out of bounds checks for Wasm on macOS x64.
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/9d5dd6dd1959d34e7f1890ee37fb312dbf4e3d84 commit 9d5dd6dd1959d34e7f1890ee37fb312dbf4e3d84 Author: Andreas Haas <ahaas@chromium.org> Date: Tue Nov 20 11:03:54 2018 [wasm] Adjust the traphandler implementation for MacOS In the chrome-side implementation I currently use the default trap handlers of V8, see https://crrev.com/c/1290955 Bug: chromium:906565 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I74c5a18c479ad1c69303d104ad4f040de436c4e7 Reviewed-on: https://chromium-review.googlesource.com/c/1282960 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#57636} [modify] https://crrev.com/9d5dd6dd1959d34e7f1890ee37fb312dbf4e3d84/BUILD.gn [modify] https://crrev.com/9d5dd6dd1959d34e7f1890ee37fb312dbf4e3d84/src/api.cc [modify] https://crrev.com/9d5dd6dd1959d34e7f1890ee37fb312dbf4e3d84/src/trap-handler/DEPS [modify] https://crrev.com/9d5dd6dd1959d34e7f1890ee37fb312dbf4e3d84/src/trap-handler/handler-inside-posix.cc [modify] https://crrev.com/9d5dd6dd1959d34e7f1890ee37fb312dbf4e3d84/src/trap-handler/handler-inside-posix.h [modify] https://crrev.com/9d5dd6dd1959d34e7f1890ee37fb312dbf4e3d84/src/trap-handler/handler-outside-posix.cc [modify] https://crrev.com/9d5dd6dd1959d34e7f1890ee37fb312dbf4e3d84/src/trap-handler/trap-handler.h
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bd4532934fcf25a548316d64a49064134e3250c commit 3bd4532934fcf25a548316d64a49064134e3250c Author: Andreas Haas <ahaas@chromium.org> Date: Wed Nov 21 07:45:42 2018 [v8][macosx] Use V8's default wasm trap handler on MacOS This CL enables WebAssembly trap handlers on MacOS. In this CL we use the default trap handler provided by V8. Bug: chromium:906565 Change-Id: I2d007da1a86ca05010a0a7bf830586767f19a24d Reviewed-on: https://chromium-review.googlesource.com/c/1290955 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#609942} [modify] https://crrev.com/3bd4532934fcf25a548316d64a49064134e3250c/chrome/test/v8/wasm_trap_handler_browsertest.cc [modify] https://crrev.com/3bd4532934fcf25a548316d64a49064134e3250c/content/renderer/render_process_impl.cc
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95179d373dd810ee09f4eeb5509df3a9c758261c commit 95179d373dd810ee09f4eeb5509df3a9c758261c Author: Andreas Haas <ahaas@chromium.org> Date: Mon Nov 26 12:25:14 2018 [v8][wasm] Enable testing of trap handlers on macOS WebAssembly trap handlers are about to be enabled in a field trial, see http://cl/222217200. R=jwd@chromium.org Bug: chromium:906565 Change-Id: Ibf9ffe707cc16c5d76f004f75f397627be6fcbb4 Reviewed-on: https://chromium-review.googlesource.com/c/1346089 Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#610827} [modify] https://crrev.com/95179d373dd810ee09f4eeb5509df3a9c758261c/testing/variations/fieldtrial_testing_config.json
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/caf7eccc6a8f030dba7f92bc36c1a28d2ce40942 commit caf7eccc6a8f030dba7f92bc36c1a28d2ce40942 Author: Andreas Haas <ahaas@chromium.org> Date: Wed Dec 12 11:03:27 2018 [v8][wasm] Fix naming of finch trial tests in fieldtrial_testing_config.json We have separate finch trials for the different platforms, so we should use the same trial names here. R=jwd@chromium.org Bug: chromium:906565, chromium:903736 Change-Id: Icc6ca6d9074239ca277ccdf0546234b3626ed282 Reviewed-on: https://chromium-review.googlesource.com/c/1367664 Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#615850} [modify] https://crrev.com/caf7eccc6a8f030dba7f92bc36c1a28d2ce40942/testing/variations/fieldtrial_testing_config.json |
|
►
Sign in to add a comment |
|
Comment 1 by ahaas@chromium.org
, Nov 19