New issue
Advanced search Search tips

Issue 906551 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 355145



Sign in to add a comment

<PasswordsSettingsTestCase.testManyPasswords>Disabled

Project Member Reported by mrsuyi@google.com, Nov 19

Issue description

PasswordsSettingsTestCase.testManyPasswords is failing on (ipad 5th gen ios 11.4.1).
It failed on this assertion every time:
https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm?rcl=e1d1f67d8f56f9f45b01db4d4f523dda21b05366&l=293

Not sure about the reason, cannot reproduce the failure locally.
 
Cc: -djean@chromium.org -javierrobles@chromium.org dvadym@chromium.org sczs@chromium.org
Components: UI>Browser>Passwords UI>Browser>Mobile>Settings
Owner: ----
Labels: -Pri-3 Test-Disabled Pri-1
Summary: <PasswordsSettingsTestCase.testManyPasswords>Disabled (was: PasswordsSettingsTestCase.testManyPasswords is failing.)
PasswordsSettingsTestCase.testManyPasswords is flaky on iPads. It's disabled on iPad by the CL(https://chromium-review.googlesource.com/c/chromium/src/+/1341828).
Labels: ReleaseBlock-Beta M-72
Status: Available (was: Untriaged)
Vadym: is it really P1 and Beta-blocker? If yes, who would be the best person to fix?
Owner: javierrobles@chromium.org
Status: Assigned (was: Available)
I'm not sure that this is a beta blocker, it looks that this is just failing test case. Anyway nobody from Password Manager team works on iOS UI now.

javierrobles@ could you please have a look at it? And probably assign the right owner?
Cc: vabr@chromium.org
Owner: rohitrao@chromium.org
I couldn't reproduce this locally. Everything worked fine in 3 different iPad simulators.

I don't think this is a blocker. Assigned to rohitrao@ who owns settings to make the call.

Also CC vabr@ who wrote the original test in case he has some input.
Blocking: 355145
I don't have any useful insights.
The assert means that an asynchronous query to PasswordStore took longer than 1 second to complete on the bots. If it does not fail on developer's machines, that's likely because they are too fast or their load too small compared to the bot.

(I am leaving my current team this week, so I'm unable to investigate this further.)
Cc: -vabr@chromium.org
vabr going hobby only -> reducing involvement.
Please contact me directly in urgent matters.
Per the doc linked below, disabled tests should be marked as RBB for the current milestone. First the engineer should determine if the bug is a product issue. If not a product issue and we are 2 weeks or less from stable cut in the current branch, the bug can be punted to M+1.
https://docs.google.com/document/d/11HC2PlIr4Gmv7ABi89g-7tWov9lZNj7KxGTjgdyXYAU/edit

It seems this might not be a product issue from c5. If not this can be punted to M73. If it is a product issue, we need to get working on this asap as the first M72 beta is this Wednesday.
Labels: -M-72 M-73
On my local machine this test also fails for iPhone simulator. However if I change the timeout for GetBlacklistLogins from 1s to 2s, it works fine.

I guess this is not a product issue, so punt it to M73.

Sign in to add a comment