Issue metadata
Sign in to add a comment
|
Shift-reload does not bypass service worker |
||||||||||||||||||||||
Issue descriptionhttps://jakearchibald.github.io/isserviceworkerready/demos/fetchevent/ "Hello world" is served by the service worker. If you shift-reload, you should not see "Hello world", as the service worker should be bypassed. In Chrome, you see "Hello world". This works as expected in Firefox.
,
Nov 20
I bisected: r502246: good r502251: bad https://chromium.googlesource.com/chromium/src/+log/681f2330ee8c799b5a3eafc13ed9ebf8080a6841..0dbded05ad0ba1c3d8388fd649130509ab97f07a PlzNavigate was enabled in r502251 So I think this was regressed by PlzNavigate. Humm, but why we didn't notice for 1 year...
,
Nov 20
Thanks for bisecting! Targeting 72 with Pri=2 since the regression is old.
,
Nov 20
The fix seems a few lines of codes. Created a CL: https://crrev.com/c/1343875
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b8807b1b9381d381923a551d7bd401775e04a48 commit 0b8807b1b9381d381923a551d7bd401775e04a48 Author: Makoto Shimazu <shimazu@chromium.org> Date: Tue Nov 20 14:34:29 2018 Make shift-reload bypass caches and service workers Reload type has two variants: RELOAD and RELOAD_BYPASSING_CACHE. PlzNavigate currently sets net::LOAD_NORMAL to load_flags and false to skip_service_worker as BeginNavigationParams, so RELOAD_BYPASSING_CACHE doesn't affect those. This CL tries to change those parameters according to the reload type. Bug: 906542 Change-Id: Ib2f9f645007966d86a694d54dccbb476ec0fb45d Reviewed-on: https://chromium-review.googlesource.com/c/1343875 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#609692} [modify] https://crrev.com/0b8807b1b9381d381923a551d7bd401775e04a48/content/browser/frame_host/navigation_request.cc
,
Nov 21
I'm going to add a test for that.
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd875022e2a68acaf095d00ba3ebbac16fedc381 commit fd875022e2a68acaf095d00ba3ebbac16fedc381 Author: Makoto Shimazu <shimazu@chromium.org> Date: Mon Nov 26 08:10:01 2018 Add browser tests for bypassing service workers when shift-reload Bug: 906542 Change-Id: I1b33376d5e07ed1725e3a5760d32a2837b4b83b4 Reviewed-on: https://chromium-review.googlesource.com/c/1345702 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610783} [modify] https://crrev.com/fd875022e2a68acaf095d00ba3ebbac16fedc381/content/browser/loader/reload_cache_control_browsertest.cc
,
Nov 26
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nekr.fab...@gmail.com
, Nov 19