Issue metadata
Sign in to add a comment
|
Regression:Date format in print header section is not proper when browser language is 'Arabic'.
Reported by
vineetha...@etouch.net,
Nov 19
|
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3614.0(Official Build)Revision 6f4234cd5420f5de68072d918372507165ca8fac-refs/branch-heads/3614@{#1}(32/64-bit) OS: Windows(7,8,8.1,10) What steps will reproduce the problem? 1. Launch chrome, change browser language to 'Arabic' and relaunch chrome. 2. Press 'Ctrl+P' to open print preview overlay. 3. Ensure that 'Headers and footers' checkbox is selected. 4. Observe the date format in the header section of the page preview. Actual Result : Date format in print header section is not proper when browser language is 'Arabic'. Expected Result: Date format(yyyy/mm/dd) in print header section should be proper when browser language is 'Arabic'. This is a regression issue broken in ‘M-69’ and below is the 'chromium bisect' information: Good Build : 69.0.3487.0 (Revision : 573575) Bad Build : 69.0.3488.0 (Revision : 574034) You are probably looking for a change made after 573649 (known good), but no later than 573650 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/4ea4214a59dfcd1fe8f2cda5b435b96a118ee1c9..e9126f1d03725c2ae97d524985971d66089eede3 Suspecting: https://chromium.googlesource.com/chromium/src/+/e9126f1d03725c2ae97d524985971d66089eede3 @jshin: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly refer the attached screen-cast. Note: 1.Tried per revision bisect on Windows OS but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect" error, hence, providing chromium bisect. 2.Issue is also reproducible on Stable build #70.0.3538.102, Beta build #71.0.3578.53 and Dev build #72.0.3610.2 Thank you
,
Nov 21
Update : @rbpotter: Could you kindly take a look at the above issue. Thanks
,
Nov 22
> The format assumes that it's in the overall RTL direction The paragraph direction has to be set to RTL before adding formatted date in print-preview. If the paragraph direction is in RTL, the date format would come out correctly.
,
Nov 28
Presumably that's in components/printing/resources/print_header_footer_template_page.html
,
Nov 28
This is not a localization bug (can't be fixed by our linguists). Removing the component.
,
Nov 28
,
Nov 29
> Arabic locale data changed and it began to use European digits instead of Arabic digits. FYI, some Arabic locale variants use Arabic digits (e.g. ar-EG). With newly added locale variant support, for instance, ar-EG may not be affected by this bug.
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8edccce7e279612ab424b59899e43cee6db36169 commit 8edccce7e279612ab424b59899e43cee6db36169 Author: Lei Zhang <thestig@chromium.org> Date: Tue Dec 04 01:14:31 2018 Correctly display RTL dates in Print Preview. Use the locale's RTL direction in Print Preview's header/footer template. Bug: 906521 Change-Id: I97d2f8d30be8bfe26f4260df05fe26138655c487 Reviewed-on: https://chromium-review.googlesource.com/c/1354568 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#613370} [modify] https://crrev.com/8edccce7e279612ab424b59899e43cee6db36169/components/printing/renderer/print_render_frame_helper.cc [modify] https://crrev.com/8edccce7e279612ab424b59899e43cee6db36169/components/printing/resources/print_header_footer_template_page.html
,
Dec 4
This is fixed. I'll follow up with some native speakers to see if they prefer the date as is or in Arabic.
,
Dec 21
I filed bug 917535 for discussion on localized dates. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by js...@chromium.org
, Nov 19