New issue
Advanced search Search tips
Starred by 7 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 860058



Sign in to add a comment
link

Issue 906508: Implement new App Management UI

Reported by calamity@chromium.org, Nov 19 Project Member

Issue description

This is a tracker bug for work on the new chrome://apps App Management UI.
 

Comment 1 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9231a22ff22d1cb03bb219f579349a242bd26df8

commit 9231a22ff22d1cb03bb219f579349a242bd26df8
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Nov 19 08:28:02 2018

[App Management] Add skeleton for App Management WebUI.

This CL adds a WebUI for App Management that replaces chrome://apps
when the feature NewAppManagement is enabled. This involves:
- adding the feature
- adding a new MojoWebUIController
- adding a mojom, and its C++ handler
- adding a skeleton HTML and Polymer 'app' element
- adding a BrowserProxy which connects the Renderer JS to the backend C++.

Bug: 906508
Change-Id: Iac5be9ce82dc2cb0b1c77301ca43ccf7a99f318f
Reviewed-on: https://chromium-review.googlesource.com/c/1309380
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609204}
[modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/BUILD.gn
[modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/browser_resources.grd
[modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/BUILD.gn
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/app_management/BUILD.gn
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/app_management/OWNERS
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/app_management/app.html
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/app_management/app.js
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/app_management/browser_proxy.html
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/app_management/browser_proxy.js
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/app_management/index.html
[modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/app_management/BUILD.gn
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/app_management/OWNERS
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/app_management/app_management.mojom
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/app_management/app_management_page_handler.cc
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/app_management/app_management_page_handler.h
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/app_management/app_management_ui.cc
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/app_management/app_management_ui.h
[modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/common/chrome_features.cc
[modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/common/chrome_features.h
[modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/test/BUILD.gn
[modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/test/data/webui/BUILD.gn
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/test/data/webui/app_management/app_management_browsertest.js
[add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/test/data/webui/app_management/app_test.js
[modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/testing/buildbot/filters/webui_polymer2_browser_tests.filter

Comment 2 by dpa...@chromium.org, Nov 19

Could you use a different component, instead of "UI>Browser>WebUI". That component is meant to capture issues that span multiple WebUI pages, and not be a catch-all component for any WebUI page that does not have its own component.

Comment 3 by calamity@chromium.org, Nov 20

Cc: -dominickn@google.com dominickn@chromium.org
Components: -UI>Browser>WebUI
#2: Removed.

Comment 6 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be2a6c46ff867eec74b7f338a849ef67a86fc546

commit be2a6c46ff867eec74b7f338a849ef67a86fc546
Author: Reka Norman <rekanorman@google.com>
Date: Fri Dec 07 02:00:31 2018

[App Management] Add app list

This CL adds a list of apps to the main view of the app management page.

Bug: 906508

Change-Id: If6d22ad1d9851d3ce5387027da585005a7987c63
Reviewed-on: https://chromium-review.googlesource.com/c/1360199
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Reka Norman <rekanorman@google.com>
Cr-Commit-Position: refs/heads/master@{#614576}
[modify] https://crrev.com/be2a6c46ff867eec74b7f338a849ef67a86fc546/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/be2a6c46ff867eec74b7f338a849ef67a86fc546/chrome/browser/resources/app_management/main_view.html
[modify] https://crrev.com/be2a6c46ff867eec74b7f338a849ef67a86fc546/chrome/browser/resources/app_management/main_view.js

Comment 7 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac15854074f0838812e75aae06ff372e75085127

commit ac15854074f0838812e75aae06ff372e75085127
Author: Cecilia Ni <ceciliani@google.com>
Date: Mon Dec 10 03:32:34 2018

[App Management] Add OWNERS for strings

Bug: 906508
Change-Id: I91754c8888af86aca0be18e274b96b803948c5ce
Reviewed-on: https://chromium-review.googlesource.com/c/1367080
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615038}
[modify] https://crrev.com/ac15854074f0838812e75aae06ff372e75085127/chrome/app/OWNERS

Comment 9 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22363333c25c9f1751fa2322a0b42331063c9a3d

commit 22363333c25c9f1751fa2322a0b42331063c9a3d
Author: Melissa Zhang <melzhang@google.com>
Date: Tue Dec 11 02:00:13 2018

Implement App Struct and Pass Apps to AppManagement

This CL defines the app struct and gives apps from the user's profile to
AppManagement. It also informs the AppManagement UI of any updates to apps,
including uninstallation.

BUG=906508

Change-Id: I20f1483563d8252c1060212dbbfd9cb9d560f790
Reviewed-on: https://chromium-review.googlesource.com/c/1365090
Commit-Queue: Melissa Zhang <melzhang@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615380}
[modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/BUILD.gn
[modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/browser_resources.grd
[modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/resources/app_management/browser_proxy.html
[modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/webui/DEPS
[modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/webui/app_management/BUILD.gn
[modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/webui/app_management/app_management.mojom
[modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/webui/app_management/app_management_page_handler.cc
[modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/webui/app_management/app_management_page_handler.h
[modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/webui/app_management/app_management_ui.cc
[modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/mojo/public/tools/bindings/generators/mojom_js_generator.py

Comment 10 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3a875162fadbd939162dd1bf0e1753a212815e5

commit a3a875162fadbd939162dd1bf0e1753a212815e5
Author: Reka Norman <rekanorman@google.com>
Date: Tue Dec 11 07:45:29 2018

[App Management] Fix FakePageHandler

This CL updates the FakePageHandler to use generated Mojo types.

Bug: 906508
Change-Id: Ib04a9118e7ad7de6ac1aa9dfdf2d232c3280034a
Reviewed-on: https://chromium-review.googlesource.com/c/1370232
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615454}
[modify] https://crrev.com/a3a875162fadbd939162dd1bf0e1753a212815e5/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/a3a875162fadbd939162dd1bf0e1753a212815e5/chrome/browser/resources/app_management/main_view.html

Comment 11 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bbb0ffe91f106092814dfc7018f28e8756507af

commit 9bbb0ffe91f106092814dfc7018f28e8756507af
Author: Reka Norman <rekanorman@google.com>
Date: Wed Dec 12 23:25:44 2018

[App Management] Make bookmarks store generic

This CL moves the data store and store client from bookmarks into cr.ui
and makes them generic so that they can be used by other pages.

Bug: 906508
Change-Id: I578a3e0b308b1d21ad412cf8be7e08db3b402469
Reviewed-on: https://chromium-review.googlesource.com/c/1369444
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616101}
[modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/app_management/main_view.html
[modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/BUILD.gn
[modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/actions.js
[modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/api_listener.js
[modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/store.html
[modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/store.js
[modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/store_client.html
[modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/store_client.js
[modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/types.js
[modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/test/data/webui/md_bookmarks/test_store.js
[add] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/ui/webui/resources/html/cr/ui/store.html
[add] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/ui/webui/resources/html/cr/ui/store_client.html
[modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/ui/webui/resources/js/cr/ui/BUILD.gn
[add] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/ui/webui/resources/js/cr/ui/store.js
[add] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/ui/webui/resources/js/cr/ui/store_client.js
[modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/ui/webui/resources/webui_resources.grd

Comment 12 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75

commit 45dbfb9cd0326e7fc786445e7a8c62aba11e8e75
Author: Cecilia Ni <ceciliani@google.com>
Date: Thu Dec 13 01:52:06 2018

[App Management] Refactor main view

This CL adds an app-management-item element, and creates shared constants,
css and vars files.

Bug: 906508
Change-Id: I29dce3a6745e8957ee1fb547cbe2e72290567f28
Reviewed-on: https://chromium-review.googlesource.com/c/1371308
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616156}
[modify] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/browser_resources.grd
[modify] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/constants.js
[add] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/item.html
[add] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/item.js
[modify] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/main_view.html
[modify] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/main_view.js
[add] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/shared_style.html
[add] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/shared_vars.html
[modify] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/ui/webui/app_management/app_management_ui.cc

Comment 13 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/124d0d419086705a616b1039fb63067679886069

commit 124d0d419086705a616b1039fb63067679886069
Author: Reka Norman <rekanorman@google.com>
Date: Thu Dec 13 04:46:45 2018

[App Management] Add app management Store.

This CL implements the app management Store and StoreClient, and adds
an action and a reducer to handle the onAppsAdded event.

Bug: 906508
Change-Id: I8bd4635ae7048e862f378c41cb63b9fe1e3342c6
Reviewed-on: https://chromium-review.googlesource.com/c/1371304
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616216}
[modify] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/browser_resources.grd
[modify] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/BUILD.gn
[add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/actions.html
[add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/actions.js
[modify] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/app.html
[modify] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/app.js
[modify] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/fake_page_handler.js
[add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/reducers.html
[add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/reducers.js
[add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/store.html
[add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/store.js
[add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/store_client.html
[add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/store_client.js
[add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/types.js
[add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/util.html
[add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/util.js
[modify] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/ui/webui/app_management/app_management_ui.cc
[modify] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/test/data/webui/app_management/app_management_browsertest.js
[add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/test/data/webui/app_management/reducers_test.js

Comment 14 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5deb7d1b14ba1cfa12428d3de3e3439ca1656df

commit d5deb7d1b14ba1cfa12428d3de3e3439ca1656df
Author: Melissa Zhang <melzhang@google.com>
Date: Thu Dec 13 23:39:26 2018

Add Fields to App Struct

This CL adds optional fields to the app struct.

BUG=906508

Change-Id: I6fd79a95813d2c2d022c051de869b827178b251a
Reviewed-on: https://chromium-review.googlesource.com/c/1375192
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Melissa Zhang <melzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#616491}
[modify] https://crrev.com/d5deb7d1b14ba1cfa12428d3de3e3439ca1656df/chrome/browser/ui/webui/app_management/app_management.mojom
[modify] https://crrev.com/d5deb7d1b14ba1cfa12428d3de3e3439ca1656df/chrome/browser/ui/webui/app_management/app_management_page_handler.cc

Comment 15 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30f0df7d4ffca78defe7cf131eca562c2e6d358e

commit 30f0df7d4ffca78defe7cf131eca562c2e6d358e
Author: Reka Norman <rekanorman@google.com>
Date: Thu Dec 13 23:45:09 2018

[App Management] Make main view a StoreClient.

This CL makes the app management main view a StoreClient, so that its
list of apps is linked to the apps in the Store.

Bug: 906508
Change-Id: Icb1c9755ced7a1bb8ed5e96bc12e7ecec1d87f42
Reviewed-on: https://chromium-review.googlesource.com/c/1372973
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616498}
[modify] https://crrev.com/30f0df7d4ffca78defe7cf131eca562c2e6d358e/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/30f0df7d4ffca78defe7cf131eca562c2e6d358e/chrome/browser/resources/app_management/main_view.html
[modify] https://crrev.com/30f0df7d4ffca78defe7cf131eca562c2e6d358e/chrome/browser/resources/app_management/main_view.js

Comment 16 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8537b53afdaab28cdad6f09de652102a90bd4cc

commit f8537b53afdaab28cdad6f09de652102a90bd4cc
Author: Reka Norman <rekanorman@google.com>
Date: Fri Dec 14 01:33:01 2018

[App Management] Add onAppChanged and onAppRemoved listeners.

This CL adds actions and reducers to handle the onAppChanged and
onAppRemoved events, as well as tests for these reducers.

Bug: 906508
Change-Id: I7b809e1030f33ea772a8d74343b45189f199f1fe
Reviewed-on: https://chromium-review.googlesource.com/c/1375290
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616549}
[modify] https://crrev.com/f8537b53afdaab28cdad6f09de652102a90bd4cc/chrome/browser/resources/app_management/actions.js
[modify] https://crrev.com/f8537b53afdaab28cdad6f09de652102a90bd4cc/chrome/browser/resources/app_management/app.js
[modify] https://crrev.com/f8537b53afdaab28cdad6f09de652102a90bd4cc/chrome/browser/resources/app_management/reducers.js
[modify] https://crrev.com/f8537b53afdaab28cdad6f09de652102a90bd4cc/chrome/test/data/webui/app_management/reducers_test.js

Comment 17 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06c0f4533cd4607334fe101cc74d04752cde1516

commit 06c0f4533cd4607334fe101cc74d04752cde1516
Author: Reka Norman <rekanorman@google.com>
Date: Fri Dec 14 03:26:08 2018

[App Management] Make TestStore generic.

This CL makes the bookmarks TestStore generic, so that it can be
extended to create test stores for different store implementation
classes.

Bug: 906508
Change-Id: I80831d93c747e7b8964e3630719549277b9a0618
Reviewed-on: https://chromium-review.googlesource.com/c/1372969
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616573}
[modify] https://crrev.com/06c0f4533cd4607334fe101cc74d04752cde1516/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js
[modify] https://crrev.com/06c0f4533cd4607334fe101cc74d04752cde1516/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js
[modify] https://crrev.com/06c0f4533cd4607334fe101cc74d04752cde1516/chrome/test/data/webui/md_bookmarks/test_store.js
[add] https://crrev.com/06c0f4533cd4607334fe101cc74d04752cde1516/chrome/test/data/webui/test_store.js

Comment 18 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975

commit b9c63b5aaa586626f3a2a47ced4ff516b5b0a975
Author: Cecilia Ni <ceciliani@google.com>
Date: Tue Dec 18 08:45:58 2018

[App Management] Add Permission Page for PWA

This CL adds a permissions page for PWAs. It also cleans up and
rationalizes all the HTML/CSS for App Management.

Bug: 906508
Change-Id: I806f7269958cc83e4f9112d307f679ef0d300e05
Reviewed-on: https://chromium-review.googlesource.com/c/1373931
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Cr-Commit-Position: refs/heads/master@{#617418}
[modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/app/app_management_strings.grdp
[modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/browser_resources.grd
[modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/app.html
[modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/item.html
[modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/main_view.html
[modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/main_view.js
[add] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/pwa_permission_view.html
[add] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/pwa_permission_view.js
[modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/shared_style.html
[modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/shared_vars.html
[modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/ui/webui/app_management/app_management_ui.cc

Comment 19 by bugdroid1@chromium.org, Dec 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa61f5797f69e60c601ed237e99cee2222af72c7

commit fa61f5797f69e60c601ed237e99cee2222af72c7
Author: Cecilia Ni <ceciliani@google.com>
Date: Wed Dec 19 09:10:42 2018

[App Management] Add Test for Main View

This CL sets up tests for the main view of the App Management page. It
also refactors the backend listeners into their own api_listener.js.

Bug: 906508
Change-Id: I2a0d809ddf71e559312d031c1d34d60bede45f89
Reviewed-on: https://chromium-review.googlesource.com/c/1373274
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617775}
[modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/browser_resources.grd
[modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/BUILD.gn
[add] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/api_listener.html
[add] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/api_listener.js
[modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/app.html
[modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/app.js
[modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/browser_proxy.html
[modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/browser_proxy.js
[modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/main_view.html
[modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/ui/webui/app_management/app_management_ui.cc
[modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/test/data/webui/app_management/app_management_browsertest.js
[add] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/test/data/webui/app_management/main_view_test.js

Comment 20 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c5300bd86737e8c45e60cb6ee2f7320d4437300

commit 0c5300bd86737e8c45e60cb6ee2f7320d4437300
Author: Reka Norman <rekanorman@google.com>
Date: Thu Dec 20 07:44:30 2018

[App Management] Add router.

This CL sets up routing for the app management page. It also adds an
action and a reducer to handle changing to a different subpage within
the app management page.

Bug: 906508
Change-Id: I5b877cc7aed66c7626045d08066bac9ccc59b5d2
Reviewed-on: https://chromium-review.googlesource.com/c/1381356
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Reka Norman <rekanorman@google.com>
Cr-Commit-Position: refs/heads/master@{#618133}
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/browser_resources.grd
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/actions.js
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/api_listener.js
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/app.html
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/constants.js
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/index.html
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/item.html
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/item.js
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/main_view.html
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/pwa_permission_view.html
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/reducers.js
[add] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/router.html
[add] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/router.js
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/store.html
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/store_client.html
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/types.js
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/util.js
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/ui/webui/app_management/app_management_ui.cc
[modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/test/data/webui/app_management/reducers_test.js

Comment 21 by bugdroid1@chromium.org, Dec 27

Project Member

Comment 22 by bugdroid1@chromium.org, Dec 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f09a3f4eefbd31e4938f5ef679607ba1ff79490

commit 3f09a3f4eefbd31e4938f5ef679607ba1ff79490
Author: Cecilia Ni <ceciliani@google.com>
Date: Fri Dec 28 07:08:50 2018

[App Management] Add chrome permission view

This CL sets up the permission view of native chrome apps.

Bug: 906508

Change-Id: Ic4996adf9b963a15c58db582d644f0c5441def56
Reviewed-on: https://chromium-review.googlesource.com/c/1388046
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Cr-Commit-Position: refs/heads/master@{#619128}
[modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/browser_resources.grd
[modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/app.html
[add] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/chrome_app_permission_view.html
[add] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/chrome_app_permission_view.js
[modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/item.js
[modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/pwa_permission_view.html
[modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/pwa_permission_view.js
[modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/shared_style.html
[modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/util.js
[modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/ui/webui/app_management/app_management_ui.cc

Comment 23 by bugdroid1@chromium.org, Jan 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c

commit ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c
Author: Cecilia Ni <ceciliani@google.com>
Date: Wed Jan 02 04:00:30 2019

[App Management] Add Metadata View

This CL sets up metadata view for chrome permission view and pwa permission view.

Bug: 906508
Change-Id: I81d4ed5b1946ede773a802809ef27e945bd3a4ef
Reviewed-on: https://chromium-review.googlesource.com/c/1390777
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619366}
[modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/app/app_management_strings.grdp
[modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/browser_resources.grd
[modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/resources/app_management/chrome_app_permission_view.html
[modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/resources/app_management/main_view.html
[add] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/resources/app_management/metadata_view.html
[add] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/resources/app_management/metadata_view.js
[modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/resources/app_management/pwa_permission_view.html
[modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/ui/webui/app_management/app_management_ui.cc

Comment 24 by bugdroid1@chromium.org, Jan 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29ac4289d27a7510d2ff15f94aa2f716be673bfc

commit 29ac4289d27a7510d2ff15f94aa2f716be673bfc
Author: Reka Norman <rekanorman@google.com>
Date: Thu Jan 03 06:23:09 2019

[App Management] Add permissions to fake backend.

This CL adds a permissions map to the app struct used by the fake
backend, and allows these permissions to be toggled in the PWA
permission view.

Bug: 906508
Change-Id: I292671d5f4fa9034fac10eba421380aaef8367ad
Reviewed-on: https://chromium-review.googlesource.com/c/1388128
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Reka Norman <rekanorman@google.com>
Cr-Commit-Position: refs/heads/master@{#619596}
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/app/app_management_strings.grdp
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/browser_resources.grd
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/app.html
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/app.js
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/browser_proxy.js
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/constants.js
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/item.js
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/main_view.js
[add] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/permission_item.html
[add] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/permission_item.js
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/pwa_permission_view.html
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/pwa_permission_view.js
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/reducers.js
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/shared_style.html
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/types.js
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/util.js
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/ui/webui/app_management/app_management.mojom
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/ui/webui/app_management/app_management_ui.cc
[modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/test/data/webui/app_management/reducers_test.js

Comment 25 by bugdroid1@chromium.org, Jan 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd17ee6680529b13d3da1a1fc72b2822f0ef873a

commit fd17ee6680529b13d3da1a1fc72b2822f0ef873a
Author: Cecilia Ni <ceciliani@google.com>
Date: Fri Jan 04 06:25:56 2019

[App Management] Refactor permission-view-header to a new element

This CL extracts permission view header from chrome app permission view and pwa permission view to avoid duplicate code.

Bug: 906508
Change-Id: If4335bf7fcf70ec2b5d429f1b632c66839ec6853
Reviewed-on: https://chromium-review.googlesource.com/c/1393127
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Cr-Commit-Position: refs/heads/master@{#619891}
[modify] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/browser_resources.grd
[modify] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/resources/app_management/chrome_app_permission_view.html
[modify] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/resources/app_management/chrome_app_permission_view.js
[add] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/resources/app_management/permission_view_header.html
[add] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/resources/app_management/permission_view_header.js
[modify] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/resources/app_management/pwa_permission_view.html
[modify] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/resources/app_management/shared_style.html
[modify] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/ui/webui/app_management/app_management_ui.cc

Comment 26 by bugdroid1@chromium.org, Jan 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba1b5893f90c959be73406a3d0b72b6fa13608de

commit ba1b5893f90c959be73406a3d0b72b6fa13608de
Author: Reka Norman <rekanorman@google.com>
Date: Fri Jan 04 06:45:57 2019

[App Management] GetApps returns array of initial apps.

This CL changes the GetApps function of the app management PageHandler
to return the initial apps directly rather than calling onAppsAdded,
which simplifies initialisation of the ApiListener. It also changes
the onAppsAdded function to onAppAdded.

Bug: 906508
Change-Id: I649530920dfcce9d3998d9b2eda0320244ced15c
Reviewed-on: https://chromium-review.googlesource.com/c/1393587
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619894}
[modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/browser/resources/app_management/actions.js
[modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/browser/resources/app_management/api_listener.js
[modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/browser/resources/app_management/reducers.js
[modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/browser/ui/webui/app_management/app_management.mojom
[modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/browser/ui/webui/app_management/app_management_page_handler.cc
[modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/browser/ui/webui/app_management/app_management_page_handler.h
[modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/test/data/webui/app_management/app_test.js
[modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/test/data/webui/app_management/main_view_test.js
[modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/test/data/webui/app_management/reducers_test.js

Comment 27 by bugdroid1@chromium.org, Jan 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a95575e09470671206e8f43de340d524badab5d

commit 8a95575e09470671206e8f43de340d524badab5d
Author: Reka Norman <rekanorman@google.com>
Date: Sun Jan 06 23:42:48 2019

[App Management] Link chrome apps permission view to store.

This CL links the chrome apps permission view to data from the store,
so that it is only displayed when a chrome app is selected from the
list of apps.

Bug: 906508
Change-Id: I30608461bb70f5258e6f5b28ab80bf04603b444c
Reviewed-on: https://chromium-review.googlesource.com/c/1394105
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620234}
[modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/app.html
[modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/app.js
[modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/browser_proxy.js
[modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/chrome_app_permission_view.html
[modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/chrome_app_permission_view.js
[modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/permission_view_header.html
[modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/permission_view_header.js
[modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/pwa_permission_view.js

Comment 28 by bugdroid1@chromium.org, Jan 8

Project Member

Comment 29 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8

commit 5faf8294117a46b977dccf7ff6bd7dc94f19ddf8
Author: Reka Norman <rekanorman@google.com>
Date: Fri Jan 11 05:34:42 2019

[App Management] Link UI to backend permissions.

This CL updates the front end of the app management page to use the
real Permission struct, and links the UI components to the backend
SetPermission method, allowing the permissions of real apps to be
toggled from the UI.

Bug: 906508
Change-Id: Ia401df34e138893d8186c67413588aafdadafc19
Reviewed-on: https://chromium-review.googlesource.com/c/1404538
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Reka Norman <rekanorman@google.com>
Cr-Commit-Position: refs/heads/master@{#621917}
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/app.js
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/browser_proxy.js
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/constants.js
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/index.html
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/metadata_view.js
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/permission_item.html
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/permission_item.js
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/permission_view_header.js
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/pwa_permission_view.html
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/types.js
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/util.js
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/ui/webui/app_management/app_management.mojom
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/ui/webui/app_management/app_management_page_handler.cc
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/services/app_service/public/mojom/types.mojom
[modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/test/data/webui/app_management/app_management_browsertest.js

Comment 30 by bugdroid1@chromium.org, Jan 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83b2e6e78de756204516bac99dc01c9aaa9fb42a

commit 83b2e6e78de756204516bac99dc01c9aaa9fb42a
Author: Reka Norman <rekanorman@google.com>
Date: Sun Jan 13 23:13:06 2019

[App Management] Implement App Service updates for installation/uninstallation of extensions.

This CL implements the OnExtensionInstalled and OnExtensionUninstalled
methods of the ExtensionApps App Service publisher, so that updates are
sent to the App Service subscribers. This allows live updates to be
observed when apps are installed or uninstalled in the UI.

Bug: 906508
Change-Id: Ic14b7f1b49ccfd77e9f90fe2956dfa4c09af069b
Reviewed-on: https://chromium-review.googlesource.com/c/1404547
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Reka Norman <rekanorman@google.com>
Cr-Commit-Position: refs/heads/master@{#622361}
[modify] https://crrev.com/83b2e6e78de756204516bac99dc01c9aaa9fb42a/chrome/browser/apps/app_service/extension_apps.cc
[modify] https://crrev.com/83b2e6e78de756204516bac99dc01c9aaa9fb42a/chrome/browser/apps/app_service/extension_apps.h

Comment 31 by bugdroid1@chromium.org, Jan 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/481af38cb355bc279458dd9838e19ab1b99709d0

commit 481af38cb355bc279458dd9838e19ab1b99709d0
Author: Reka Norman <rekanorman@google.com>
Date: Mon Jan 14 03:08:38 2019

[App Management] Implement the App Service Uninstall method for extensions.

This CL implements the Uninstall method for the ExtensionApps App
Service publisher, and links the UI to this method through the
App Service, allowing extensions to be uninstalled in response to UI
events.

Bug: 906508
Change-Id: I7108e5b3d6f684b80fe996b720c75a7af3a318bc
Reviewed-on: https://chromium-review.googlesource.com/c/1405150
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Commit-Queue: Reka Norman <rekanorman@google.com>
Cr-Commit-Position: refs/heads/master@{#622376}
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/app_service_proxy.cc
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/app_service_proxy.h
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/arc_apps.cc
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/arc_apps.h
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/built_in_chromeos_apps.cc
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/built_in_chromeos_apps.h
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/extension_apps.cc
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/extension_apps.h
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/resources/app_management/permission_view_header.js
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/ui/webui/app_management/app_management.mojom
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/ui/webui/app_management/app_management_page_handler.cc
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/ui/webui/app_management/app_management_page_handler.h
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/services/app_service/app_service_impl.cc
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/services/app_service/app_service_impl.h
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/services/app_service/app_service_impl_unittest.cc
[modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/services/app_service/public/mojom/app_service.mojom

Comment 32 by bugdroid1@chromium.org, Jan 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b08ccf5d915dc85a541e00d28fadf3105efb595e

commit b08ccf5d915dc85a541e00d28fadf3105efb595e
Author: Reka Norman <rekanorman@google.com>
Date: Mon Jan 14 04:09:48 2019

[App Management] Implement the OpenNativeSettings App Service method for extensions.

This CL implements the OpenNativeSettings method for the ExtensionApps
App Service publisher. For now, it supports two types of extensions:
for hosted apps, it opens the corresponding site settings page; for the
Chrome Apps which appear on the chrome://extensions page, it opens the
extensions detail page for that app.

Bug: 906508
Change-Id: I6f5cee42d9f909e3c24bbecd91b5fe8d37923338
Reviewed-on: https://chromium-review.googlesource.com/c/1405112
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622381}
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/app_service_proxy.cc
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/app_service_proxy.h
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/arc_apps.cc
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/arc_apps.h
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/built_in_chromeos_apps.cc
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/built_in_chromeos_apps.h
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/extension_apps.cc
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/extension_apps.h
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/resources/app_management/pwa_permission_view.html
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/resources/app_management/pwa_permission_view.js
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/ui/webui/app_management/app_management.mojom
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/ui/webui/app_management/app_management_page_handler.cc
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/ui/webui/app_management/app_management_page_handler.h
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/services/app_service/app_service_impl.cc
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/services/app_service/app_service_impl.h
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/services/app_service/app_service_impl_unittest.cc
[modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/services/app_service/public/mojom/app_service.mojom

Comment 33 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0059f6285bc1f26b933d932ef459f8c0174acc5a

commit 0059f6285bc1f26b933d932ef459f8c0174acc5a
Author: Cecilia Ni <ceciliani@google.com>
Date: Tue Jan 15 05:34:13 2019

[App Management] Add Chrome App Permission Mapping

This CL makes chrome app permission view display the actual permissions
strings in an unordered list by fetching permission messages from
extension registry.

Bug: 906508
Change-Id: If936131faa4f622ea98d42208f0fa5a90c469ec7
Reviewed-on: https://chromium-review.googlesource.com/c/1404539
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Cr-Commit-Position: refs/heads/master@{#622744}
[modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/resources/app_management/chrome_app_permission_view.html
[modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/resources/app_management/chrome_app_permission_view.js
[modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/resources/app_management/main_view.js
[modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/resources/app_management/permission_item.js
[modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/resources/app_management/types.js
[modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/ui/webui/app_management/app_management.mojom
[modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/ui/webui/app_management/app_management_page_handler.cc
[modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/ui/webui/app_management/app_management_page_handler.h
[modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/ui/webui/app_management/app_management_ui.cc

Comment 34 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5235b08f05b13b6b7e81a748824358f5be8447d8

commit 5235b08f05b13b6b7e81a748824358f5be8447d8
Author: Reka Norman <rekanorman@google.com>
Date: Thu Jan 17 02:19:11 2019

[App Management] Implement Pin to Shelf.

This CL implements pinning apps to the shelf from the app management
page, by making the PageHandler a ShelfModelObserver. Since the shelf
only exists on Chrome OS, this required creating a Chrome OS specific
subclass of the the PageHandler (AppManagementPageHandlerCros) to
handle the shelf-related functionality.

Bug: 906508
Change-Id: I135c0aab5c1ffaaa76e9d1f094c880ab53cd7562
Reviewed-on: https://chromium-review.googlesource.com/c/1410954
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623516}
[modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/resources/app_management/constants.js
[modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/resources/app_management/metadata_view.html
[modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/resources/app_management/metadata_view.js
[modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/resources/app_management/permission_item.js
[modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/ui/webui/app_management/app_management.mojom
[modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/ui/webui/app_management/app_management_page_handler.cc
[modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/ui/webui/app_management/app_management_page_handler.h
[add] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/ui/webui/app_management/app_management_shelf_delegate_chromeos.cc
[add] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/ui/webui/app_management/app_management_shelf_delegate_chromeos.h

Comment 35 by bugdroid1@chromium.org, Jan 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c74feeaecfd7fb42201c90e1305d6b3414b58e8

commit 5c74feeaecfd7fb42201c90e1305d6b3414b58e8
Author: Cecilia Ni <ceciliani@google.com>
Date: Mon Jan 21 10:50:26 2019

[App Management] Add notification view

This CL sets up notification view to view all apps' notification settings.

Bug: 906508
Change-Id: I05261b33cfec8b48df44d8f58c80e8e1298f65fc
Reviewed-on: https://chromium-review.googlesource.com/c/1392684
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624550}
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/browser_resources.grd
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/app.html
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/app.js
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/constants.js
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/item.html
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/main_view.html
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/main_view.js
[add] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/notifications_view.html
[add] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/notifications_view.js
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/permission_view_header.html
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/permission_view_header.js
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/pwa_permission_view.html
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/pwa_permission_view.js
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/reducers.js
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/router.html
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/router.js
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/shared_style.html
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/ui/webui/app_management/app_management_ui.cc
[modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/test/data/webui/app_management/reducers_test.js

Comment 36 by bugdroid1@chromium.org, Jan 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4507712ec42fdd91c0ef9bacbe092fce8a108f5d

commit 4507712ec42fdd91c0ef9bacbe092fce8a108f5d
Author: Cecilia Ni <ceciliani@google.com>
Date: Mon Jan 21 12:24:39 2019

[App Management] UI Fix-up For High Priority Issue

This CL fixes the most pressing issues of current UI layout:
	1. Permission item doesn't have icons.
	2. Permission item doesn't match mocks.
	3. Line height is not correct, and it should be 1.54.
	4. Font weight of header text is not right, and it should be 500.

Bug: 906508
Change-Id: I8c22cc3cd8175b2c61b335421a088f3702adaf1f
Reviewed-on: https://chromium-review.googlesource.com/c/1411192
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624564}
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/actions.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/api_listener.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/api_listener.js
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/app.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/constants.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/main_view.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/metadata_view.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/permission_item.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/permission_item.js
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/permission_view_header.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/pwa_permission_view.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/reducers.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/shared_style.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/shared_vars.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/store.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/store_client.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/util.html
[modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/ui/webui/resources/cr_elements/icons.html

Comment 37 by bugdroid1@chromium.org, Jan 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4578dbc1b5d05f7f2514113418e60eccc6cdf96

commit d4578dbc1b5d05f7f2514113418e60eccc6cdf96
Author: Cecilia Ni <ceciliani@google.com>
Date: Mon Jan 21 12:40:02 2019

[App Management] Add test for notification sublabel

This CL sets up tests for notification sublabel.

Bug: 906508
Change-Id: Ic8f2377250ba74a672e00e85891d03a2d4fa9011
Reviewed-on: https://chromium-review.googlesource.com/c/1392686
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624569}
[modify] https://crrev.com/d4578dbc1b5d05f7f2514113418e60eccc6cdf96/chrome/browser/resources/app_management/main_view.js
[modify] https://crrev.com/d4578dbc1b5d05f7f2514113418e60eccc6cdf96/chrome/test/data/webui/app_management/main_view_test.js

Comment 38 by bugdroid, Jan 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbc164876372857d53d8c8cbded2321f5c77affb

commit cbc164876372857d53d8c8cbded2321f5c77affb
Author: Cecilia Ni <ceciliani@google.com>
Date: Fri Jan 25 00:20:19 2019

[App Management] Rename |item| to |app_item|

This CL renamed item element to app_item so that it won't be confused with permission_item.

Bug: 906508
Change-Id: I6e5edc7eb592d2f455ad106cec3cd7fb65fe6ebf
Reviewed-on: https://chromium-review.googlesource.com/c/1429315
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625890}

Comment 39 by bugdroid, Jan 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d53b984bae06df952cce232b1f551d49561b739a

commit d53b984bae06df952cce232b1f551d49561b739a
Author: Cecilia Ni <ceciliani@google.com>
Date: Fri Jan 25 00:22:38 2019

[App Management] Migrate videocam, mic, location-on icons from settings to cr_elements

This CL migrates mic videocam, location-on icons from setting directory to cr_elements, as app_management page needs to use these three icons.

Bug: 906508
Change-Id: I577373ec4dae01d76fae70aad80e31c125d08956
Reviewed-on: https://chromium-review.googlesource.com/c/1426199
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Cr-Commit-Position: refs/heads/master@{#625892}

Comment 40 by bugdroid, Jan 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2686e158d7b40fd89cf8a4b50144ead070a04d98

commit 2686e158d7b40fd89cf8a4b50144ead070a04d98
Author: Reka Norman <rekanorman@google.com>
Date: Fri Jan 25 05:40:50 2019

[App Management] Create ExtensionApps instance to publish web apps.

This CL creates a second ExtensionApps instance to act as an App Service
publisher for apps of type AppType.kWeb. This is necessary to allow the
UI to distinguish web apps from other extensions, all of which are
currently published with type AppType.kExtension.

Bug: 906508
Change-Id: Ide6911387ee1aa0c6455d68c11fe46675c4ff4e8
Reviewed-on: https://chromium-review.googlesource.com/c/1427999
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626003}

Comment 41 by bugdroid, Jan 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0abc618e473589ec1c87c50a7517189327f90716

commit 0abc618e473589ec1c87c50a7517189327f90716
Author: Cecilia Ni <ceciliani@google.com>
Date: Tue Jan 29 02:27:08 2019

[App Management] Change HTML import from absolute to relative.

This CL changes all chrome://apps HTML import to its relative path.

Bug: 906508
Change-Id: Iab67b3e5120c4907b6e3d9b5422a1c19f266aaaf
Reviewed-on: https://chromium-review.googlesource.com/c/1440804
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626848}
[modify] https://crrev.com/0abc618e473589ec1c87c50a7517189327f90716/chrome/browser/resources/app_management/api_listener.html
[modify] https://crrev.com/0abc618e473589ec1c87c50a7517189327f90716/chrome/browser/resources/app_management/app.html
[modify] https://crrev.com/0abc618e473589ec1c87c50a7517189327f90716/chrome/browser/resources/app_management/router.html

Comment 42 by bugdroid, Jan 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34b9b5c66d4306962a7cabc403b6f91f7df64d04

commit 34b9b5c66d4306962a7cabc403b6f91f7df64d04
Author: Reka Norman <rekanorman@google.com>
Date: Tue Jan 29 02:54:28 2019

[App Management] Implement permission live updates.

This CL makes the ExtensionApps class a content settings observer.
This allows live updates to the app management permissions page for a
PWA when the site settings corresponding to that PWA are changed.

Bug: 906508
Change-Id: I9c1a50765b492903e6540d87d7bdb3cb3bedb7bb
Reviewed-on: https://chromium-review.googlesource.com/c/1420499
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Reka Norman <rekanorman@google.com>
Cr-Commit-Position: refs/heads/master@{#626858}
[modify] https://crrev.com/34b9b5c66d4306962a7cabc403b6f91f7df64d04/chrome/browser/apps/app_service/app_service_proxy.cc
[modify] https://crrev.com/34b9b5c66d4306962a7cabc403b6f91f7df64d04/chrome/browser/apps/app_service/app_service_proxy.h
[modify] https://crrev.com/34b9b5c66d4306962a7cabc403b6f91f7df64d04/chrome/browser/apps/app_service/extension_apps.cc
[modify] https://crrev.com/34b9b5c66d4306962a7cabc403b6f91f7df64d04/chrome/browser/apps/app_service/extension_apps.h
[modify] https://crrev.com/34b9b5c66d4306962a7cabc403b6f91f7df64d04/chrome/browser/resources/app_management/permission_item.js

Comment 43 by bugdroid, Jan 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f74f0e7dcce66330602ec8177292d49538526b3

commit 2f74f0e7dcce66330602ec8177292d49538526b3
Author: Reka Norman <rekanorman@google.com>
Date: Tue Jan 29 03:55:33 2019

[App Management] Add metadata view tests.

This CL adds tests for the pin to shelf toggle in the app management
metadata view. It also creates a test util file, and refactors some
tests to use these util functions.

Bug: 906508
Change-Id: Ica7f7ceb5b097effbbab544a7f7cc066c7a9074d
Reviewed-on: https://chromium-review.googlesource.com/c/1420077
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626883}
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/browser/resources/app_management/chrome_app_permission_view.html
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/browser/resources/app_management/chrome_app_permission_view.js
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/browser/resources/app_management/metadata_view.html
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/browser/resources/app_management/metadata_view.js
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/browser/resources/app_management/permission_item.js
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/browser/resources/app_management/permission_view_header.html
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/browser/resources/app_management/permission_view_header.js
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/browser/resources/app_management/pwa_permission_view.html
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/browser/resources/app_management/pwa_permission_view.js
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/browser/resources/app_management/reducers.js
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/browser/resources/app_management/util.js
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/test/data/webui/app_management/app_management_browsertest.js
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/test/data/webui/app_management/app_test.js
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/test/data/webui/app_management/main_view_test.js
[add] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/test/data/webui/app_management/metadata_view_test.js
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/test/data/webui/app_management/reducers_test.js
[add] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/chrome/test/data/webui/app_management/test_util.js
[modify] https://crrev.com/2f74f0e7dcce66330602ec8177292d49538526b3/mojo/public/tools/bindings/generators/js_templates/lite/interface_externs.tmpl

Comment 44 by bugdroid, Jan 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/582e1eba308f23b50efeed01cbc89258c32050c8

commit 582e1eba308f23b50efeed01cbc89258c32050c8
Author: Reka Norman <rekanorman@google.com>
Date: Tue Jan 29 06:23:35 2019

[App Management] Load icons from chrome://app-icon.

This CL changes the app management page to load its app icons from
chrome://app-icon instead of chrome://extension-icon. It also fixes
a bug which prevents the default icon from loading in some cases where
the icon can't be found.

The chrome://app-icon url currently doesn't work for some Chrome
system apps (e.g. Web Store, Audio Player), so this will require
further investigation.

Bug: 906508
Change-Id: Ib350bf2490193fd17c807d2677f05355eefeb6bf
Reviewed-on: https://chromium-review.googlesource.com/c/1428620
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626907}
[modify] https://crrev.com/582e1eba308f23b50efeed01cbc89258c32050c8/chrome/browser/apps/app_service/app_icon_factory.cc
[modify] https://crrev.com/582e1eba308f23b50efeed01cbc89258c32050c8/chrome/browser/apps/app_service/app_icon_source.cc
[modify] https://crrev.com/582e1eba308f23b50efeed01cbc89258c32050c8/chrome/browser/resources/app_management/util.js

Comment 45 by bugdroid, Jan 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a11e57fcbd188d737f6a9217ce879bf0d3305277

commit a11e57fcbd188d737f6a9217ce879bf0d3305277
Author: Reka Norman <rekanorman@google.com>
Date: Tue Jan 29 21:56:58 2019

[App Management] Add App Management and App Service Ash flags.

This CL adds flags for the App Management and App Service Ash features,
to allow them to be enabled/disabled from the browser.

The App Management feature now also enables all the App Service
functionality used by the app management page, while the App Service Ash
feature enables the App Service functionality used by the shelf and app
list.

Bug: 906508
Change-Id: Ibd80ba73f50fc968bdd2ebbbd0e52cc893e870df
Reviewed-on: https://chromium-review.googlesource.com/c/1433332
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Reka Norman <rekanorman@google.com>
Cr-Commit-Position: refs/heads/master@{#627162}
[modify] https://crrev.com/a11e57fcbd188d737f6a9217ce879bf0d3305277/chrome/browser/about_flags.cc
[modify] https://crrev.com/a11e57fcbd188d737f6a9217ce879bf0d3305277/chrome/browser/apps/app_service/app_service_proxy_factory.cc
[modify] https://crrev.com/a11e57fcbd188d737f6a9217ce879bf0d3305277/chrome/browser/apps/app_service/arc_apps_factory.cc
[modify] https://crrev.com/a11e57fcbd188d737f6a9217ce879bf0d3305277/chrome/browser/flag-metadata.json
[modify] https://crrev.com/a11e57fcbd188d737f6a9217ce879bf0d3305277/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/a11e57fcbd188d737f6a9217ce879bf0d3305277/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/a11e57fcbd188d737f6a9217ce879bf0d3305277/chrome/browser/ui/app_list/app_list_syncable_service.cc
[modify] https://crrev.com/a11e57fcbd188d737f6a9217ce879bf0d3305277/chrome/browser/ui/app_list/search/app_search_provider.cc
[modify] https://crrev.com/a11e57fcbd188d737f6a9217ce879bf0d3305277/chrome/common/chrome_features.cc
[modify] https://crrev.com/a11e57fcbd188d737f6a9217ce879bf0d3305277/chrome/common/chrome_features.h
[modify] https://crrev.com/a11e57fcbd188d737f6a9217ce879bf0d3305277/tools/metrics/histograms/enums.xml

Comment 46 by bugdroid, Jan 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60977fdbcd60d99da701b28383aa1fc20b958cca

commit 60977fdbcd60d99da701b28383aa1fc20b958cca
Author: Cecilia Ni <ceciliani@google.com>
Date: Thu Jan 31 07:20:32 2019

[App Management] Make Notification View Toggle Notification Permission

This CL enables toggling notification permission from notification view, as well as collapses
Apps without notification permission before expanding the app list in notification view.

Bug: 906508
Change-Id: I0f869faf2a339df7b5704cbabd9dac56fd6b6022
Reviewed-on: https://chromium-review.googlesource.com/c/1396005
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627855}
[modify] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/browser_resources.grd
[modify] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/resources/app_management/app.js
[modify] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/resources/app_management/browser_proxy.js
[modify] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/resources/app_management/main_view.html
[modify] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/resources/app_management/main_view.js
[modify] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/resources/app_management/metadata_view.js
[modify] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/resources/app_management/notifications_view.html
[modify] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/resources/app_management/notifications_view.js
[modify] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/resources/app_management/permission_item.html
[modify] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/resources/app_management/permission_item.js
[add] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/resources/app_management/permission_toggle.html
[add] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/resources/app_management/permission_toggle.js
[modify] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/resources/app_management/util.js
[modify] https://crrev.com/60977fdbcd60d99da701b28383aa1fc20b958cca/chrome/browser/ui/webui/app_management/app_management_ui.cc

Comment 47 by bugdroid, Feb 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67d13b46d6c3e5b0fefde7f5a8a444f45af98a24

commit 67d13b46d6c3e5b0fefde7f5a8a444f45af98a24
Author: Reka Norman <rekanorman@google.com>
Date: Wed Feb 06 02:58:08 2019

[App Management] Create <app-management-dom-switch> element.

This CL creates a new dom-switch element which ensures that only one
element out of a group of elements is attached to the DOM at a time.
This is used for switching between different views in the app
management page, so that views are detached when not being displayed,
and therefore don't evalute meaningless Polymer bindings.

Bug: 906508
Change-Id: I7efe91d4087eb17de3e8a5cbe2a8adb870fc6360
Reviewed-on: https://chromium-review.googlesource.com/c/1449959
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629444}
[modify] https://crrev.com/67d13b46d6c3e5b0fefde7f5a8a444f45af98a24/chrome/browser/browser_resources.grd
[modify] https://crrev.com/67d13b46d6c3e5b0fefde7f5a8a444f45af98a24/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/67d13b46d6c3e5b0fefde7f5a8a444f45af98a24/chrome/browser/resources/app_management/app.html
[modify] https://crrev.com/67d13b46d6c3e5b0fefde7f5a8a444f45af98a24/chrome/browser/resources/app_management/app.js
[add] https://crrev.com/67d13b46d6c3e5b0fefde7f5a8a444f45af98a24/chrome/browser/resources/app_management/dom_switch.html
[add] https://crrev.com/67d13b46d6c3e5b0fefde7f5a8a444f45af98a24/chrome/browser/resources/app_management/dom_switch.js
[modify] https://crrev.com/67d13b46d6c3e5b0fefde7f5a8a444f45af98a24/chrome/browser/ui/webui/app_management/app_management_ui.cc
[modify] https://crrev.com/67d13b46d6c3e5b0fefde7f5a8a444f45af98a24/chrome/test/data/webui/app_management/app_management_browsertest.js
[add] https://crrev.com/67d13b46d6c3e5b0fefde7f5a8a444f45af98a24/chrome/test/data/webui/app_management/dom_switch_test.js

Comment 48 by bugdroid, Feb 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/735d1464ae9036ae64195cbef93ea8982b89fc9e

commit 735d1464ae9036ae64195cbef93ea8982b89fc9e
Author: Cecilia Ni <ceciliani@google.com>
Date: Thu Feb 07 01:50:10 2019

[App Management] Replace == to === in JavaScript.

This CL changes all the "==" in JavaScript to "===", to adhere the style guide.

Bug: 906508
Change-Id: I77961c553c71decb313560b5cadf89c28fda99c1
Reviewed-on: https://chromium-review.googlesource.com/c/1454111
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Cr-Commit-Position: refs/heads/master@{#629832}
[modify] https://crrev.com/735d1464ae9036ae64195cbef93ea8982b89fc9e/chrome/browser/resources/app_management/actions.js
[modify] https://crrev.com/735d1464ae9036ae64195cbef93ea8982b89fc9e/chrome/browser/resources/app_management/main_view.js
[modify] https://crrev.com/735d1464ae9036ae64195cbef93ea8982b89fc9e/chrome/browser/resources/app_management/reducers.js

Comment 49 by bugdroid, Feb 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caeb4fa4d7e2f62e3858571324a083787902f7c0

commit caeb4fa4d7e2f62e3858571324a083787902f7c0
Author: Cecilia Ni <ceciliani@google.com>
Date: Thu Feb 07 02:17:25 2019

[App Management] Fix routing from notification view to permission view.

This CL set the dwellTime in iron-location manually to prevent extra url to be
pushed in window.history stack. This is caused by when navigating from
notification page to detail page, queryParam and path both update, but
they do not happen simultaneously, and this causes observers in
iron-location API get triggered twice, resulting two urls pushed in
history.stack.

Bug: 906508
Change-Id: I55d5c94e200b068e179b31d9586d9f7497b84885
Reviewed-on: https://chromium-review.googlesource.com/c/1454351
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629840}
[modify] https://crrev.com/caeb4fa4d7e2f62e3858571324a083787902f7c0/chrome/browser/resources/app_management/router.html
[modify] https://crrev.com/caeb4fa4d7e2f62e3858571324a083787902f7c0/chrome/browser/resources/app_management/router.js

Comment 50 by bugdroid, Feb 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b

commit 187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b
Author: Cecilia Ni <ceciliani@google.com>
Date: Fri Feb 08 09:48:25 2019

[App Management] Add Search View

This CL sets up search view that enables users to search titles of all the apps.

Bug: 906508
Change-Id: Ib7a0d25be508af644a50f0d46f7e51e97dfe1774
Reviewed-on: https://chromium-review.googlesource.com/c/1395858
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Auto-Submit: Cecilia Ni <ceciliani@google.com>
Cr-Commit-Position: refs/heads/master@{#630258}
[modify] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/app/app_management_strings.grdp
[modify] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/browser/browser_resources.grd
[modify] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/browser/resources/app_management/actions.js
[modify] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/browser/resources/app_management/app.html
[modify] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/browser/resources/app_management/app.js
[modify] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/browser/resources/app_management/constants.js
[modify] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/browser/resources/app_management/reducers.js
[modify] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/browser/resources/app_management/router.js
[add] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/browser/resources/app_management/search_view.html
[add] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/browser/resources/app_management/search_view.js
[modify] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/browser/resources/app_management/types.js
[modify] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/browser/resources/app_management/util.js
[modify] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/browser/ui/webui/app_management/app_management_ui.cc
[modify] https://crrev.com/187f71d8f94ad5c24b2cae9e3ac3b7bdb041446b/chrome/test/data/webui/app_management/reducers_test.js

Comment 51 by bugdroid, Feb 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/420bdee53dbd8cececb40f1d665495be93fb1c6f

commit 420bdee53dbd8cececb40f1d665495be93fb1c6f
Author: Reka Norman <rekanorman@google.com>
Date: Mon Feb 11 01:37:15 2019

[App Management] Add ARC permission view and fix notifications view.

This CL adds a permission view for ARC apps, which involves making the
permission-related functionality of the page more generic so that it
works for different app types.

It also fixes a problem which prevents the toggles in the notification
view from actually changing permissions.

Bug: 906508
Change-Id: I180beed57a5ad6009fb64e4f180002fba1369242
Reviewed-on: https://chromium-review.googlesource.com/c/1453218
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630675}
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/app/app_management_strings.grdp
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/browser_resources.grd
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/app.html
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/app.js
[add] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/arc_permission_view.html
[add] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/arc_permission_view.js
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/browser_proxy.js
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/chrome_app_permission_view.html
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/constants.js
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/fake_page_handler.js
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/metadata_view.html
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/notifications_view.html
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/notifications_view.js
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/permission_item.js
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/permission_toggle.js
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/pwa_permission_view.html
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/pwa_permission_view.js
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/shared_style.html
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/resources/app_management/util.js
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/ui/webui/app_management/app_management.mojom
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/ui/webui/app_management/app_management_page_handler.cc
[modify] https://crrev.com/420bdee53dbd8cececb40f1d665495be93fb1c6f/chrome/browser/ui/webui/app_management/app_management_ui.cc

Comment 52 by bugdroid, Feb 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc7ecdb3e6e76638553b22be2e683f990b49a37a

commit cc7ecdb3e6e76638553b22be2e683f990b49a37a
Author: Cecilia Ni <ceciliani@google.com>
Date: Mon Feb 11 05:31:48 2019

[App Management] Add PWA Permission View Test

This CL adds PWA Permission View tests that test 1) toggle status reflects permission status, and 2) click toggle will toggle the corresponding permission.

Bug: 906508
Change-Id: I03f77afe2a75afc260c2d0dcdfe907e6d12dc9e8
Reviewed-on: https://chromium-review.googlesource.com/c/1445331
Auto-Submit: Cecilia Ni <ceciliani@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Cr-Commit-Position: refs/heads/master@{#630690}
[modify] https://crrev.com/cc7ecdb3e6e76638553b22be2e683f990b49a37a/chrome/browser/resources/app_management/pwa_permission_view.html
[modify] https://crrev.com/cc7ecdb3e6e76638553b22be2e683f990b49a37a/chrome/test/data/webui/app_management/app_management_browsertest.js
[add] https://crrev.com/cc7ecdb3e6e76638553b22be2e683f990b49a37a/chrome/test/data/webui/app_management/pwa_permission_view_test.js

Comment 53 by bugdroid, Feb 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5588677170ee330c1c0ae25bc336106ab35ee8b6

commit 5588677170ee330c1c0ae25bc336106ab35ee8b6
Author: Cecilia Ni <ceciliani@google.com>
Date: Mon Feb 11 08:42:07 2019

[App Management] Integrate search view with dom-switch

This CL integrates search view with dom-switch by letting selectedRouteId_ directly watch the
existence of search term rather than delegating to reducer.currentPageState to handle search.

This way, after users clear search, they will go back to the page they were on rather than main
page.

Bug: 906508
Change-Id: I75aabf2ccfdadc48093062b48adf85932c2b9606
Reviewed-on: https://chromium-review.googlesource.com/c/1459868
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Cr-Commit-Position: refs/heads/master@{#630699}
[modify] https://crrev.com/5588677170ee330c1c0ae25bc336106ab35ee8b6/chrome/browser/resources/app_management/actions.js
[modify] https://crrev.com/5588677170ee330c1c0ae25bc336106ab35ee8b6/chrome/browser/resources/app_management/app.html
[modify] https://crrev.com/5588677170ee330c1c0ae25bc336106ab35ee8b6/chrome/browser/resources/app_management/app.js
[modify] https://crrev.com/5588677170ee330c1c0ae25bc336106ab35ee8b6/chrome/browser/resources/app_management/constants.js
[modify] https://crrev.com/5588677170ee330c1c0ae25bc336106ab35ee8b6/chrome/browser/resources/app_management/reducers.js
[modify] https://crrev.com/5588677170ee330c1c0ae25bc336106ab35ee8b6/chrome/test/data/webui/app_management/app_test.js
[modify] https://crrev.com/5588677170ee330c1c0ae25bc336106ab35ee8b6/chrome/test/data/webui/app_management/reducers_test.js

Comment 54 by bugdroid, Feb 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c40d503c8768c643a1d2fc2da002910c3f49b71

commit 8c40d503c8768c643a1d2fc2da002910c3f49b71
Author: Reka Norman <rekanorman@google.com>
Date: Mon Feb 11 22:52:08 2019

[App Management] Add uninstall confirmation dialog for extension apps.

This CL changes the Uninstall method of ExtensionApps to use the
ExtensionUninstaller, which causes a confirmation dialog to pop up when
apps are uninstalled from the App Management page.

Bug: 906508
Change-Id: Ie72309322345a66601ed2b60b883edaa9d01586d
Reviewed-on: https://chromium-review.googlesource.com/c/1460580
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Reka Norman <rekanorman@google.com>
Cr-Commit-Position: refs/heads/master@{#630968}
[modify] https://crrev.com/8c40d503c8768c643a1d2fc2da002910c3f49b71/chrome/browser/apps/app_service/extension_apps.cc

Comment 55 by bugdroid, Feb 13 (6 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ebc60dd1a01c87b6bb0d7fb525ec6969c9d5adf

commit 4ebc60dd1a01c87b6bb0d7fb525ec6969c9d5adf
Author: Cecilia Ni <ceciliani@google.com>
Date: Wed Feb 13 03:51:20 2019

[App Management] UI Fix-up for Medium Priority Issues.

This CL fixes some relatively subtle but important issues of UI including:
1. Bad wrapping behavior in permission header for small windows
2. Permission row is not fully clickable
3. The resize behaviour is not consistent with other projects
4. The scroll behavior is bad in small window
5. Item's cursor is default instead of a pointer, and it is now user-selectible
6. Change the min-width of cr-card-elevation to ensure the consistency across
bookmarks, history, setting, downloads, and extension

Bug: 906508
Change-Id: I008c3a4f28fabc71c79da549fc860d37f7aa503c
Reviewed-on: https://chromium-review.googlesource.com/c/1425843
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631544}
[modify] https://crrev.com/4ebc60dd1a01c87b6bb0d7fb525ec6969c9d5adf/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/4ebc60dd1a01c87b6bb0d7fb525ec6969c9d5adf/chrome/browser/resources/app_management/app.html
[modify] https://crrev.com/4ebc60dd1a01c87b6bb0d7fb525ec6969c9d5adf/chrome/browser/resources/app_management/app_item.html
[modify] https://crrev.com/4ebc60dd1a01c87b6bb0d7fb525ec6969c9d5adf/chrome/browser/resources/app_management/main_view.html
[modify] https://crrev.com/4ebc60dd1a01c87b6bb0d7fb525ec6969c9d5adf/chrome/browser/resources/app_management/permission_item.html
[modify] https://crrev.com/4ebc60dd1a01c87b6bb0d7fb525ec6969c9d5adf/chrome/browser/resources/app_management/permission_item.js
[modify] https://crrev.com/4ebc60dd1a01c87b6bb0d7fb525ec6969c9d5adf/chrome/browser/resources/app_management/permission_toggle.js
[modify] https://crrev.com/4ebc60dd1a01c87b6bb0d7fb525ec6969c9d5adf/chrome/browser/resources/app_management/pwa_permission_view.js
[modify] https://crrev.com/4ebc60dd1a01c87b6bb0d7fb525ec6969c9d5adf/chrome/browser/resources/app_management/shared_style.html
[modify] https://crrev.com/4ebc60dd1a01c87b6bb0d7fb525ec6969c9d5adf/chrome/browser/resources/app_management/shared_vars.html

Comment 56 by bugdroid, Feb 13 (6 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2216b69de93ac09aa7effbc984e536e0516c1fe

commit e2216b69de93ac09aa7effbc984e536e0516c1fe
Author: Reka Norman <rekanorman@google.com>
Date: Wed Feb 13 04:24:56 2019

[App Management] Add show_in_management field to App Service App struct.

This CL adds a show_in_management field to the App Service App struct,
which is used by the PageHandler to determine whether or not an app
should be displayed in the App Management page. This provides a way to
stop built-in Chrome apps and component extensions from showing up in
the page.

Bug: 906508
Change-Id: Ide70b56cd669ba62a5f7294c5fd8e30db11548f1
Reviewed-on: https://chromium-review.googlesource.com/c/1460208
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Reka Norman <rekanorman@google.com>
Cr-Commit-Position: refs/heads/master@{#631554}
[modify] https://crrev.com/e2216b69de93ac09aa7effbc984e536e0516c1fe/chrome/browser/apps/app_service/arc_apps.cc
[modify] https://crrev.com/e2216b69de93ac09aa7effbc984e536e0516c1fe/chrome/browser/apps/app_service/built_in_chromeos_apps.cc
[modify] https://crrev.com/e2216b69de93ac09aa7effbc984e536e0516c1fe/chrome/browser/apps/app_service/crostini_apps.cc
[modify] https://crrev.com/e2216b69de93ac09aa7effbc984e536e0516c1fe/chrome/browser/apps/app_service/extension_apps.cc
[modify] https://crrev.com/e2216b69de93ac09aa7effbc984e536e0516c1fe/chrome/browser/apps/app_service/extension_apps.h
[modify] https://crrev.com/e2216b69de93ac09aa7effbc984e536e0516c1fe/chrome/browser/ui/webui/app_management/app_management_page_handler.cc
[modify] https://crrev.com/e2216b69de93ac09aa7effbc984e536e0516c1fe/chrome/services/app_service/public/cpp/app_update.cc
[modify] https://crrev.com/e2216b69de93ac09aa7effbc984e536e0516c1fe/chrome/services/app_service/public/cpp/app_update.h
[modify] https://crrev.com/e2216b69de93ac09aa7effbc984e536e0516c1fe/chrome/services/app_service/public/cpp/app_update_unittest.cc
[modify] https://crrev.com/e2216b69de93ac09aa7effbc984e536e0516c1fe/chrome/services/app_service/public/mojom/types.mojom

Comment 57 by bugdroid, Feb 13 (6 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd89ec62a11a756b514f0f4b6d84edce8715e703

commit fd89ec62a11a756b514f0f4b6d84edce8715e703
Author: Reka Norman <rekanorman@google.com>
Date: Wed Feb 13 05:47:25 2019

[App Management] Add 'Open Extensions settings' button to Chrome app view.

This CL adds a button to the Chrome app permission view which opens the
chrome://extensions settings page for the app.

Bug: 906508
Change-Id: I3aadaa449fa5f4987b7f41daefe0d193ce1dd303
Reviewed-on: https://chromium-review.googlesource.com/c/1461200
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631577}
[modify] https://crrev.com/fd89ec62a11a756b514f0f4b6d84edce8715e703/chrome/app/app_management_strings.grdp
[modify] https://crrev.com/fd89ec62a11a756b514f0f4b6d84edce8715e703/chrome/browser/resources/app_management/chrome_app_permission_view.html
[modify] https://crrev.com/fd89ec62a11a756b514f0f4b6d84edce8715e703/chrome/browser/resources/app_management/chrome_app_permission_view.js
[modify] https://crrev.com/fd89ec62a11a756b514f0f4b6d84edce8715e703/chrome/browser/ui/webui/app_management/app_management_ui.cc

Comment 58 by bugdroid, Feb 13 (6 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a5a9c9026225fd34529163d72c04856e4104343

commit 6a5a9c9026225fd34529163d72c04856e4104343
Author: Reka Norman <rekanorman@google.com>
Date: Wed Feb 13 07:13:00 2019

[App Management] Add sets of app ids with notifications blocked/allowed to the page state.

This CL adds two sets of app ids to the AppManagementPageState, one
containing all the apps with notifications blocked, and the other
containing all the apps with notifications allowed. These sets are used
both by the main view to compute the notifications sublabel, and by
the notifications view to determine which apps should be expanded and
collapsed.

Bug: 906508
Change-Id: I9ecdee4da58f977cf058b019d95b91aeba569a9d
Reviewed-on: https://chromium-review.googlesource.com/c/1459866
Commit-Queue: Reka Norman <rekanorman@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631592}
[modify] https://crrev.com/6a5a9c9026225fd34529163d72c04856e4104343/chrome/browser/resources/app_management/BUILD.gn
[modify] https://crrev.com/6a5a9c9026225fd34529163d72c04856e4104343/chrome/browser/resources/app_management/actions.js
[modify] https://crrev.com/6a5a9c9026225fd34529163d72c04856e4104343/chrome/browser/resources/app_management/main_view.html
[modify] https://crrev.com/6a5a9c9026225fd34529163d72c04856e4104343/chrome/browser/resources/app_management/main_view.js
[modify] https://crrev.com/6a5a9c9026225fd34529163d72c04856e4104343/chrome/browser/resources/app_management/notifications_view.js
[modify] https://crrev.com/6a5a9c9026225fd34529163d72c04856e4104343/chrome/browser/resources/app_management/reducers.js
[modify] https://crrev.com/6a5a9c9026225fd34529163d72c04856e4104343/chrome/browser/resources/app_management/types.js
[modify] https://crrev.com/6a5a9c9026225fd34529163d72c04856e4104343/chrome/browser/resources/app_management/util.js
[modify] https://crrev.com/6a5a9c9026225fd34529163d72c04856e4104343/chrome/test/data/webui/app_management/reducers_test.js
[modify] https://crrev.com/6a5a9c9026225fd34529163d72c04856e4104343/chrome/test/data/webui/app_management/test_util.js

Comment 59 by bugdroid, Feb 14 (5 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61603999c0924c0357625fbdad6039696ad87e38

commit 61603999c0924c0357625fbdad6039696ad87e38
Author: Cecilia Ni <ceciliani@google.com>
Date: Thu Feb 14 05:14:11 2019

[App Management] Add router test and fix router

This CL fixes router so that the application directs to the right page
when receiving a direct url input, and adds router test by testing the
store responds to url change and the other way around.

Bug: 906508
Change-Id: I66aa950be039faca2378ba48417db28be3ae2681
Reviewed-on: https://chromium-review.googlesource.com/c/1466165
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632090}
[modify] https://crrev.com/61603999c0924c0357625fbdad6039696ad87e38/chrome/browser/resources/app_management/router.js
[modify] https://crrev.com/61603999c0924c0357625fbdad6039696ad87e38/chrome/test/data/webui/app_management/app_management_browsertest.js
[modify] https://crrev.com/61603999c0924c0357625fbdad6039696ad87e38/chrome/test/data/webui/app_management/main_view_test.js
[modify] https://crrev.com/61603999c0924c0357625fbdad6039696ad87e38/chrome/test/data/webui/app_management/metadata_view_test.js
[modify] https://crrev.com/61603999c0924c0357625fbdad6039696ad87e38/chrome/test/data/webui/app_management/pwa_permission_view_test.js
[modify] https://crrev.com/61603999c0924c0357625fbdad6039696ad87e38/chrome/test/data/webui/app_management/reducers_test.js
[add] https://crrev.com/61603999c0924c0357625fbdad6039696ad87e38/chrome/test/data/webui/app_management/router_test.js
[add] https://crrev.com/61603999c0924c0357625fbdad6039696ad87e38/chrome/test/data/webui/app_management/test_store.js
[modify] https://crrev.com/61603999c0924c0357625fbdad6039696ad87e38/chrome/test/data/webui/app_management/test_util.js

Comment 60 by bugdroid, Feb 15 (4 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/825c963b7d3b05ec082abf4f674b62462b253cb6

commit 825c963b7d3b05ec082abf4f674b62462b253cb6
Author: Cecilia Ni <ceciliani@google.com>
Date: Fri Feb 15 04:34:10 2019

[App Management] Extracting common elements in main view and notification view to a new element.

This CL extracts the common elements in notification and main view, a expandable app list, to a new element called expandable_app_list.

Bug: 906508
Change-Id: I28530b5c047f21dfa3910290d7804588d9f0360a
Reviewed-on: https://chromium-review.googlesource.com/c/1447393
Commit-Queue: Cecilia Ni <ceciliani@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632504}
[modify] https://crrev.com/825c963b7d3b05ec082abf4f674b62462b253cb6/chrome/browser/browser_resources.grd
[modify] https://crrev.com/825c963b7d3b05ec082abf4f674b62462b253cb6/chrome/browser/resources/app_management/BUILD.gn
[add] https://crrev.com/825c963b7d3b05ec082abf4f674b62462b253cb6/chrome/browser/resources/app_management/expandable_app_list.html
[add] https://crrev.com/825c963b7d3b05ec082abf4f674b62462b253cb6/chrome/browser/resources/app_management/expandable_app_list.js
[modify] https://crrev.com/825c963b7d3b05ec082abf4f674b62462b253cb6/chrome/browser/resources/app_management/main_view.html
[modify] https://crrev.com/825c963b7d3b05ec082abf4f674b62462b253cb6/chrome/browser/resources/app_management/main_view.js
[modify] https://crrev.com/825c963b7d3b05ec082abf4f674b62462b253cb6/chrome/browser/resources/app_management/notifications_view.html
[modify] https://crrev.com/825c963b7d3b05ec082abf4f674b62462b253cb6/chrome/browser/resources/app_management/notifications_view.js
[modify] https://crrev.com/825c963b7d3b05ec082abf4f674b62462b253cb6/chrome/browser/resources/app_management/shared_style.html
[modify] https://crrev.com/825c963b7d3b05ec082abf4f674b62462b253cb6/chrome/browser/ui/webui/app_management/app_management_ui.cc
[modify] https://crrev.com/825c963b7d3b05ec082abf4f674b62462b253cb6/chrome/test/data/webui/app_management/main_view_test.js

Sign in to add a comment