This is a tracker bug for work on the new chrome://apps App Management UI.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9231a22ff22d1cb03bb219f579349a242bd26df8 commit 9231a22ff22d1cb03bb219f579349a242bd26df8 Author: Christopher Lam <calamity@chromium.org> Date: Mon Nov 19 08:28:02 2018 [App Management] Add skeleton for App Management WebUI. This CL adds a WebUI for App Management that replaces chrome://apps when the feature NewAppManagement is enabled. This involves: - adding the feature - adding a new MojoWebUIController - adding a mojom, and its C++ handler - adding a skeleton HTML and Polymer 'app' element - adding a BrowserProxy which connects the Renderer JS to the backend C++. Bug: 906508 Change-Id: Iac5be9ce82dc2cb0b1c77301ca43ccf7a99f318f Reviewed-on: https://chromium-review.googlesource.com/c/1309380 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#609204} [modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/BUILD.gn [modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/browser_resources.grd [modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/BUILD.gn [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/app_management/BUILD.gn [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/app_management/OWNERS [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/app_management/app.html [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/app_management/app.js [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/app_management/browser_proxy.html [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/app_management/browser_proxy.js [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/resources/app_management/index.html [modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/BUILD.gn [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/app_management/BUILD.gn [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/app_management/OWNERS [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/app_management/app_management.mojom [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/app_management/app_management_page_handler.cc [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/app_management/app_management_page_handler.h [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/app_management/app_management_ui.cc [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/app_management/app_management_ui.h [modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/common/chrome_features.cc [modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/common/chrome_features.h [modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/test/BUILD.gn [modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/test/data/webui/BUILD.gn [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/test/data/webui/app_management/app_management_browsertest.js [add] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/chrome/test/data/webui/app_management/app_test.js [modify] https://crrev.com/9231a22ff22d1cb03bb219f579349a242bd26df8/testing/buildbot/filters/webui_polymer2_browser_tests.filter
Could you use a different component, instead of "UI>Browser>WebUI". That component is meant to capture issues that span multiple WebUI pages, and not be a catch-all component for any WebUI page that does not have its own component.
#2: Removed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54b8c1de6a1ad36c7f6935a6300f66bad2d65558 commit 54b8c1de6a1ad36c7f6935a6300f66bad2d65558 Author: Reka Norman <rekanorman@google.com> Date: Tue Dec 04 07:18:26 2018 [App Management] Add main view This CL adds a skeleton main view to the app management page. Bug: 906508 Change-Id: I61c29c3dbbc3037efacc0941b103ee66e30e4c7b Reviewed-on: https://chromium-review.googlesource.com/c/1358194 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#613456} [modify] https://crrev.com/54b8c1de6a1ad36c7f6935a6300f66bad2d65558/chrome/browser/browser_resources.grd [modify] https://crrev.com/54b8c1de6a1ad36c7f6935a6300f66bad2d65558/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/54b8c1de6a1ad36c7f6935a6300f66bad2d65558/chrome/browser/resources/app_management/app.html [add] https://crrev.com/54b8c1de6a1ad36c7f6935a6300f66bad2d65558/chrome/browser/resources/app_management/main_view.html [add] https://crrev.com/54b8c1de6a1ad36c7f6935a6300f66bad2d65558/chrome/browser/resources/app_management/main_view.js [modify] https://crrev.com/54b8c1de6a1ad36c7f6935a6300f66bad2d65558/chrome/browser/ui/webui/app_management/app_management_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dd7e3574c242e0e4544fe8d7e1780f4c588f614 commit 3dd7e3574c242e0e4544fe8d7e1780f4c588f614 Author: Reka Norman <rekanorman@google.com> Date: Thu Dec 06 09:11:29 2018 [App Management] Add FakePageHandler This CL adds a fake page handler to the app management page which is used when accessing chrome://apps?fakeBackend=true. Bug: 906508 Change-Id: Ib92a66a45b312efd14b5fb038d7cc506944dd716 Reviewed-on: https://chromium-review.googlesource.com/c/1360034 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#614293} [modify] https://crrev.com/3dd7e3574c242e0e4544fe8d7e1780f4c588f614/chrome/browser/browser_resources.grd [modify] https://crrev.com/3dd7e3574c242e0e4544fe8d7e1780f4c588f614/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/3dd7e3574c242e0e4544fe8d7e1780f4c588f614/chrome/browser/resources/app_management/browser_proxy.html [modify] https://crrev.com/3dd7e3574c242e0e4544fe8d7e1780f4c588f614/chrome/browser/resources/app_management/browser_proxy.js [add] https://crrev.com/3dd7e3574c242e0e4544fe8d7e1780f4c588f614/chrome/browser/resources/app_management/fake_page_handler.js [modify] https://crrev.com/3dd7e3574c242e0e4544fe8d7e1780f4c588f614/chrome/browser/ui/webui/app_management/app_management_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be2a6c46ff867eec74b7f338a849ef67a86fc546 commit be2a6c46ff867eec74b7f338a849ef67a86fc546 Author: Reka Norman <rekanorman@google.com> Date: Fri Dec 07 02:00:31 2018 [App Management] Add app list This CL adds a list of apps to the main view of the app management page. Bug: 906508 Change-Id: If6d22ad1d9851d3ce5387027da585005a7987c63 Reviewed-on: https://chromium-review.googlesource.com/c/1360199 Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Reka Norman <rekanorman@google.com> Cr-Commit-Position: refs/heads/master@{#614576} [modify] https://crrev.com/be2a6c46ff867eec74b7f338a849ef67a86fc546/chrome/browser/resources/app_management/fake_page_handler.js [modify] https://crrev.com/be2a6c46ff867eec74b7f338a849ef67a86fc546/chrome/browser/resources/app_management/main_view.html [modify] https://crrev.com/be2a6c46ff867eec74b7f338a849ef67a86fc546/chrome/browser/resources/app_management/main_view.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac15854074f0838812e75aae06ff372e75085127 commit ac15854074f0838812e75aae06ff372e75085127 Author: Cecilia Ni <ceciliani@google.com> Date: Mon Dec 10 03:32:34 2018 [App Management] Add OWNERS for strings Bug: 906508 Change-Id: I91754c8888af86aca0be18e274b96b803948c5ce Reviewed-on: https://chromium-review.googlesource.com/c/1367080 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#615038} [modify] https://crrev.com/ac15854074f0838812e75aae06ff372e75085127/chrome/app/OWNERS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4078dcc31aafc197f97ac909520ad524b46be4f0 commit 4078dcc31aafc197f97ac909520ad524b46be4f0 Author: Reka Norman <rekanorman@google.com> Date: Mon Dec 10 04:48:03 2018 [App Management] Add i18n This CL sets up i18n for the app management page. Bug: 906508 Change-Id: Ie17b5fa1af00cde9f8a82b7ab94caed0afb24e2a Reviewed-on: https://chromium-review.googlesource.com/c/1362674 Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Reka Norman <rekanorman@google.com> Cr-Commit-Position: refs/heads/master@{#615045} [add] https://crrev.com/4078dcc31aafc197f97ac909520ad524b46be4f0/chrome/app/app_management_strings.grdp [modify] https://crrev.com/4078dcc31aafc197f97ac909520ad524b46be4f0/chrome/app/generated_resources.grd [modify] https://crrev.com/4078dcc31aafc197f97ac909520ad524b46be4f0/chrome/browser/resources/app_management/main_view.html [modify] https://crrev.com/4078dcc31aafc197f97ac909520ad524b46be4f0/chrome/browser/ui/webui/app_management/app_management_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22363333c25c9f1751fa2322a0b42331063c9a3d commit 22363333c25c9f1751fa2322a0b42331063c9a3d Author: Melissa Zhang <melzhang@google.com> Date: Tue Dec 11 02:00:13 2018 Implement App Struct and Pass Apps to AppManagement This CL defines the app struct and gives apps from the user's profile to AppManagement. It also informs the AppManagement UI of any updates to apps, including uninstallation. BUG=906508 Change-Id: I20f1483563d8252c1060212dbbfd9cb9d560f790 Reviewed-on: https://chromium-review.googlesource.com/c/1365090 Commit-Queue: Melissa Zhang <melzhang@google.com> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#615380} [modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/BUILD.gn [modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/browser_resources.grd [modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/resources/app_management/browser_proxy.html [modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/webui/DEPS [modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/webui/app_management/BUILD.gn [modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/webui/app_management/app_management.mojom [modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/webui/app_management/app_management_page_handler.cc [modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/webui/app_management/app_management_page_handler.h [modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/webui/app_management/app_management_ui.cc [modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [modify] https://crrev.com/22363333c25c9f1751fa2322a0b42331063c9a3d/mojo/public/tools/bindings/generators/mojom_js_generator.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3a875162fadbd939162dd1bf0e1753a212815e5 commit a3a875162fadbd939162dd1bf0e1753a212815e5 Author: Reka Norman <rekanorman@google.com> Date: Tue Dec 11 07:45:29 2018 [App Management] Fix FakePageHandler This CL updates the FakePageHandler to use generated Mojo types. Bug: 906508 Change-Id: Ib04a9118e7ad7de6ac1aa9dfdf2d232c3280034a Reviewed-on: https://chromium-review.googlesource.com/c/1370232 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#615454} [modify] https://crrev.com/a3a875162fadbd939162dd1bf0e1753a212815e5/chrome/browser/resources/app_management/fake_page_handler.js [modify] https://crrev.com/a3a875162fadbd939162dd1bf0e1753a212815e5/chrome/browser/resources/app_management/main_view.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bbb0ffe91f106092814dfc7018f28e8756507af commit 9bbb0ffe91f106092814dfc7018f28e8756507af Author: Reka Norman <rekanorman@google.com> Date: Wed Dec 12 23:25:44 2018 [App Management] Make bookmarks store generic This CL moves the data store and store client from bookmarks into cr.ui and makes them generic so that they can be used by other pages. Bug: 906508 Change-Id: I578a3e0b308b1d21ad412cf8be7e08db3b402469 Reviewed-on: https://chromium-review.googlesource.com/c/1369444 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#616101} [modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/app_management/main_view.html [modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/BUILD.gn [modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/actions.js [modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/api_listener.js [modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/store.html [modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/store.js [modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/store_client.html [modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/store_client.js [modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/browser/resources/md_bookmarks/types.js [modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/chrome/test/data/webui/md_bookmarks/test_store.js [add] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/ui/webui/resources/html/cr/ui/store.html [add] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/ui/webui/resources/html/cr/ui/store_client.html [modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/ui/webui/resources/js/cr/ui/BUILD.gn [add] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/ui/webui/resources/js/cr/ui/store.js [add] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/ui/webui/resources/js/cr/ui/store_client.js [modify] https://crrev.com/9bbb0ffe91f106092814dfc7018f28e8756507af/ui/webui/resources/webui_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75 commit 45dbfb9cd0326e7fc786445e7a8c62aba11e8e75 Author: Cecilia Ni <ceciliani@google.com> Date: Thu Dec 13 01:52:06 2018 [App Management] Refactor main view This CL adds an app-management-item element, and creates shared constants, css and vars files. Bug: 906508 Change-Id: I29dce3a6745e8957ee1fb547cbe2e72290567f28 Reviewed-on: https://chromium-review.googlesource.com/c/1371308 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#616156} [modify] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/browser_resources.grd [modify] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/constants.js [add] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/item.html [add] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/item.js [modify] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/main_view.html [modify] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/main_view.js [add] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/shared_style.html [add] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/resources/app_management/shared_vars.html [modify] https://crrev.com/45dbfb9cd0326e7fc786445e7a8c62aba11e8e75/chrome/browser/ui/webui/app_management/app_management_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/124d0d419086705a616b1039fb63067679886069 commit 124d0d419086705a616b1039fb63067679886069 Author: Reka Norman <rekanorman@google.com> Date: Thu Dec 13 04:46:45 2018 [App Management] Add app management Store. This CL implements the app management Store and StoreClient, and adds an action and a reducer to handle the onAppsAdded event. Bug: 906508 Change-Id: I8bd4635ae7048e862f378c41cb63b9fe1e3342c6 Reviewed-on: https://chromium-review.googlesource.com/c/1371304 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#616216} [modify] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/browser_resources.grd [modify] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/BUILD.gn [add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/actions.html [add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/actions.js [modify] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/app.html [modify] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/app.js [modify] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/fake_page_handler.js [add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/reducers.html [add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/reducers.js [add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/store.html [add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/store.js [add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/store_client.html [add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/store_client.js [add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/types.js [add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/util.html [add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/resources/app_management/util.js [modify] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/browser/ui/webui/app_management/app_management_ui.cc [modify] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/test/data/webui/app_management/app_management_browsertest.js [add] https://crrev.com/124d0d419086705a616b1039fb63067679886069/chrome/test/data/webui/app_management/reducers_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5deb7d1b14ba1cfa12428d3de3e3439ca1656df commit d5deb7d1b14ba1cfa12428d3de3e3439ca1656df Author: Melissa Zhang <melzhang@google.com> Date: Thu Dec 13 23:39:26 2018 Add Fields to App Struct This CL adds optional fields to the app struct. BUG=906508 Change-Id: I6fd79a95813d2c2d022c051de869b827178b251a Reviewed-on: https://chromium-review.googlesource.com/c/1375192 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Melissa Zhang <melzhang@google.com> Cr-Commit-Position: refs/heads/master@{#616491} [modify] https://crrev.com/d5deb7d1b14ba1cfa12428d3de3e3439ca1656df/chrome/browser/ui/webui/app_management/app_management.mojom [modify] https://crrev.com/d5deb7d1b14ba1cfa12428d3de3e3439ca1656df/chrome/browser/ui/webui/app_management/app_management_page_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30f0df7d4ffca78defe7cf131eca562c2e6d358e commit 30f0df7d4ffca78defe7cf131eca562c2e6d358e Author: Reka Norman <rekanorman@google.com> Date: Thu Dec 13 23:45:09 2018 [App Management] Make main view a StoreClient. This CL makes the app management main view a StoreClient, so that its list of apps is linked to the apps in the Store. Bug: 906508 Change-Id: Icb1c9755ced7a1bb8ed5e96bc12e7ecec1d87f42 Reviewed-on: https://chromium-review.googlesource.com/c/1372973 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#616498} [modify] https://crrev.com/30f0df7d4ffca78defe7cf131eca562c2e6d358e/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/30f0df7d4ffca78defe7cf131eca562c2e6d358e/chrome/browser/resources/app_management/main_view.html [modify] https://crrev.com/30f0df7d4ffca78defe7cf131eca562c2e6d358e/chrome/browser/resources/app_management/main_view.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8537b53afdaab28cdad6f09de652102a90bd4cc commit f8537b53afdaab28cdad6f09de652102a90bd4cc Author: Reka Norman <rekanorman@google.com> Date: Fri Dec 14 01:33:01 2018 [App Management] Add onAppChanged and onAppRemoved listeners. This CL adds actions and reducers to handle the onAppChanged and onAppRemoved events, as well as tests for these reducers. Bug: 906508 Change-Id: I7b809e1030f33ea772a8d74343b45189f199f1fe Reviewed-on: https://chromium-review.googlesource.com/c/1375290 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#616549} [modify] https://crrev.com/f8537b53afdaab28cdad6f09de652102a90bd4cc/chrome/browser/resources/app_management/actions.js [modify] https://crrev.com/f8537b53afdaab28cdad6f09de652102a90bd4cc/chrome/browser/resources/app_management/app.js [modify] https://crrev.com/f8537b53afdaab28cdad6f09de652102a90bd4cc/chrome/browser/resources/app_management/reducers.js [modify] https://crrev.com/f8537b53afdaab28cdad6f09de652102a90bd4cc/chrome/test/data/webui/app_management/reducers_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06c0f4533cd4607334fe101cc74d04752cde1516 commit 06c0f4533cd4607334fe101cc74d04752cde1516 Author: Reka Norman <rekanorman@google.com> Date: Fri Dec 14 03:26:08 2018 [App Management] Make TestStore generic. This CL makes the bookmarks TestStore generic, so that it can be extended to create test stores for different store implementation classes. Bug: 906508 Change-Id: I80831d93c747e7b8964e3630719549277b9a0618 Reviewed-on: https://chromium-review.googlesource.com/c/1372969 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#616573} [modify] https://crrev.com/06c0f4533cd4607334fe101cc74d04752cde1516/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js [modify] https://crrev.com/06c0f4533cd4607334fe101cc74d04752cde1516/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js [modify] https://crrev.com/06c0f4533cd4607334fe101cc74d04752cde1516/chrome/test/data/webui/md_bookmarks/test_store.js [add] https://crrev.com/06c0f4533cd4607334fe101cc74d04752cde1516/chrome/test/data/webui/test_store.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975 commit b9c63b5aaa586626f3a2a47ced4ff516b5b0a975 Author: Cecilia Ni <ceciliani@google.com> Date: Tue Dec 18 08:45:58 2018 [App Management] Add Permission Page for PWA This CL adds a permissions page for PWAs. It also cleans up and rationalizes all the HTML/CSS for App Management. Bug: 906508 Change-Id: I806f7269958cc83e4f9112d307f679ef0d300e05 Reviewed-on: https://chromium-review.googlesource.com/c/1373931 Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Cecilia Ni <ceciliani@google.com> Cr-Commit-Position: refs/heads/master@{#617418} [modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/app/app_management_strings.grdp [modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/browser_resources.grd [modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/app.html [modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/fake_page_handler.js [modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/item.html [modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/main_view.html [modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/main_view.js [add] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/pwa_permission_view.html [add] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/pwa_permission_view.js [modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/shared_style.html [modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/resources/app_management/shared_vars.html [modify] https://crrev.com/b9c63b5aaa586626f3a2a47ced4ff516b5b0a975/chrome/browser/ui/webui/app_management/app_management_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa61f5797f69e60c601ed237e99cee2222af72c7 commit fa61f5797f69e60c601ed237e99cee2222af72c7 Author: Cecilia Ni <ceciliani@google.com> Date: Wed Dec 19 09:10:42 2018 [App Management] Add Test for Main View This CL sets up tests for the main view of the App Management page. It also refactors the backend listeners into their own api_listener.js. Bug: 906508 Change-Id: I2a0d809ddf71e559312d031c1d34d60bede45f89 Reviewed-on: https://chromium-review.googlesource.com/c/1373274 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#617775} [modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/browser_resources.grd [modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/BUILD.gn [add] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/api_listener.html [add] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/api_listener.js [modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/app.html [modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/app.js [modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/browser_proxy.html [modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/browser_proxy.js [modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/fake_page_handler.js [modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/resources/app_management/main_view.html [modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/browser/ui/webui/app_management/app_management_ui.cc [modify] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/test/data/webui/app_management/app_management_browsertest.js [add] https://crrev.com/fa61f5797f69e60c601ed237e99cee2222af72c7/chrome/test/data/webui/app_management/main_view_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c5300bd86737e8c45e60cb6ee2f7320d4437300 commit 0c5300bd86737e8c45e60cb6ee2f7320d4437300 Author: Reka Norman <rekanorman@google.com> Date: Thu Dec 20 07:44:30 2018 [App Management] Add router. This CL sets up routing for the app management page. It also adds an action and a reducer to handle changing to a different subpage within the app management page. Bug: 906508 Change-Id: I5b877cc7aed66c7626045d08066bac9ccc59b5d2 Reviewed-on: https://chromium-review.googlesource.com/c/1381356 Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Reka Norman <rekanorman@google.com> Cr-Commit-Position: refs/heads/master@{#618133} [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/browser_resources.grd [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/actions.js [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/api_listener.js [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/app.html [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/constants.js [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/index.html [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/item.html [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/item.js [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/main_view.html [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/pwa_permission_view.html [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/reducers.js [add] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/router.html [add] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/router.js [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/store.html [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/store_client.html [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/types.js [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/resources/app_management/util.js [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/browser/ui/webui/app_management/app_management_ui.cc [modify] https://crrev.com/0c5300bd86737e8c45e60cb6ee2f7320d4437300/chrome/test/data/webui/app_management/reducers_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4e256e503f02676f6b5796e39ac33374ce6c0a4 commit e4e256e503f02676f6b5796e39ac33374ce6c0a4 Author: Cecilia Ni <ceciliani@google.com> Date: Thu Dec 27 05:10:19 2018 [App Management] Add notification block in main view This CL sets up the notification block within the main view. Bug: 906508 Change-Id: I13e93b7e0db927235b69ee5d43ba0d099ddbf49e Reviewed-on: https://chromium-review.googlesource.com/c/1381293 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#619006} [modify] https://crrev.com/e4e256e503f02676f6b5796e39ac33374ce6c0a4/chrome/app/app_management_strings.grdp [modify] https://crrev.com/e4e256e503f02676f6b5796e39ac33374ce6c0a4/chrome/browser/resources/app_management/main_view.html [modify] https://crrev.com/e4e256e503f02676f6b5796e39ac33374ce6c0a4/chrome/browser/resources/app_management/main_view.js [modify] https://crrev.com/e4e256e503f02676f6b5796e39ac33374ce6c0a4/chrome/browser/resources/app_management/pwa_permission_view.html [modify] https://crrev.com/e4e256e503f02676f6b5796e39ac33374ce6c0a4/chrome/browser/resources/app_management/shared_style.html [modify] https://crrev.com/e4e256e503f02676f6b5796e39ac33374ce6c0a4/chrome/browser/ui/webui/app_management/app_management_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f09a3f4eefbd31e4938f5ef679607ba1ff79490 commit 3f09a3f4eefbd31e4938f5ef679607ba1ff79490 Author: Cecilia Ni <ceciliani@google.com> Date: Fri Dec 28 07:08:50 2018 [App Management] Add chrome permission view This CL sets up the permission view of native chrome apps. Bug: 906508 Change-Id: Ic4996adf9b963a15c58db582d644f0c5441def56 Reviewed-on: https://chromium-review.googlesource.com/c/1388046 Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Cecilia Ni <ceciliani@google.com> Cr-Commit-Position: refs/heads/master@{#619128} [modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/browser_resources.grd [modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/app.html [add] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/chrome_app_permission_view.html [add] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/chrome_app_permission_view.js [modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/item.js [modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/pwa_permission_view.html [modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/pwa_permission_view.js [modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/shared_style.html [modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/resources/app_management/util.js [modify] https://crrev.com/3f09a3f4eefbd31e4938f5ef679607ba1ff79490/chrome/browser/ui/webui/app_management/app_management_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c commit ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c Author: Cecilia Ni <ceciliani@google.com> Date: Wed Jan 02 04:00:30 2019 [App Management] Add Metadata View This CL sets up metadata view for chrome permission view and pwa permission view. Bug: 906508 Change-Id: I81d4ed5b1946ede773a802809ef27e945bd3a4ef Reviewed-on: https://chromium-review.googlesource.com/c/1390777 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#619366} [modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/app/app_management_strings.grdp [modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/browser_resources.grd [modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/resources/app_management/chrome_app_permission_view.html [modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/resources/app_management/fake_page_handler.js [modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/resources/app_management/main_view.html [add] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/resources/app_management/metadata_view.html [add] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/resources/app_management/metadata_view.js [modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/resources/app_management/pwa_permission_view.html [modify] https://crrev.com/ed6ad8b7af19456d68eb9f05d1ccf27b91519c2c/chrome/browser/ui/webui/app_management/app_management_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29ac4289d27a7510d2ff15f94aa2f716be673bfc commit 29ac4289d27a7510d2ff15f94aa2f716be673bfc Author: Reka Norman <rekanorman@google.com> Date: Thu Jan 03 06:23:09 2019 [App Management] Add permissions to fake backend. This CL adds a permissions map to the app struct used by the fake backend, and allows these permissions to be toggled in the PWA permission view. Bug: 906508 Change-Id: I292671d5f4fa9034fac10eba421380aaef8367ad Reviewed-on: https://chromium-review.googlesource.com/c/1388128 Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Reka Norman <rekanorman@google.com> Cr-Commit-Position: refs/heads/master@{#619596} [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/app/app_management_strings.grdp [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/browser_resources.grd [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/app.html [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/app.js [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/browser_proxy.js [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/constants.js [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/fake_page_handler.js [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/item.js [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/main_view.js [add] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/permission_item.html [add] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/permission_item.js [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/pwa_permission_view.html [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/pwa_permission_view.js [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/reducers.js [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/shared_style.html [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/types.js [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/resources/app_management/util.js [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/ui/webui/app_management/app_management.mojom [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/browser/ui/webui/app_management/app_management_ui.cc [modify] https://crrev.com/29ac4289d27a7510d2ff15f94aa2f716be673bfc/chrome/test/data/webui/app_management/reducers_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd17ee6680529b13d3da1a1fc72b2822f0ef873a commit fd17ee6680529b13d3da1a1fc72b2822f0ef873a Author: Cecilia Ni <ceciliani@google.com> Date: Fri Jan 04 06:25:56 2019 [App Management] Refactor permission-view-header to a new element This CL extracts permission view header from chrome app permission view and pwa permission view to avoid duplicate code. Bug: 906508 Change-Id: If4335bf7fcf70ec2b5d429f1b632c66839ec6853 Reviewed-on: https://chromium-review.googlesource.com/c/1393127 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Cecilia Ni <ceciliani@google.com> Cr-Commit-Position: refs/heads/master@{#619891} [modify] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/browser_resources.grd [modify] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/resources/app_management/chrome_app_permission_view.html [modify] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/resources/app_management/chrome_app_permission_view.js [add] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/resources/app_management/permission_view_header.html [add] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/resources/app_management/permission_view_header.js [modify] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/resources/app_management/pwa_permission_view.html [modify] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/resources/app_management/shared_style.html [modify] https://crrev.com/fd17ee6680529b13d3da1a1fc72b2822f0ef873a/chrome/browser/ui/webui/app_management/app_management_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba1b5893f90c959be73406a3d0b72b6fa13608de commit ba1b5893f90c959be73406a3d0b72b6fa13608de Author: Reka Norman <rekanorman@google.com> Date: Fri Jan 04 06:45:57 2019 [App Management] GetApps returns array of initial apps. This CL changes the GetApps function of the app management PageHandler to return the initial apps directly rather than calling onAppsAdded, which simplifies initialisation of the ApiListener. It also changes the onAppsAdded function to onAppAdded. Bug: 906508 Change-Id: I649530920dfcce9d3998d9b2eda0320244ced15c Reviewed-on: https://chromium-review.googlesource.com/c/1393587 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#619894} [modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/browser/resources/app_management/actions.js [modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/browser/resources/app_management/api_listener.js [modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/browser/resources/app_management/fake_page_handler.js [modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/browser/resources/app_management/reducers.js [modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/browser/ui/webui/app_management/app_management.mojom [modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/browser/ui/webui/app_management/app_management_page_handler.cc [modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/browser/ui/webui/app_management/app_management_page_handler.h [modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/test/data/webui/app_management/app_test.js [modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/test/data/webui/app_management/main_view_test.js [modify] https://crrev.com/ba1b5893f90c959be73406a3d0b72b6fa13608de/chrome/test/data/webui/app_management/reducers_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a95575e09470671206e8f43de340d524badab5d commit 8a95575e09470671206e8f43de340d524badab5d Author: Reka Norman <rekanorman@google.com> Date: Sun Jan 06 23:42:48 2019 [App Management] Link chrome apps permission view to store. This CL links the chrome apps permission view to data from the store, so that it is only displayed when a chrome app is selected from the list of apps. Bug: 906508 Change-Id: I30608461bb70f5258e6f5b28ab80bf04603b444c Reviewed-on: https://chromium-review.googlesource.com/c/1394105 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#620234} [modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/app.html [modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/app.js [modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/browser_proxy.js [modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/chrome_app_permission_view.html [modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/chrome_app_permission_view.js [modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/fake_page_handler.js [modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/permission_view_header.html [modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/permission_view_header.js [modify] https://crrev.com/8a95575e09470671206e8f43de340d524badab5d/chrome/browser/resources/app_management/pwa_permission_view.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d3e063c18bd7ba5d059706c3f45609c968a3057 commit 7d3e063c18bd7ba5d059706c3f45609c968a3057 Author: Cecilia Ni <ceciliani@google.com> Date: Tue Jan 08 07:25:19 2019 [App Management] Make notification sublabel displays properly This CL sets up internationalization and plural string of the notification sublabel. Bug: 906508 Change-Id: I7190bc7e47e16658bdc035d7488cb2ff151e5ddf Reviewed-on: https://chromium-review.googlesource.com/c/1390785 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#620643} [modify] https://crrev.com/7d3e063c18bd7ba5d059706c3f45609c968a3057/chrome/app/app_management_strings.grdp [modify] https://crrev.com/7d3e063c18bd7ba5d059706c3f45609c968a3057/chrome/browser/resources/app_management/constants.js [modify] https://crrev.com/7d3e063c18bd7ba5d059706c3f45609c968a3057/chrome/browser/resources/app_management/main_view.html [modify] https://crrev.com/7d3e063c18bd7ba5d059706c3f45609c968a3057/chrome/browser/resources/app_management/main_view.js [modify] https://crrev.com/7d3e063c18bd7ba5d059706c3f45609c968a3057/chrome/browser/resources/app_management/shared_style.html [modify] https://crrev.com/7d3e063c18bd7ba5d059706c3f45609c968a3057/chrome/browser/ui/webui/app_management/app_management_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8 commit 5faf8294117a46b977dccf7ff6bd7dc94f19ddf8 Author: Reka Norman <rekanorman@google.com> Date: Fri Jan 11 05:34:42 2019 [App Management] Link UI to backend permissions. This CL updates the front end of the app management page to use the real Permission struct, and links the UI components to the backend SetPermission method, allowing the permissions of real apps to be toggled from the UI. Bug: 906508 Change-Id: Ia401df34e138893d8186c67413588aafdadafc19 Reviewed-on: https://chromium-review.googlesource.com/c/1404538 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Reka Norman <rekanorman@google.com> Cr-Commit-Position: refs/heads/master@{#621917} [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/app.js [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/browser_proxy.js [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/constants.js [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/fake_page_handler.js [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/index.html [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/metadata_view.js [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/permission_item.html [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/permission_item.js [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/permission_view_header.js [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/pwa_permission_view.html [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/types.js [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/resources/app_management/util.js [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/ui/webui/app_management/app_management.mojom [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/browser/ui/webui/app_management/app_management_page_handler.cc [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/services/app_service/public/mojom/types.mojom [modify] https://crrev.com/5faf8294117a46b977dccf7ff6bd7dc94f19ddf8/chrome/test/data/webui/app_management/app_management_browsertest.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83b2e6e78de756204516bac99dc01c9aaa9fb42a commit 83b2e6e78de756204516bac99dc01c9aaa9fb42a Author: Reka Norman <rekanorman@google.com> Date: Sun Jan 13 23:13:06 2019 [App Management] Implement App Service updates for installation/uninstallation of extensions. This CL implements the OnExtensionInstalled and OnExtensionUninstalled methods of the ExtensionApps App Service publisher, so that updates are sent to the App Service subscribers. This allows live updates to be observed when apps are installed or uninstalled in the UI. Bug: 906508 Change-Id: Ic14b7f1b49ccfd77e9f90fe2956dfa4c09af069b Reviewed-on: https://chromium-review.googlesource.com/c/1404547 Reviewed-by: Nigel Tao <nigeltao@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Reka Norman <rekanorman@google.com> Cr-Commit-Position: refs/heads/master@{#622361} [modify] https://crrev.com/83b2e6e78de756204516bac99dc01c9aaa9fb42a/chrome/browser/apps/app_service/extension_apps.cc [modify] https://crrev.com/83b2e6e78de756204516bac99dc01c9aaa9fb42a/chrome/browser/apps/app_service/extension_apps.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/481af38cb355bc279458dd9838e19ab1b99709d0 commit 481af38cb355bc279458dd9838e19ab1b99709d0 Author: Reka Norman <rekanorman@google.com> Date: Mon Jan 14 03:08:38 2019 [App Management] Implement the App Service Uninstall method for extensions. This CL implements the Uninstall method for the ExtensionApps App Service publisher, and links the UI to this method through the App Service, allowing extensions to be uninstalled in response to UI events. Bug: 906508 Change-Id: I7108e5b3d6f684b80fe996b720c75a7af3a318bc Reviewed-on: https://chromium-review.googlesource.com/c/1405150 Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Nigel Tao <nigeltao@chromium.org> Commit-Queue: Reka Norman <rekanorman@google.com> Cr-Commit-Position: refs/heads/master@{#622376} [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/app_service_proxy.cc [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/app_service_proxy.h [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/arc_apps.cc [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/arc_apps.h [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/built_in_chromeos_apps.cc [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/built_in_chromeos_apps.h [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/extension_apps.cc [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/apps/app_service/extension_apps.h [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/resources/app_management/permission_view_header.js [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/ui/webui/app_management/app_management.mojom [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/ui/webui/app_management/app_management_page_handler.cc [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/browser/ui/webui/app_management/app_management_page_handler.h [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/services/app_service/app_service_impl.cc [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/services/app_service/app_service_impl.h [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/services/app_service/app_service_impl_unittest.cc [modify] https://crrev.com/481af38cb355bc279458dd9838e19ab1b99709d0/chrome/services/app_service/public/mojom/app_service.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b08ccf5d915dc85a541e00d28fadf3105efb595e commit b08ccf5d915dc85a541e00d28fadf3105efb595e Author: Reka Norman <rekanorman@google.com> Date: Mon Jan 14 04:09:48 2019 [App Management] Implement the OpenNativeSettings App Service method for extensions. This CL implements the OpenNativeSettings method for the ExtensionApps App Service publisher. For now, it supports two types of extensions: for hosted apps, it opens the corresponding site settings page; for the Chrome Apps which appear on the chrome://extensions page, it opens the extensions detail page for that app. Bug: 906508 Change-Id: I6f5cee42d9f909e3c24bbecd91b5fe8d37923338 Reviewed-on: https://chromium-review.googlesource.com/c/1405112 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by: Nigel Tao <nigeltao@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#622381} [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/app_service_proxy.cc [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/app_service_proxy.h [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/arc_apps.cc [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/arc_apps.h [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/built_in_chromeos_apps.cc [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/built_in_chromeos_apps.h [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/extension_apps.cc [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/apps/app_service/extension_apps.h [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/resources/app_management/fake_page_handler.js [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/resources/app_management/pwa_permission_view.html [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/resources/app_management/pwa_permission_view.js [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/ui/webui/app_management/app_management.mojom [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/ui/webui/app_management/app_management_page_handler.cc [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/browser/ui/webui/app_management/app_management_page_handler.h [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/services/app_service/app_service_impl.cc [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/services/app_service/app_service_impl.h [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/services/app_service/app_service_impl_unittest.cc [modify] https://crrev.com/b08ccf5d915dc85a541e00d28fadf3105efb595e/chrome/services/app_service/public/mojom/app_service.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0059f6285bc1f26b933d932ef459f8c0174acc5a commit 0059f6285bc1f26b933d932ef459f8c0174acc5a Author: Cecilia Ni <ceciliani@google.com> Date: Tue Jan 15 05:34:13 2019 [App Management] Add Chrome App Permission Mapping This CL makes chrome app permission view display the actual permissions strings in an unordered list by fetching permission messages from extension registry. Bug: 906508 Change-Id: If936131faa4f622ea98d42208f0fa5a90c469ec7 Reviewed-on: https://chromium-review.googlesource.com/c/1404539 Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Cecilia Ni <ceciliani@google.com> Cr-Commit-Position: refs/heads/master@{#622744} [modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/resources/app_management/chrome_app_permission_view.html [modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/resources/app_management/chrome_app_permission_view.js [modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/resources/app_management/fake_page_handler.js [modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/resources/app_management/main_view.js [modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/resources/app_management/permission_item.js [modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/resources/app_management/types.js [modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/ui/webui/app_management/app_management.mojom [modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/ui/webui/app_management/app_management_page_handler.cc [modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/ui/webui/app_management/app_management_page_handler.h [modify] https://crrev.com/0059f6285bc1f26b933d932ef459f8c0174acc5a/chrome/browser/ui/webui/app_management/app_management_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5235b08f05b13b6b7e81a748824358f5be8447d8 commit 5235b08f05b13b6b7e81a748824358f5be8447d8 Author: Reka Norman <rekanorman@google.com> Date: Thu Jan 17 02:19:11 2019 [App Management] Implement Pin to Shelf. This CL implements pinning apps to the shelf from the app management page, by making the PageHandler a ShelfModelObserver. Since the shelf only exists on Chrome OS, this required creating a Chrome OS specific subclass of the the PageHandler (AppManagementPageHandlerCros) to handle the shelf-related functionality. Bug: 906508 Change-Id: I135c0aab5c1ffaaa76e9d1f094c880ab53cd7562 Reviewed-on: https://chromium-review.googlesource.com/c/1410954 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#623516} [modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/resources/app_management/constants.js [modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/resources/app_management/fake_page_handler.js [modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/resources/app_management/metadata_view.html [modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/resources/app_management/metadata_view.js [modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/resources/app_management/permission_item.js [modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/ui/webui/app_management/app_management.mojom [modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/ui/webui/app_management/app_management_page_handler.cc [modify] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/ui/webui/app_management/app_management_page_handler.h [add] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/ui/webui/app_management/app_management_shelf_delegate_chromeos.cc [add] https://crrev.com/5235b08f05b13b6b7e81a748824358f5be8447d8/chrome/browser/ui/webui/app_management/app_management_shelf_delegate_chromeos.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c74feeaecfd7fb42201c90e1305d6b3414b58e8 commit 5c74feeaecfd7fb42201c90e1305d6b3414b58e8 Author: Cecilia Ni <ceciliani@google.com> Date: Mon Jan 21 10:50:26 2019 [App Management] Add notification view This CL sets up notification view to view all apps' notification settings. Bug: 906508 Change-Id: I05261b33cfec8b48df44d8f58c80e8e1298f65fc Reviewed-on: https://chromium-review.googlesource.com/c/1392684 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#624550} [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/browser_resources.grd [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/app.html [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/app.js [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/constants.js [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/item.html [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/main_view.html [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/main_view.js [add] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/notifications_view.html [add] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/notifications_view.js [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/permission_view_header.html [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/permission_view_header.js [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/pwa_permission_view.html [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/pwa_permission_view.js [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/reducers.js [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/router.html [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/router.js [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/resources/app_management/shared_style.html [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/browser/ui/webui/app_management/app_management_ui.cc [modify] https://crrev.com/5c74feeaecfd7fb42201c90e1305d6b3414b58e8/chrome/test/data/webui/app_management/reducers_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4507712ec42fdd91c0ef9bacbe092fce8a108f5d commit 4507712ec42fdd91c0ef9bacbe092fce8a108f5d Author: Cecilia Ni <ceciliani@google.com> Date: Mon Jan 21 12:24:39 2019 [App Management] UI Fix-up For High Priority Issue This CL fixes the most pressing issues of current UI layout: 1. Permission item doesn't have icons. 2. Permission item doesn't match mocks. 3. Line height is not correct, and it should be 1.54. 4. Font weight of header text is not right, and it should be 500. Bug: 906508 Change-Id: I8c22cc3cd8175b2c61b335421a088f3702adaf1f Reviewed-on: https://chromium-review.googlesource.com/c/1411192 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#624564} [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/BUILD.gn [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/actions.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/api_listener.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/api_listener.js [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/app.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/constants.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/main_view.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/metadata_view.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/permission_item.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/permission_item.js [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/permission_view_header.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/pwa_permission_view.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/reducers.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/shared_style.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/shared_vars.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/store.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/store_client.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/chrome/browser/resources/app_management/util.html [modify] https://crrev.com/4507712ec42fdd91c0ef9bacbe092fce8a108f5d/ui/webui/resources/cr_elements/icons.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4578dbc1b5d05f7f2514113418e60eccc6cdf96 commit d4578dbc1b5d05f7f2514113418e60eccc6cdf96 Author: Cecilia Ni <ceciliani@google.com> Date: Mon Jan 21 12:40:02 2019 [App Management] Add test for notification sublabel This CL sets up tests for notification sublabel. Bug: 906508 Change-Id: Ic8f2377250ba74a672e00e85891d03a2d4fa9011 Reviewed-on: https://chromium-review.googlesource.com/c/1392686 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#624569} [modify] https://crrev.com/d4578dbc1b5d05f7f2514113418e60eccc6cdf96/chrome/browser/resources/app_management/main_view.js [modify] https://crrev.com/d4578dbc1b5d05f7f2514113418e60eccc6cdf96/chrome/test/data/webui/app_management/main_view_test.js
Comment 1 by bugdroid1@chromium.org
, Nov 19