New issue
Advanced search Search tips

Issue 906507 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Bookmark Manager menu no longer shows separators

Project Member Reported by calamity@chromium.org, Nov 19

Issue description

This is happening because the <hr>s are not annotated with slot="item", but really, we should just go back to the old cr-action-menu API of using the entire light DOM, and remove the 'item' filter.
 
Screenshot 2018-11-19 at 17.30.45.png
25.3 KB View Download
@calamity: The named slot was added at [1], as a replacement to

<content select=".dropdown-item,hr" ...></content>

Are you sure that fully removing the named slot, will not result in unwanted content appearing within the action menu? 

[1] https://chromium-review.googlesource.com/c/chromium/src/+/898403/3/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ae5f8de98d45794220de278e7313de5b181368a

commit 6ae5f8de98d45794220de278e7313de5b181368a
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Dec 10 11:03:56 2018

[cr-action-menu] Use default slot.

This CL changes the API of cr-action-menu to use the entire light dom
supplied by the client. This was changed as part of the Polymer 2
upgrade to use a named slot, but since the action menu has no sections,
it may as well use the entire client light dom.

This CL fixes an issue where menu separators in the Bookmark Manager
were not being pulled into the cr-action-menu because they didn't
specify slot="item".

Bug:  906507 
Change-Id: I43e4380370d810c3f12228d83072027a282ff8d6
Reviewed-on: https://chromium-review.googlesource.com/c/1341731
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615081}
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/md_bookmarks/command_manager.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/md_downloads/toolbar.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/md_extensions/runtime_host_permissions.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/md_history/history_list.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/md_history/synced_device_manager.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/autofill_page/autofill_section.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/autofill_page/passwords_section.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/autofill_page/payments_section.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/people_page/account_manager.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/people_page/sync_account_control.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/site_settings/site_entry.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/chrome/test/data/webui/cr_elements/cr_action_menu_test.js
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/ui/webui/resources/cr_components/certificate_manager/certificate_subentry.html
[modify] https://crrev.com/6ae5f8de98d45794220de278e7313de5b181368a/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html

Status: Fixed (was: Started)

Sign in to add a comment