Multicol list-item with hidden overflow inserts blank line before spanner on relayout |
|||
Issue descriptionWPT import https://crrev.com/c/1341138 introduced new failures in external/wpt/css/css-multicol: List of new failures: virtual/layout_ng_experimental/external/wpt/css/css-multicol/multicol-span-all-list-item-002.html [ Failure ] virtual/layout_ng_experimental/external/wpt/css/css-multicol/multicol-span-all-list-item-001.html [ Failure ] external/wpt/css/css-multicol/multicol-span-all-list-item-002.html [ Failure ] This import contains upstream changes from b603262eb6add91220b57cd0ad5e0d625f838584 to 02c382e596c7f3034e210c8547cd2a5032d71cca: Fix bullet frame creation for columns.: https://github.com/web-platform-tests/wpt/commit/02c382e596c7f3034e210c8547cd2a5032d71cca [affecting this directory]
,
Nov 18
The root cause for the differences between the test and the ref in multicol-span-all-list-item-002.html is that when a list-item multicol container with hidden overflow gets relayout, but has fixed width, so that it doesn't have to descend into the children, a blank line (for the marker, no doubt) appears above the spanner.
,
Nov 18
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4837f38ca48b944f0c9b1a3d7e6c4f3031e5f12 commit d4837f38ca48b944f0c9b1a3d7e6c4f3031e5f12 Author: Morten Stenshorne <mstensho@chromium.org> Date: Mon Nov 19 00:01:57 2018 Update bug numbers for new imported multicol tests. The new LayoutNG test failures are just because LayoutNGBlockFragmentation has no support for column spanners. TBR=kojii@chromium.org Bug: 906385 Change-Id: I7c1dd2be1e46afd7ad6cd9629ccfe98b1b7a5007 Reviewed-on: https://chromium-review.googlesource.com/c/1341528 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#609156} [modify] https://crrev.com/d4837f38ca48b944f0c9b1a3d7e6c4f3031e5f12/third_party/WebKit/LayoutTests/TestExpectations |
|||
►
Sign in to add a comment |
|||
Comment 1 by mstensho@chromium.org
, Nov 18